1. 28 Apr, 2022 1 commit
    • Simon Zünd's avatar
      [builtins] Add 'RestartFrameTrampoline' · b0118171
      Simon Zünd authored
      Doc: https://bit.ly/revive-restart-frame
      Context: https://crrev.com/c/3582395 (jumbo CL with the whole feature)
      
      This CL adds a new builtin called "RestartFrameTrampoline". This
      trampoline is relatively simple: It leaves the current frame and
      re-invokes the function. This essentially restarts the function and
      is one of the key components required to bring back the "Restart
      frame" DevTools debugging feature.
      
      The builtin is closely related to the "FrameDropperTrampoline"
      removed in the CL https://crrev.com/c/2854750. The key difference
      is that the "FrameDropperTrampoline" dropped to an "arbitrary"
      frame pointer before restarting the function (arbitrary in the
      sense that it was provided as an argument). This caused issues
      as the feature was implemented in a way that the frame pointer
      wasn't necessarily valid anymore.
      
      In comparison, the "RestartFrameTrampoline" relies on the V8
      unwinder to drop it in the correct frame first and is then
      invoked via either the CEntry stub or the deoptimizer
      (see design doc for details).
      
      Bug: chromium:1303521
      Change-Id: I7bd46620808f8694c2c776b8bcd267e525d5b581
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585944
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80254}
      b0118171
  2. 27 Apr, 2022 2 commits
  3. 26 Apr, 2022 1 commit
  4. 22 Apr, 2022 1 commit
  5. 12 Apr, 2022 1 commit
  6. 06 Apr, 2022 1 commit
  7. 04 Apr, 2022 1 commit
    • Jakob Gruber's avatar
      [osr] Fall back to synchronous OSR on cache mismatches · 3f5a3df6
      Jakob Gruber authored
      If we've already cached OSR'd code for the current function but with a
      different osr offset, fall back to synchronous compilation. This avoids
      degenerate cases where we repeatedly spawn OSR jobs but then fail to
      install them.
      
      Drive-by: More consistent --trace-osr output.
      Drive-by: Rename kCompileForOnStackReplacement to kCompileOptimizeOSR
      for name consistency.
      Drive-by: Add JSFunction::DebugNameCStr() for more convenient PrintF's.
      
      Bug: v8:12161
      Change-Id: I2b4a65bc9e082d85d7048a3e92ef86b07d396687
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3560431Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Jakob Linke <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79761}
      3f5a3df6
  8. 30 Mar, 2022 2 commits
  9. 22 Mar, 2022 1 commit
  10. 17 Mar, 2022 1 commit
  11. 16 Mar, 2022 1 commit
  12. 14 Mar, 2022 1 commit
  13. 25 Feb, 2022 1 commit
  14. 15 Feb, 2022 1 commit
  15. 27 Jan, 2022 2 commits
  16. 26 Jan, 2022 1 commit
  17. 18 Jan, 2022 1 commit
  18. 14 Jan, 2022 1 commit
  19. 24 Dec, 2021 1 commit
  20. 24 Nov, 2021 1 commit
  21. 18 Nov, 2021 1 commit
  22. 16 Nov, 2021 1 commit
  23. 09 Nov, 2021 1 commit
  24. 29 Oct, 2021 1 commit
  25. 26 Oct, 2021 1 commit
  26. 25 Oct, 2021 1 commit
  27. 22 Oct, 2021 1 commit
  28. 12 Oct, 2021 1 commit
  29. 07 Sep, 2021 1 commit
  30. 12 Aug, 2021 1 commit
  31. 04 Aug, 2021 1 commit
  32. 03 Aug, 2021 1 commit
  33. 19 Jul, 2021 2 commits
  34. 01 Jul, 2021 1 commit
  35. 30 Jun, 2021 1 commit
  36. 28 Jun, 2021 1 commit