- 03 May, 2022 1 commit
-
-
Camillo Bruni authored
To be consistent with the all the other tiers and avoid confusion, we rename --opt to ---turbofan, and --always-opt to --always-turbofan. Change-Id: Ie23dc8282b3fb4cf2fbf73b6c3d5264de5d09718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610431Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#80336}
-
- 24 Jun, 2019 1 commit
-
-
Mathias Bynens authored
It shipped in Chrome 73. Bug: v8:8021 Change-Id: I72a4e7fd3cd9ae8f960471a97100054d761d926b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593461 Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62339}
-
- 03 May, 2019 1 commit
-
-
Ross McIlroy authored
Bug: v8:8801, v8:8394 Change-Id: I6bb46ecafe1bd94adbf0409f13c9b2e558da0823 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594558 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61200}
-
- 01 May, 2019 1 commit
-
-
Sathya Gunasekaran authored
Bug: v8:5367, v8:5368 Change-Id: I86f25f9f658e21a05604f3014e6ebf74f1a8a1f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590164Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#61139}
-
- 24 Apr, 2019 2 commits
-
-
Sathya Gunasekaran authored
This reverts commit 98bbe37e. Reason for revert: breaks gc_stress bot https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22113 Original change's description: > Remove always-true --harmony-object-from-entries runtime flag > > It shipped in Chrome 73. > > Bug: v8:8021 > Change-Id: I82875829ff081ce055a0184170b15c65efca1c38 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581647 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Auto-Submit: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60992} TBR=gsathya@chromium.org,mathias@chromium.org Change-Id: I812d62a7e8b70a8646e606da5f0f8812fac330c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8021 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582882 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60994}
-
Mathias Bynens authored
It shipped in Chrome 73. Bug: v8:8021 Change-Id: I82875829ff081ce055a0184170b15c65efca1c38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581647 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60992}
-
- 16 Apr, 2019 1 commit
-
-
Joyee Cheung authored
Previously when an unresolved private name is not found in the current scope but found in an outer class scope, we forget to push it to the outer class scope so the name would never get bound. This patch simplifies ClassScope::ResolvePrivateNamesPartially() and removes the search in outer class scopes since they are incomplete at this point. Instead just push any private name that can't be resolved in the current scope to the outer class scope so that it gets handled later when the outer class scope is complete. Bug: chromium:952722 Change-Id: Ia0dda74cac57a0a1e25a9a09575f55633c6093b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567709Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#60863}
-
- 11 Feb, 2019 1 commit
-
-
Caitlin Potter authored
Currently, PRIVATE_NAME / PrivateIdentifier is not valid in ObjectLiterals or other places expecting the PropertyName production. A SyntaxError here prevents an access violation later on when attempting to dereference a null property key BUG=v8:8808 R=gsathya@chromium.org, littledan@chromium.org Change-Id: Idde9c669cb48c1595b83115351a8fe0caed40eef Reviewed-on: https://chromium-review.googlesource.com/c/1461161Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#59515}
-
- 11 Dec, 2018 1 commit
-
-
Caitlin Potter authored
This makes the deoptimizer happy, and is more consistent with other Torque JS functions. BUG=chromium:912504, v8:8021 R=tebbi@chromium.org, danno@chromium.org, mvstanton@chromium.org, gsathya@chromium.org Change-Id: I4c86db9549c367dfab7f76b49a0cf3c69d3ec50b Reviewed-on: https://chromium-review.googlesource.com/c/1366397 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#58161}
-
- 09 Nov, 2018 1 commit
-
-
Toon Verwaest authored
The current implementation isn't very helpful anyway if we ever really want this. Change-Id: Iad4132734980937aee462a1613d47887383585a0 Reviewed-on: https://chromium-review.googlesource.com/c/1328928Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57388}
-
- 24 Oct, 2018 1 commit
-
-
Caitlin Potter authored
The assertion was intended to verify that the function is only called at appropriate times (at a point when it was called both by by other builtins, and by desugarings added in the parser and during bytecode generation) --- However, it didn't account for the case where the wrapper Promise is resolved with another JSPromise with a non-callable "then" method. (Step 12 of https://tc39.github.io/ecma262/#sec-promise-resolve-functions): "If IsCallable(thenAction) is false, then Return FulfillPromise(promise, resolution)." It would be observable to verify this behaviour by loading the "then" value and asserting that it's non-callable, so instead the CSA_ASSERT is just removed and replaced with a comment explaining the appropriate use of the function. BUG=chromium:897436, v8:5855 R=bmeurer@chromium.org Change-Id: Ib4b11abfe3339409b57ccfda9c3f75a34e0db532 Reviewed-on: https://chromium-review.googlesource.com/c/1296909 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56916}
-
- 12 Jan, 2018 1 commit
-
-
Adam Klein authored
It was shipped in Chrome 63. Bug: v8:5855 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icc00b8300622d1c7b5662be8ac5e425b9781f666 Reviewed-on: https://chromium-review.googlesource.com/858381 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50558}
-
- 28 Nov, 2017 1 commit
-
-
Adam Klein authored
It was shipped in Chrome 62. Bug: v8:5546, v8:4829 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3ac318639f1f7483d4d4f4fe5606387a856be98a Reviewed-on: https://chromium-review.googlesource.com/777940Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49687}
-
- 10 Oct, 2017 1 commit
-
-
Caitlin Potter authored
Previously, JS_ASYNC_GENERATOR_OBJECT_TYPE maps led to an UNREACHABLE macro, but are now restored like ordinary JSGeneratorObjects. BUG=chromium:772649, v8:5855 R=adamk@chromium.org, yangguo@chromium.org, verwaest@chromium.org Change-Id: I02e101565625f8a057d0e5b242a5fe0df263df89 Reviewed-on: https://chromium-review.googlesource.com/706780 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48423}
-
- 04 Oct, 2017 1 commit
-
-
Caitlin Potter authored
Fix an error overwriting the `prototype` property of async generator functions when FLAG_enable_slow_asserts is enabled. Previously, the `initial_async_generator_prototype` field was never written to the native context, and was always undefined. This caused some incorrect runtime behaviour, and would crash when loading the field using the Context::initial_aysnc_generator_prototype accessor when attempting to cast the Undefined oddball to a JSObject. BUG=chromium:771470, v8:5855 R=adamk@chromium.org, verwaest@chromium.org, gsathya@chromium.org Change-Id: I13f2a518c59852bc77c2de1f2468a4eea457609e Reviewed-on: https://chromium-review.googlesource.com/700261Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#48291}
-
- 24 May, 2017 1 commit
-
-
Caitlin Potter authored
A few tests that would be good to have to verify that the known manifestations of this bug are resolved. Previously, the async generator and async function tests would crash. The other ones never did, but still resulted in the register overwite bug. BUG=v8:6322 R=adamk@chromium.org Change-Id: Ic2238227629077de5671d67d18b3bfe018dd23f4 Reviewed-on: https://chromium-review.googlesource.com/514230Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#45524}
-
- 15 Mar, 2017 1 commit
-
-
Wiktor Garbacz authored
BUG=v8:6100 Change-Id: Ib8729b2688bbaf6fb397737ccf1b1c086698ab93 Reviewed-on: https://chromium-review.googlesource.com/455876 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43822}
-
- 10 Jan, 2017 1 commit
-
-
adamk authored
It shipped with Chrome 55 stable. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2621173002 Cr-Commit-Position: refs/heads/master@{#42203}
-
- 25 Jul, 2016 1 commit
-
-
neis authored
This flag has been enabled by default for over a month now. R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2176143002 Cr-Commit-Position: refs/heads/master@{#38020}
-
- 11 Jul, 2016 1 commit
-
-
littledan authored
This patch just checks for a stack overflow and returns failure from the cases which Clusterfuzz found. However, there may be more locations in the parser which need similar treatment. R=caitpotter88@gmail.com,neis BUG=v8:4483,chromium:624300 Review-Url: https://codereview.chromium.org/2135503002 Cr-Commit-Position: refs/heads/master@{#37655}
-
- 22 Jun, 2016 1 commit
-
-
nikolaos authored
R=adamk@chromium.org BUG=chromium:621496 LOG=N Review-Url: https://codereview.chromium.org/2084703005 Cr-Commit-Position: refs/heads/master@{#37196}
-
- 21 Jun, 2016 1 commit
-
-
nikolaos authored
R=adamk@chromium.org BUG=chromium:621111 LOG=N Review-Url: https://codereview.chromium.org/2086513002 Cr-Commit-Position: refs/heads/master@{#37150}
-
- 13 Jun, 2016 1 commit
-
-
caitpotter88 authored
BUG=v8:4483, v8:4907, 618603 LOG=N R=neis@chromium.org, yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2051423003 Cr-Commit-Position: refs/heads/master@{#36938}
-
- 22 Apr, 2016 1 commit
-
-
adamk authored
The feature was deprecated in M49 and flagged off in M50. This patch removes it entirely from the codebase. Review URL: https://codereview.chromium.org/1909433003 Cr-Commit-Position: refs/heads/master@{#35714}
-
- 15 Apr, 2016 1 commit
-
-
nikolaos authored
This patch correctly re-scopes inner scopes that can appear in do expressions used as initializers to arrow parameters. R=rossberg@chromium.org BUG=v8:4904 LOG=N Review URL: https://codereview.chromium.org/1887743002 Cr-Commit-Position: refs/heads/master@{#35542}
-
- 08 Apr, 2016 1 commit
-
-
adamk authored
These were all on by default in M49 without complaint. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1858943002 Cr-Commit-Position: refs/heads/master@{#35342}
-
- 22 Mar, 2016 1 commit
-
-
adamk authored
Now that ES2015 const has shipped, in Chrome 49, legacy const declarations are no more. This lets us remove a bunch of code from many parts of the codebase. In this patch, I remove parser support for generating legacy const variables from const declarations. This also removes the special "illegal declaration" bit from Scope, which has ripples into all compiler backends. Also gone are any tests which relied on legacy const declarations. Note that we do still generate a Variable in mode CONST_LEGACY in one case: function name bindings in sloppy mode. The likely fix there is to add a new Variable::Kind for this case and handle it appropriately for stores in each backend, but I leave that for a later patch to make this one completely subtractive. Review URL: https://codereview.chromium.org/1819123002 Cr-Commit-Position: refs/heads/master@{#35002}
-
- 21 Mar, 2016 1 commit
-
-
adamk authored
Both of them shipped in Chrome 49 without incident. Also move relevant tests from harmony/ to es6/. Review URL: https://codereview.chromium.org/1815773002 Cr-Commit-Position: refs/heads/master@{#34964}
-
- 18 Mar, 2016 1 commit
-
-
adamk authored
- Move default parameters tests from harmony/ to es6/ and remove non-existent --harmony-default-parameters flag. - Remove some non-existent tests from mjsunit.status Review URL: https://codereview.chromium.org/1812313002 Cr-Commit-Position: refs/heads/master@{#34908}
-
- 15 Mar, 2016 1 commit
-
-
adamk authored
Modules already have a separate entrypoint into the engine (at the moment, this is v8::ScriptCompiler::CompileModule, though that will change to something like ParseModule). This meant that requiring a commandline flag simply added an extra complexity burden on embedders. By removing the v8 flag, this lets embedders use their own flagging mechanism (such as d8's "--module", or Blink's RuntimeEnabledFeatures) to control whether modules are to be used. Also remove old modules tests that were being skipped (since they test very old, pre-ES2015 modules syntax). R=littledan@chromium.org BUG=v8:1569, chromium:594639 LOG=y Review URL: https://codereview.chromium.org/1804693002 Cr-Commit-Position: refs/heads/master@{#34764}
-
- 10 Mar, 2016 1 commit
-
-
adamk authored
These flags have been on by default since version 4.9, which has been in stable Chrome for over a week now, demonstrating that they're here to stay. Also moved the tests out of harmony/ and into es6/. Review URL: https://codereview.chromium.org/1776683003 Cr-Commit-Position: refs/heads/master@{#34692}
-
- 01 Mar, 2016 1 commit
-
-
nikolaos authored
R=rossberg@chromium.org BUG=v8:4783 LOG=N Review URL: https://codereview.chromium.org/1747853002 Cr-Commit-Position: refs/heads/master@{#34382}
-
- 25 Feb, 2016 1 commit
-
-
littledan authored
This patch moves iterator finalization (calling .return() when a for-of loop exits early) to shipping. The only part of this feature which is currently known to be missing is destructuring--.return() should be also be called when destructuring with an array which does not end in a rest pattern, but it currently does not. The rest of this feature, including calling .return() from certain builtins, is implemented. R=adamk BUG=v8:3566 LOG=Y Review URL: https://codereview.chromium.org/1738463003 Cr-Commit-Position: refs/heads/master@{#34307}
-
- 23 Feb, 2016 1 commit
-
-
mstarzinger authored
This implements a mechanism to track the exact depth of the operand stack in full-codegen for every sub-expression visitation. So far we only tracked the depth at statement level, but not at expression level. With the introduction of do-expressions it will be possible to construct local control flow (i.e. break, continue and friends) that target labels at an arbitrary operand stack depth, making this tracking a prerequisite for full do-expression support. R=rossberg@chromium.org,jarin@chromium.org BUG=v8:4755,v8:4488 LOG=n Review URL: https://codereview.chromium.org/1706283002 Cr-Commit-Position: refs/heads/master@{#34211}
-
- 21 Jan, 2016 1 commit
-
-
nikolaos authored
It was not properly rewriting three cases: - [...[42]][0] - [...[42]].length - [...[42]] `foo` (which is a type error) R=rossberg@chromium.org BUG=v8:4696 LOG=N Review URL: https://codereview.chromium.org/1617713002 Cr-Commit-Position: refs/heads/master@{#33433}
-
- 18 Jan, 2016 1 commit
-
-
nikolaos authored
This became temporarily a big issue, because spreads are desugared into do-expressions. This patch fixes the problem with having spreads as parameter initializers in arrow expressions, e.g., this line would crash: [], ((x = [...[42]]) => x)(); R=rossberg@chromium.org BUG=chromium:578038 LOG=N Review URL: https://codereview.chromium.org/1581403007 Cr-Commit-Position: refs/heads/master@{#33365}
-
- 14 Jan, 2016 1 commit
-
-
rossberg authored
Respective declarations will explicitly initialise slots with the hole anyway, so this always was unnecessary. With varblocks it even became wrong, because block contexts may now host var bindings, which want undefined. Fixes the hole leaking when accessing an unitialised, block-context-allocated var. R=neis@chromium.org BUG=571149 LOG=N Review URL: https://codereview.chromium.org/1584243002 Cr-Commit-Position: refs/heads/master@{#33309}
-
- 12 Jan, 2016 1 commit
-
-
neis authored
R=verwaest@chromium.org BUG=chromium:576662,v8:1543 LOG=y Review URL: https://codereview.chromium.org/1580723003 Cr-Commit-Position: refs/heads/master@{#33240}
-
- 08 Jan, 2016 2 commits
-
-
littledan authored
Reland of Ship ES2015 sloppy-mode function hoisting, let, class (patchset #1 id:1 of https://codereview.chromium.org/1565263002/ ) Reason for revert: Crash fixed by https://codereview.chromium.org/1564923007 Original issue's description: > Revert of Ship ES2015 sloppy-mode function hoisting, let, class (patchset #7 id:120001 of https://codereview.chromium.org/1551443002/ ) > > Reason for revert: > Causes frequent crashes in Canary: chromium:537816 > > Original issue's description: > > Ship ES2015 sloppy-mode function hoisting, let, class > > > > This patch doesn't ship all features of ES2015 variable/scoping > > changes, notably omitting the removal of legacy const. I think > > function hoisting, let and class in sloppy mode can stand to > > themselves as a package, and the legacy const change is much > > riskier and more likely to be reverted, so my intention is to > > pursue those as a separate, follow-on patch. > > > > R=adamk@chromium.org > > BUG=v8:4285,v8:3305 > > LOG=Y > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/fcff8588a5a01587643d6c2507c7b882c78a2957 > > Cr-Commit-Position: refs/heads/master@{#33133} > > TBR=adamk@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4285,v8:3305,chromium:537816 > LOG=Y > > Committed: https://crrev.com/adac5956c6216056a211cfaa460a00ac1500d8f8 > Cr-Commit-Position: refs/heads/master@{#33162} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285,v8:3305,chromium:537816 Review URL: https://codereview.chromium.org/1571793002 Cr-Commit-Position: refs/heads/master@{#33189}
-
nikolaos authored
This patch introduces a mechanism for changing the scope of temporary variables, which is necessary for rewriting arrow parameter initializers. It also fixes a potential bug in AstExpressionVisitor, which did not visit the automatically generated members of ForEachStatement. Fixes test/mjsunit/harmony/regress/regress-4658.js R=rossberg@chromium.org BUG=v8:4658 LOG=N Review URL: https://codereview.chromium.org/1564343002 Cr-Commit-Position: refs/heads/master@{#33183}
-