- 07 Jul, 2022 1 commit
-
-
Manos Koukoutos authored
Mostly src/codegen, src/compiler, src/snapshot, src/utils. Bug: v8:13006 Change-Id: I2fb31acc749a7376e6f2a7424ed2e67ff479d971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749178 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81575}
-
- 01 Jul, 2022 1 commit
-
-
Manos Koukoutos authored
This makes the internal V8 name consistent with the text-format name. Bug: v8:7748 Change-Id: I44f7ac1eb5e634b4f829e596bf1f14caeb748d54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726291Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81491}
-
- 30 Jun, 2022 2 commits
-
-
Jakob Kummerow authored
The previous combination of a conditional and an unconditional move produced an incorrect value when dst == rhs and lhs contained the expected result. Fixed: chromium:1338980 Change-Id: If3f722999ed9c0ffd687736280d048d232d75736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3738219 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#81475}
-
Jakob Kummerow authored
Fixed: chromium:1340488 Change-Id: Id3da10dd13256dfc15a6fef4dc412b5d30ccc8cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735126Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81455}
-
- 28 Jun, 2022 1 commit
-
-
Jakob Kummerow authored
This remodels the tier-up checks on loop back edges to avoid modifying the cache state by taking temp registers passed in from the caller, and not causing the instance to get cached. Additionally, this introduces FreezeCacheState scopes, which allow us to enforce that certain ranges don't cause any cache modifications. Conditional jumps require such a scope to be around, which should help ensure that we don't forget to add them to any future code we write. Drive-by cleanup: drop {pinned} lists from a few Load helper functions. They don't allocate registers (and shouldn't), so they don't need to know about pinned registers. Fixed: chromium:1339321 Change-Id: I1c7660418a85259e96c5e0dcfeaf12dab2114e8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3724787Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81411}
-
- 21 Jun, 2022 2 commits
-
-
Jakob Kummerow authored
This is a reland of commit 15f372af Change since revert: TSan fix for tier-up budget reset. Original change's description: > [wasm] Fix tier-up budget tracking for recursive calls > > In the previous implementation, functions overwrote any budget > decrements caused by recursive invocations of themselves, which > could cause tier-up decisions for certain unlucky functions to > get delayed unreasonably long. > This patch avoids this by working with the on-instance value > directly instead of caching it in a stack slot. That generates > the same amount of Liftoff code as the status quo, but handles > recursive functions properly. > The "barista3" benchmark's peak performance improves by almost 20%. > > Bug: v8:12281 > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81249} Bug: v8:12281,v8:12984 Change-Id: Ia6ce776848dc86617546ec514660c9a840484cb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716479Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81281}
-
Michael Achenbach authored
This reverts commit 15f372af. Reason for revert: https://crbug.com/v8/12984 Original change's description: > [wasm] Fix tier-up budget tracking for recursive calls > > In the previous implementation, functions overwrote any budget > decrements caused by recursive invocations of themselves, which > could cause tier-up decisions for certain unlucky functions to > get delayed unreasonably long. > This patch avoids this by working with the on-instance value > directly instead of caching it in a stack slot. That generates > the same amount of Liftoff code as the status quo, but handles > recursive functions properly. > The "barista3" benchmark's peak performance improves by almost 20%. > > Bug: v8:12281 > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81249} Bug: v8:12281, v8:12984 Change-Id: Ie254236785628c07ac569de16ea82a67ed5bd221 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714247 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Owners-Override: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81267}
-
- 20 Jun, 2022 2 commits
-
-
Clemens Backes authored
According to the style guide, the implicit conversion of any number of registers to a LiftoffRegList should not be there. This CL removes it, and fixes two subideal call sites to use SpillRegister (receiving a single register) instead of SpillOneRegister (receiving a register list to choose from). Plus some semantics-preserving rewrites. R=jkummerow@chromium.org Bug: chromium:1337221 Change-Id: Id22043ac1c185bc794dbde7baa4b1d5ab7cce56e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707286Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81250}
-
Jakob Kummerow authored
In the previous implementation, functions overwrote any budget decrements caused by recursive invocations of themselves, which could cause tier-up decisions for certain unlucky functions to get delayed unreasonably long. This patch avoids this by working with the on-instance value directly instead of caching it in a stack slot. That generates the same amount of Liftoff code as the status quo, but handles recursive functions properly. The "barista3" benchmark's peak performance improves by almost 20%. Bug: v8:12281 Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81249}
-
- 07 Jun, 2022 2 commits
-
-
Deepti Gandluri authored
Bug: v8:12284 Change-Id: I9d4a5d7420c6650039f84b3c8fc7974e9e617ce3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687566Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80981}
-
Dominik Inführ authored
https://crrev.com/c/3471854 already disabled the RecordWrite builtin specifically for incremental marking. Since this didn't regress performance as expected, we can now remove those versions of the builtin. This will simplify the barrier implementation a bit, but is also required for the shared heap write barrier. Unlike the generational barrier, the shared heap barrier can't be elided for map values. Bug: v8:11708 Change-Id: I44bc6ee79006a5be8c1b593dee7fc30c3b9cfa85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683341Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80966}
-
- 02 Jun, 2022 2 commits
-
-
Ilya Rezvov authored
Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/52 Bug: v8:12908 Change-Id: If8ffb82c38042191c67c9b5c23a231877d4f2159 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679848Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Ilya Rezvov <irezvov@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80924}
-
Clemens Backes authored
We should not use kSimd, which has already shipped. Instead, use a new kRelaxedSimd bailout reason. R=thibaudm@chromium.org Bug: chromium:1324081 Change-Id: I394e288014245ed9ae69e20f811f8cf7555e6149 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686413Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80913}
-
- 30 May, 2022 1 commit
-
-
Thibaud Michaud authored
R=gdeepti@chromium.org,clemensb@chromium.org Bug: v8:12284 Change-Id: Id003edadabb061aff074ad69602caf9322bda07e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667085Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80813}
-
- 24 May, 2022 1 commit
-
-
Peter Kasting authored
Math between disparate enums is deprecated. Use constexprs instead. This requires switching some caller code to work with the new non-enum constants also. Bug: chromium:1284275 Change-Id: Ifb3c8757ed62e2a0966120f830f0a7e282b53a16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3661148 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#80722}
-
- 23 May, 2022 1 commit
-
-
Deepti Gandluri authored
Also remove the SKIP statement for relaxed min/max tests Bug: v8:12284 Change-Id: Iff67fe2a1c281295f237fbb95a9a36da668f27e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3651530Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80701}
-
- 18 May, 2022 1 commit
-
-
Deepti Gandluri authored
Instruction lowering on ARM uses pmin/pmax as there is no hardware support. More details here: https://github.com/WebAssembly/relaxed-simd/issues/33 Bug: v8:12284 Change-Id: I075d4a6660afc4418fcc91c5d48e8e9096536dc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3646075 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80621}
-
- 16 May, 2022 1 commit
-
-
Deepti Gandluri authored
Bug: v8:12284 Change-Id: I75d550e0cec4a4cf68296f3634329a7d97ae99fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3646076Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80568}
-
- 13 May, 2022 1 commit
-
-
Clemens Backes authored
Now that we require C++17 support, we can just use the standard static_assert without message, instead of our STATIC_ASSERT macro. R=leszeks@chromium.org Bug: v8:12425 Change-Id: I1d4e39c310b533bcd3a4af33d027827e6c083afe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647353Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80524}
-
- 12 May, 2022 2 commits
-
-
Deepti Gandluri authored
Bug: v8:12284 Change-Id: Ica2564e8b34f8edd9492ef379cf3a3eb5575633d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642948 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80504}
-
Deepti Gandluri authored
Bug: v8:12284 Change-Id: I9d8f9da8ed736d5119e7af4354e1ddd8a255713d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3640925 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80497}
-
- 11 May, 2022 1 commit
-
-
Deepti Gandluri authored
Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/40 Bug: v8:12284 Change-Id: Id4cb3889d94cf0bb7169ea068efe5ca68cfcbad9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3636365 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80475}
-
- 06 May, 2022 1 commit
-
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: Ied63b2c7b57210f2cf2e1580520405ce1be5dc33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625979Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80400}
-
- 20 Apr, 2022 2 commits
-
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: Idddb0b7648b29612fa0308520ca2fc2a3e5647f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593218Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80055}
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: If78b5a86364b015483131ef321ca9e928e8ddfc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585338Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80047}
-
- 08 Apr, 2022 1 commit
-
-
Thibaud Michaud authored
Rename element_size_bytes() to value_kind_size(), and add the uncompressed version: value_kind_full_size(). R=clemensb@chromium.org Change-Id: I956142937fd1134ecbdaaa617c402ed8fff2cf17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568477Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#79884}
-
- 07 Apr, 2022 1 commit
-
-
Jakob Kummerow authored
This adds feedback collection to count the number of executions of call_direct instructions in Liftoff code. The purpose is better inlining decisions in Turbofan, which are enabled by having call count information for all kinds of calls. The new feature is gated on --wasm-speculative-inlining. While direct calls don't need to speculate about their target, the whole feedback collection infrastructure depends on that flag. Bug: v8:12166 Change-Id: Ie24a988fcea631f370188dc21e60a5fac923dd3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571807Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#79846}
-
- 06 Apr, 2022 1 commit
-
-
Clemens Backes authored
The 'ForRegs' method is not needed for clarity of the code, it's pretty clear what to construct a register list from. Hence turn the static {LiftoffRegList::ForRegs} method into a constructor. This makes the code more concise. Also, turn the for loop into a C++17 folding expression, which might generate better code because the loop will automatically be unrolled. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: Ic4446f23022db5f17420303d45b9c15fa5daff60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572041Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79815}
-
- 16 Mar, 2022 1 commit
-
-
Clemens Backes authored
In text, we should use the properly capitalized "Wasm" instead of "WASM". In particular for frame output, other frames typically use CamelCase (like "JsToWasmFrame", "ExitFrame", "InternalFrame"), so Wasm should do the same. The "0xa" comment in some assemblers is also outdated, the current tag we emit for StackFrame::WASM is 0x8 (0x4 shifted by one). R=jkummerow@chromium.org Bug: v8:12425 Change-Id: Ic3e00c401b219c28b5424c82efb0f1a9df51690f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525195Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79498}
-
- 14 Mar, 2022 1 commit
-
-
Leszek Swirski authored
Modernise the RegList interface to be a proper class, rather than a typedef to an integer, and add proper methods onto it rather than ad-hoc bit manipulation. In particular, this makes RegList typesafe, adding a DoubleRegList for DoubleRegisters. The Arm64 CPURegList isn't updated to use (or extend) the new RegList interface, because of its weird type-erasing semantics (it can store Registers and VRegisters). Maybe in the future we'll want to get rid of CPURegList entirely and use RegList/DoubleRegList directly. Change-Id: I3cb2a4d386cb92a4dcd2edbdd3fba9ef71f354d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516747 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79460}
-
- 24 Feb, 2022 1 commit
-
-
Clemens Backes authored
{AtomicSub} on x64 first negates the {value} register, then does an atomic addition. For that reason, {value} should be a unique register. So far, we only checked that it's not used in the value stack, but we should also check for overlap with the destination address or the offset register. Drive-by: Remove unneeded handling of non-unique register index on arm, as that cannot happen (LiftoffCompiler ensures that the result register is unique). R=thibaudm@chromium.org Bug: chromium:1296876 Change-Id: Ie6b97eec8e8dea07b0bcc644d261f47467cc5b8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3487987Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79265}
-
- 23 Feb, 2022 1 commit
-
-
Jakob Gruber authored
A collection of smallish cleanups and improvements for safepoints. Maintainability: - The class names were not very clear; move Safepoint inside SafepointTableBuilder to clarify that this wrapper class is used during codegen. - Rename DefinePointerSlot/DefineRegister to DefineTaggedStackSlot/DefineTaggedRegister for clarity. - Use named constants instead of -1. - DefineTaggedRegister has no connection to kNoDeoptIndex, remove the DCHECK and comment. - Remove the unused kNumSafepointRegisters constant + other dead code. - Small clarifications in CommonFrame::IterateCompiledFrame. - Rename has_safepoint_info to uses_safepoint_table and refactor s.t. `stack_slots` can be used when `uses_safepoint_table == false`. In this case it just returns 0. Perf: - During codegen, represent stack slots as a growable bit vector instead of a list of int indices. Extend GrowableBitVector functionality to support the above. - Track the minimum index instead of iterating all stack slots in all safepoints before encoding. Bug: v8:7700 Change-Id: If409bc42c825d47fc0074fce51e3b963fd080806 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3483659Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79233}
-
- 03 Feb, 2022 1 commit
-
-
Clemens Backes authored
On all platform, the method is implemented identical to {LoadInstanceFromFrame}. So remove {FillInstanceInto} and keep {LoadInstanceFromFrame} which is a better name. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: Ia9e6a3e2478628f8d31ff4faaab8d5250fda7796 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3429203Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78924}
-
- 01 Feb, 2022 1 commit
-
-
Clemens Backes authored
The 32-bit value is zero-extended to pointer size, which is a no-op on 32-bit systems. The operation changes nothing about the signedness of the value, so the old name was a bit misleading. We also provide one unified no-op implementation for all 32-bit systems. R=thibaudm@chromium.org Bug: v8:10949, chromium:1281995 Change-Id: Id04641fe793155ea98bf878b6789e4afce3da7df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3424493Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78881}
-
- 31 Jan, 2022 1 commit
-
-
Manos Koukoutos authored
Since inheritance depth of every type is known in the isorecursive hybrid type system, rtts with depth are removed. This enables simplification of type checks in Liftoff and Turbofan, as well as decoding of object allocation instructions. Bug: v8:7748 Change-Id: I6b52579b584191d92644de1c6e805d9f054641d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3422626Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78860}
-
- 07 Jan, 2022 1 commit
-
-
Clemens Backes authored
The bailout is there explicitly in the code, so we should allow it in {CheckBailoutAllowed}. R=ahaas@chromium.org Bug: v8:12527 Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78515}
-
- 17 Nov, 2021 1 commit
-
-
Ng Zhi An authored
NONE clashes with the PropertyAttributes::NONE, which is defined in v8::internal namespace. PropertyAttributes have too many call sites and depend on using the enums as masks, making it hard to convert to an enum class. So we are changing the name instead. Bug: v8:12244 Change-Id: Iec0be12c626549cca137aceeaee0e30fafab8b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3284003 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77956}
-
- 29 Oct, 2021 1 commit
-
-
Jakob Kummerow authored
Temporarily behind a new flag: --new-wasm-dynamic-tiering The plan is to merge this into the existing --wasm-dynamic-tiering flag once it's been confirmed to be generally beneficial. Bug: v8:12281 Change-Id: I191d03170f8d5360073a45fea170f432074f7534 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247632Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77620}
-
- 07 Oct, 2021 1 commit
-
-
Jakob Kummerow authored
So far the slot is set to 0; in an upcoming CL it will be used for an actual feedback vector. Bug: v8:7748 Change-Id: I79f7502757d2cd8b07ced7105bf7532f5bc9b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205898 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77279}
-
- 31 Aug, 2021 1 commit
-
-
Martyn Capewell authored
Instrument floating-point operations to set a flag if the result is NaN. Port: e699762e Bug: v8:11856 Change-Id: Iae8121dd17ae8acf402ac74e41122cad77387db7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099945Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/main@{#76605}
-