- 09 Jan, 2018 5 commits
-
-
Clemens Hammacher authored
Store protected instruction info needed for the wasm trap handler. This code will be used and covered by existing tests once we add support for if-constructs to Liftoff. R=titzer@chromium.org CC=eholk@chromium.org Bug: v8:6600, v8:5277 Change-Id: I508b0ab8572ef8b5c7943564714fcec7e9eb8e3b Reviewed-on: https://chromium-review.googlesource.com/853497 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50425}
-
Hannes Payer authored
Bug: chromium:796896 Change-Id: I7f46f82d079502b8ec04c5e3be5f803ec9e62ffa Reviewed-on: https://chromium-review.googlesource.com/854797 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50424}
-
Choongwoo Han authored
If there is no constructor or species updates on Array or TypedArrays, then skip lookups of constructor and species so that we can create a new typed array quickly. This path makes TA.p.slice() 4x faster in fast cases. Bug: v8:7161 Change-Id: Ib8d2a3f6b8b5ed356c5822a814164166d1285f64 Reviewed-on: https://chromium-review.googlesource.com/828343 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50423}
-
Clemens Hammacher authored
This seems to be a merge error. The if moved down by a few lines and now actually implements the bounds check instead of bailing out. Taking it out revealed a bug where we were trying to access the lowest 8 bits on a register where this is not allowed on ia32, thus a few more changes were needed in this CL. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ib1ef131a12df050302ae50115493a1fcd8323fe5 Reviewed-on: https://chromium-review.googlesource.com/852734Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50422}
-
Jaroslav Sevcik authored
Bug: chromium:798964 Change-Id: I48d6662d60765f04004b324f67ed3aadf11ee07b Reviewed-on: https://chromium-review.googlesource.com/854132Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50421}
-
- 08 Jan, 2018 26 commits
-
-
Alexey Kozyatinskiy authored
We can call less getters on node objects. R=dgozman@chromium.org Bug: chromium:799791 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iecfe76c2be6b6bed675013ac4aaa117b714d4ba5 Reviewed-on: https://chromium-review.googlesource.com/854623Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50420}
-
Junliang Yan authored
Port fba4cdf1 Original Commit Message: This patch breaks out bailout reasons into two enum classes. This helps save 3 bits on the SharedFunctionInfo as we don't have to track the abort reasons. R=gsathya@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib2b2ce10b2f1ef6380193964aa9d868168fe129a Reviewed-on: https://chromium-review.googlesource.com/855016Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#50419}
-
Eric Holk authored
This is a reland of 9c79b37a Original change's description: > [wasm] use allocation tracker to track reserved address space > > This is a step towards falling back on bounds checks when there are too many > guarded Wasm memories. > > Bug: v8:7143 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I01916cbdd5ddb08fe1d946ab83b801f37a8fe1c6 > Reviewed-on: https://chromium-review.googlesource.com/832944 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50390} Bug: v8:7143 Change-Id: Iaf0d22d300a3f2da22649552a17162dcf7bc608b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/853142Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50418}
-
Sathya Gunasekaran authored
This is just a rebased version of https://chromium-review.googlesource.com/c/v8/v8/+/571453 with no functional changes Bug: v8:6889 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia082cc09ca527505b288ac88e68e0b74eae94765 Reviewed-on: https://chromium-review.googlesource.com/849423Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50417}
-
Yang Guo authored
This causes issues when running tools/node/fetch_deps.py on systems without gyp as pre-installed python module. And we do not even need to do this for building for node (with GN). R=machenbach@chromium.org Bug: v8:6105 Change-Id: If0089dedf176bb509b9fd000e5fe829f8a32bac6 Reviewed-on: https://chromium-review.googlesource.com/852458Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50416}
-
Clemens Hammacher authored
This fixes two issues with --trace-wasm-decoder and --trace-liftoff. First, cache state tracing in liftoff only makes sense together with --trace-wasm-decoder, so disable it otherwise. Second, we were sometimes hitting a DCHECK with --trace-wasm-decoder on functions which bailed out to Turbofan, since the bailout was resetting the end pointer of the decoder to the current pc. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ib4e052a1cdec6389b12b4a0ea57f07c031324ed5 Reviewed-on: https://chromium-review.googlesource.com/853493 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Choongwoo Han authored
GetProperty CSA implementation bailouts prototype lookup when the holder is a typed array, which is to handle integer indexed exotic cases. However, this strict condition made too much overheads for search of common names such as "constructor". This CL checks the first character of a name, and do not bailout if we are sure that the name cannot be a special index. Bug: v8:4911, v8:7161 Change-Id: I2229ff3bebe14a452718e0b1f8354bb05437c09c Reviewed-on: https://chromium-review.googlesource.com/842963Reviewed-by:
-
Clemens Hammacher authored
In order to remove the CALL_GENERATED_CODE macro, it helps a lot to unify the interfaces of the simulators and make the Call method variadic in the number of arguments. This CL does that for each simulator. A follow-up CL will then completely remove the CALL_GENERATED_CODE macro and replace uses with the (new) GeneratedCode wrapper. R=mstarzinger@chromium.org Bug: v8:7182 Change-Id: I1f81445ec2faba30f0bd233b022ae1f0fae4e96f Reviewed-on: https://chromium-review.googlesource.com/850873 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Add a counter to measure the pure liftoff compile time. With background compilation, the reported result will roughly match the cpu time, not wall-clock time. R=titzer@chromium.org Bug: v8:6600 Change-Id: I9c76673a4cbe833de5b41a23d09892f577401374 Reviewed-on: https://chromium-review.googlesource.com/853859Reviewed-by:
-
Clemens Hammacher authored
And apply a minor change: the {end_offset} is currently always >= 1, and we sometimes use {end_offset - 1}. Change this to compute the {end_offset} to be one less than before, and use {Uint32LessThan} instead of {Uint32LessThanOrEqual}. This matches the documentation I added and makes reasoning about the correctness of the checks easier (at least for me). R=titzer@chromium.org Change-Id: I9a18ad5c72895cbadb6593cb74d6edc24f9ab032 Reviewed-on: https://chromium-review.googlesource.com/852145 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Ivica Bogosavljevic authored
TEST=cctest/test-code-generator/FuzzAssembleMoveAndSwap Bug: Change-Id: I36d0b7df56f3c895a7fd4017e5e9a7cfd0053b2a Reviewed-on: https://chromium-review.googlesource.com/850399Reviewed-by:
Miran Karić <miran.karic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#50410}
-
Clemens Hammacher authored
For simplicity, we currently use the approach to do all computations and bounds checks on 32 bit values, and only convert to pointer size right before using the value as memory offset. Unfortunately, there are still cases left where we use 32-bit values for 64-bit operations, which can lead to subtle bugs. This CL hopefully fixes the last of these bugs. R=titzer@chromium.org Bug: v8:7257 Change-Id: I8d340f83ad17925c0d18d4e788350ef6101786ea Reviewed-on: https://chromium-review.googlesource.com/852299 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Change-Id: I668a4ac9ce80daa1952b05fdee754db190f3fb3c Reviewed-on: https://chromium-review.googlesource.com/853866Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50408}
-
Clemens Hammacher authored
This prints nicer error messages for checks like "DCHECK_EQ(reg1, reg2)", and also splits cache state tracing into one method for printing the overall state, one for printing each slot, and one for printing the register. R=titzer@chromium.org Bug: v8:6600 Change-Id: I36e83ba2542986dd8ad17dbfe7cbb8df54a56755 Reviewed-on: https://chromium-review.googlesource.com/853495 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michal Majewski authored
Added simple system tests for different progress indicators. Bug: v8:6917 Change-Id: I906ddfd06e82cc19d3b2210e09457456be00309b Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/852495 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I53b9de78d6070d04b7535c828fd72225fd93afde Reviewed-on: https://chromium-review.googlesource.com/829375Reviewed-by:
-
Clemens Hammacher authored
When generating code, store the vector of protected instruction data as unique_ptr. It only becomes a shared_ptr once ownership has been transferred to the NativeModule, because it can be shared between different instances of the same function. Drive-by: Remove dead accessor in PipelineData. R=ahaas@chromium.org Change-Id: I7571b32bf89f3c816683c5a77ac08fe8c22eb968 Reviewed-on: https://chromium-review.googlesource.com/853496Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50404}
-
Clemens Hammacher authored
This is needed to ensure that code can be interrupted. It will be covered by a test once we support if-constructs in Liftoff. Drive-by: Separate handling of blocks and loops, as there is only one line in common. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Ic22ca5e65c8d03a5d504289ec2a9e30cb97dc220 Reviewed-on: https://chromium-review.googlesource.com/853858 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The tests generated by --wasm-fuzzer-gen-test did not encode the locals of functions yet. This CL fixes that. A bit of care has to be taken to ensure that the locals are generated in exactly the same order as in the module generated by the fuzzer. This requires calling {addLocals} several times. R=ahaas@chromium.org Change-Id: I95237b0baef0731b6c164fddc8f12fa6f478e220 Reviewed-on: https://chromium-review.googlesource.com/848832 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This ensure that once features are added for other platform, we don't forget to implement all platform specific methods that are then being used. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I4cc948da280fdb63da1938edc6b391d180b88cad Reviewed-on: https://chromium-review.googlesource.com/853494 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Test case generation produced unusable output if the module contains more than one function. Also, it was unnecessarily scattered around several places in the code. This CL consolidates test case generation in one method in the fuzzer, and supports multiple functions with different signatures. R=ahaas@chromium.org Change-Id: I8bea71b0d69bb69d8bbe50002c6c7616a0a1941b Reviewed-on: https://chromium-review.googlesource.com/847515 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michal Majewski authored
Test processors can be enabled with --infra-staging flag. Rerunning tests, execution and verbose progress indicator already work as test processors. Bug: v8:6917 Change-Id: I40fc42db94dbc8629e8000a3d363030045532fe3 Reviewed-on: https://chromium-review.googlesource.com/850398 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Mythri authored
Bug: chromium:783124 Change-Id: Ie420be3ad05583d8ad999ab1e13e89ada4774028 Reviewed-on: https://chromium-review.googlesource.com/850674Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Also, remove {FunctionBodyForTesting}, which is only being used once. Use the constructor directly instead. R=ahaas@chromium.org Change-Id: Ieceac41bf62ec2accf1bb39d8334563557c0dbbd Reviewed-on: https://chromium-review.googlesource.com/847514 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
R=ahaas@chromium.org Change-Id: Id21608780e345448398ad4066ad307bef7358801 Reviewed-on: https://chromium-review.googlesource.com/849832Reviewed-by:
-
Georg Neis authored
Bug: v8:7217 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I97b067254355eb91e12b92eba92631cbc3ce8000 Reviewed-on: https://chromium-review.googlesource.com/839280 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
- 07 Jan, 2018 1 commit
-
-
Timothy Gu authored
Bug: v8:7245 Change-Id: Ia8931037021b935e776230a6a50c580ad82efba8 Reviewed-on: https://chromium-review.googlesource.com/844065 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50394}
-
- 06 Jan, 2018 3 commits
-
-
Adam Klein authored
As noted in the attached bug, accurately counting this would require significant changes to the parser and is thus infeasible. Bug: v8:7211 Change-Id: I61f14c948f50e0f97e596a9696d72a3570ad588a Reviewed-on: https://chromium-review.googlesource.com/853214Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50393}
-
Bill Budge authored
This reverts commit 9c79b37a. Reason for revert: breaks TSAN https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux64_TSAN%2F18959%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2Finstance-gc%2F0 Original change's description: > [wasm] use allocation tracker to track reserved address space > > This is a step towards falling back on bounds checks when there are too many > guarded Wasm memories. > > Bug: v8:7143 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I01916cbdd5ddb08fe1d946ab83b801f37a8fe1c6 > Reviewed-on: https://chromium-review.googlesource.com/832944 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50390} TBR=bbudge@chromium.org,gdeepti@chromium.org,eholk@chromium.org,eholk@google.com Change-Id: I207b9466377ba50be17794e71407b0ebc8eb88e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7143 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/853140Reviewed-by:
-
Adam Klein authored
These tests are gone from upstream. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie69be268d493a52e0d64b7bb216f3135dd111188 Reviewed-on: https://chromium-review.googlesource.com/853195Reviewed-by:
-
- 05 Jan, 2018 5 commits
-
-
Eric Holk authored
This is a step towards falling back on bounds checks when there are too many guarded Wasm memories. Bug: v8:7143 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I01916cbdd5ddb08fe1d946ab83b801f37a8fe1c6 Reviewed-on: https://chromium-review.googlesource.com/832944 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Yang Guo authored
Turns out gclient calls download_from_google_storage, which needs to be included in PATH. TBR=machenbach@chromium.org Bug: v8:6105 Change-Id: I15d44d67152f6fa0d20ae7bc7e44bc5e0393b519 Reviewed-on: https://chromium-review.googlesource.com/852616Reviewed-by:
-
Karl Schimpf authored
Fixes nits found by @clemensh after CL https://chromium-review.googlesource.com/c/v8/v8/+/834670 was committed. That is, the code uses static asserts instead of assert. Bug: v8:7226 Change-Id: I5488ec4609d1bee3aafa61a3ff2505f71b06d80d Reviewed-on: https://chromium-review.googlesource.com/847687Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: Ieb7b04f47bbad575c22a3a16ec7bd7cb9e8ba0c9 Reviewed-on: https://chromium-review.googlesource.com/851425Reviewed-by:
-
Michael Achenbach authored
This reverts commit 86bc1517. Reason for revert: breaks gcc bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/17209 Original change's description: > [wasm] remove kExecuteSimdLowered mode from wasm cctest > > R=clemensh@chromium.org,titzer@chromium.org,bbudge@chromium.org,gdeepti@chromium.org > BUG=v8:7028 > > Change-Id: Ie0b984ebd18e267cdaf7aaff9f17fb4328d8e5fa > Reviewed-on: https://chromium-review.googlesource.com/849638 > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50385} TBR=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I890b8810ea802fe2b9273def07c9056d4b904a4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7028 Reviewed-on: https://chromium-review.googlesource.com/852712Reviewed-by:
-
