• Clemens Hammacher's avatar
    [wasm] Add some documentation for bounds checks · 30aa7b07
    Clemens Hammacher authored
    And apply a minor change: the {end_offset} is currently always >= 1, and
    we sometimes use {end_offset - 1}. Change this to compute the
    {end_offset} to be one less than before, and use {Uint32LessThan}
    instead of {Uint32LessThanOrEqual}.
    This matches the documentation I added and makes reasoning about the
    correctness of the checks easier (at least for me).
    
    R=titzer@chromium.org
    
    Change-Id: I9a18ad5c72895cbadb6593cb74d6edc24f9ab032
    Reviewed-on: https://chromium-review.googlesource.com/852145
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50411}
    30aa7b07
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...