1. 08 Feb, 2018 1 commit
  2. 22 Jan, 2018 1 commit
  3. 16 Jan, 2018 1 commit
  4. 11 Jan, 2018 1 commit
  5. 10 Jan, 2018 2 commits
  6. 07 Jan, 2018 1 commit
  7. 04 Jan, 2018 1 commit
  8. 21 Dec, 2017 1 commit
  9. 19 Dec, 2017 1 commit
  10. 10 Dec, 2017 1 commit
  11. 24 Nov, 2017 1 commit
  12. 20 Nov, 2017 1 commit
  13. 18 Nov, 2017 1 commit
    • Anna Henningsen's avatar
      [api] Make running scripts in AddMessageListener callback work in debug mode · 09b53eef
      Anna Henningsen authored
      The existance of an `AllowJavascriptExecutionDebugOnly` scope in
      `Isolate::ReportPendingMessages()` indicates that the API supports
      running arbitrary JS code in a `AddMessageListener` callback.
      
      Currently, this can fail in debug mode: The
      `!isolate->external_caught_exception()` condition is checked when
      entering API methods inside such a handler. However, if there is
      a verbose `TryCatch` active when the exception occurs, this
      check fails, and when calling `ToString()` on the exception object
      leaves a pending exception itself, the flag is re-set to `true`.
      
      Fix this problem by clearing the flag and the pending exception if
      there was one during `ToString()`. This matches the code a few lines
      up in `messages.cc`, so the exception state is now consistent
      during the callback.
      
      This currently makes a Node.js test fail in debug mode
      (`parallel/test-error-reporting`).
      
      Bug: node:7144
      Bug: node:17016
      Change-Id: I060d00fea3e9a497f4df34c6ff8d6e29ebe96321
      Reviewed-on: https://chromium-review.googlesource.com/718096
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49466}
      09b53eef
  14. 17 Nov, 2017 1 commit
    • Jakob Gruber's avatar
      Revert "[coverage] add coverage for binary expressions" · 9037639e
      Jakob Gruber authored
      This reverts commit 4d3bc552.
      
      Reason for revert: https://crbug.com/785778
      
      Original change's description:
      > [coverage] add coverage for binary expressions
      > 
      > Adds block-level coverage tracking for binary && and ||
      > expressions. Introduces a BinaryOperation source-range
      > for tracking the operations themselves and an Expression
      > source-range, used for tracking NaryLogical expressions.
      > 
      > This builds on work by jgruber@chromium.org in
      > the issue.
      > 
      > TBR=marja@chromium.org
      > R=​jgruber@chromium.org, rmcilroy@chromium.org
      > 
      > Bug: v8:6660
      > Change-Id: I83a81f13a3514a734c06948b2d3e91138fb00e18
      > Reviewed-on: https://chromium-review.googlesource.com/754564
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49304}
      
      TBR=rmcilroy@chromium.org,marja@chromium.org,jgruber@chromium.org,ben@npmjs.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:6660
      Change-Id: Ie017c528604b2e01400f527511413eaea5786198
      Reviewed-on: https://chromium-review.googlesource.com/776768Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49454}
      9037639e
  15. 10 Nov, 2017 1 commit
  16. 07 Nov, 2017 1 commit
  17. 20 Oct, 2017 2 commits
  18. 13 Oct, 2017 1 commit
  19. 04 Oct, 2017 1 commit
  20. 28 Sep, 2017 1 commit
  21. 28 Aug, 2017 1 commit
  22. 23 Aug, 2017 1 commit
  23. 31 Jul, 2017 1 commit
  24. 30 Jun, 2017 1 commit
    • Jaime Bernardo's avatar
      [build] Set MSVS .obj folders in gyp for v8_base · 3bef2af6
      Jaime Bernardo authored
      Building on Windows with gyp fails depending on the result from
      sharding the src/v8.gyp:v8_base target. If two source files with the
      same name are in the same shard, their output object file path would
      conflict with one another. One example of this conflict is v8_base's
      runtime/runtime.cc and the V8 inspector's protocol/Runtime.cpp that
      is generated at build time, for which the files runtime.obj and
      Runtime.obj would be created, but MSVS overwrites one of them with
      the other.
      
      Dividing the .obj output path by the original source's extension
      prevents this overwrite.
      
      Refs: https://github.com/nodejs/node/pull/13959
      Bug: 
      Change-Id: I158e6178f2511297899ee50ea159f574916f903f
      Reviewed-on: https://chromium-review.googlesource.com/556599Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46354}
      3bef2af6
  25. 21 Jun, 2017 1 commit
  26. 09 Jun, 2017 1 commit
  27. 27 Feb, 2017 1 commit
  28. 11 Feb, 2017 1 commit
  29. 27 Dec, 2016 1 commit
  30. 08 Dec, 2016 1 commit
  31. 27 Oct, 2016 1 commit
  32. 26 Oct, 2016 1 commit
  33. 17 Oct, 2016 1 commit
  34. 01 Sep, 2016 1 commit
  35. 31 Aug, 2016 2 commits
  36. 16 Aug, 2016 1 commit
  37. 14 Jul, 2016 1 commit