1. 24 Jul, 2020 1 commit
    • Benedikt Meurer's avatar
      [inspector] Add internal property to identify detached ArrayBuffers. · b886e153
      Benedikt Meurer authored
      This adds an internal property [[IsDetached]] to the inspector preview
      of ArrayBuffer instances, which indicates whether the ArrayBuffer was
      detached (i.e. transfered via `postMessage`). Previously it was rather
      impossible to tell whether an ArrayBuffer was detached, you had to know
      that V8 violates the ECMAScript specification and simply sets the
      byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it
      was still impossible to tell whether that ArrayBuffer wasn't simply an
      empty one from the get go).
      
      Before: https://imgur.com/UcOF83c
      After: https://imgur.com/WjmTehZ
      
      Fixed: chromium:1109102
      Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69034}
      b886e153
  2. 01 Mar, 2019 1 commit
  3. 06 Dec, 2018 1 commit
    • Dmitry Gozman's avatar
      Revert "inspector: return [[StableObjectId]] as internal property" · 4401ac44
      Dmitry Gozman authored
      This reverts commit d9fbfeb8.
      
      Reason for revert: see bug.
      Bug: 906847
      
      Original change's description:
      > inspector: return [[StableObjectId]] as internal property
      > 
      > This property might be useful for fast '===' check.
      > 
      > R=​dgozman@chromium.org,yangguo@chromium.org
      > 
      > Bug: none
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
      > Reviewed-on: https://chromium-review.googlesource.com/1226411
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56095}
      
      TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: none
      Change-Id: I68c700b7b8fd0a015f099460c15665d74e4da183
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/1363558Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58077}
      4401ac44
  4. 20 Sep, 2018 1 commit
  5. 23 Jan, 2018 1 commit
  6. 28 Dec, 2017 1 commit
    • Eugene Ostroukhov's avatar
      [inspector] provide ArrayBuffer previews · 86abfd35
      Eugene Ostroukhov authored
      Add an easy way to preview ArrayBuffer as a typed array. This change
      will always allow previewing ArrayBuffer instances as Uint8Array and
      Int8Array. ArrayBuffer instances that have even length will allow
      Int16Array preview and ArrayBuffers that have length divisible by 4 will
      allow Int32Array previews.
      
      Bug: 
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I07440147cc9e83c8a987f9316bd8d1b936db2717
      Reviewed-on: https://chromium-review.googlesource.com/842472
      Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
      Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50315}
      86abfd35
  7. 24 Mar, 2017 1 commit
  8. 03 Mar, 2017 1 commit
  9. 02 Oct, 2016 1 commit
  10. 30 Sep, 2016 2 commits