1. 27 Jul, 2020 2 commits
  2. 24 Jul, 2020 1 commit
    • Benedikt Meurer's avatar
      [inspector] Add internal property to identify detached ArrayBuffers. · b886e153
      Benedikt Meurer authored
      This adds an internal property [[IsDetached]] to the inspector preview
      of ArrayBuffer instances, which indicates whether the ArrayBuffer was
      detached (i.e. transfered via `postMessage`). Previously it was rather
      impossible to tell whether an ArrayBuffer was detached, you had to know
      that V8 violates the ECMAScript specification and simply sets the
      byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it
      was still impossible to tell whether that ArrayBuffer wasn't simply an
      empty one from the get go).
      
      Before: https://imgur.com/UcOF83c
      After: https://imgur.com/WjmTehZ
      
      Fixed: chromium:1109102
      Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69034}
      b886e153
  3. 21 Jul, 2020 2 commits
  4. 20 Jul, 2020 1 commit
  5. 17 Jul, 2020 1 commit
  6. 07 Jul, 2020 1 commit
  7. 02 Jul, 2020 1 commit
  8. 19 Jun, 2020 1 commit
  9. 17 Jun, 2020 1 commit
  10. 16 Jun, 2020 1 commit
  11. 15 Jun, 2020 1 commit
  12. 10 Jun, 2020 1 commit
  13. 09 Jun, 2020 1 commit
  14. 06 Jun, 2020 1 commit
  15. 03 Jun, 2020 1 commit
  16. 27 May, 2020 1 commit
    • Benedikt Meurer's avatar
      [inspector] Report length and endColumn correctly for Wasm. · 03ba73e4
      Benedikt Meurer authored
      Previously both the length and the endColumn for Wasm scripts were
      reported as 0, and that was sort of okayish, since the front-end
      was ignoring both of these fields in case of Wasm, and was applying
      special cases. But these special casing lead to some subtle bugs,
      and this is the first step towards a more uniform treatment.
      
      Source positions for Wasm are in terms of the bytecode, and the
      column field contains the bytecode offset here, while the line
      number field is always 0. Hence we send 0 for both startLine and
      endLine as before, but endColumn now corresponds to the bytecode
      size.
      
      Bug: chromium:1056632
      Change-Id: Ia8a9cfe454ed250b87a524f5cbcbbbe242205db6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215817
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67997}
      03ba73e4
  17. 26 May, 2020 1 commit
  18. 19 May, 2020 1 commit
  19. 15 May, 2020 1 commit
  20. 07 May, 2020 1 commit
  21. 05 May, 2020 2 commits
  22. 29 Apr, 2020 1 commit
  23. 24 Apr, 2020 1 commit
  24. 15 Apr, 2020 1 commit
  25. 14 Apr, 2020 1 commit
  26. 09 Apr, 2020 1 commit
  27. 08 Apr, 2020 1 commit
    • Clemens Backes's avatar
      Reland "[wasm] Debug in Liftoff by default" · 904a3e78
      Clemens Backes authored
      This is a reland of 44826509.
      TSan issue were fixed in https://crrev.com/c/2139574. One test
      failing in the 'stress' variant is skipped for now, until we figure
      out what the intended behaviour actually is.
      
      Original change's description:
      > [wasm] Debug in Liftoff by default
      >
      > This flips the --debug-in-liftoff flag to be on by default.
      > There are still some outstanding issues with that configuration, but not
      > more than with the interpreter configuration. Thus flip now, such that
      > we can fully focus on stabilizing that config.
      >
      > R=ecmziegler@chromium.org
      >
      > Bug: v8:10351
      > Change-Id: I7681f40aa2516557ef3ab4efd9a2c1f88e3b4df7
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135727
      > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org>
      > Commit-Queue: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67018}
      
      Bug: v8:10351, v8:10403
      Change-Id: I4c2f1af46233546d6ebeb638c7ef10aac56cd92d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139575
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarEmanuel Ziegler <ecmziegler@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67049}
      904a3e78
  28. 07 Apr, 2020 1 commit
  29. 06 Apr, 2020 6 commits
  30. 03 Apr, 2020 2 commits
  31. 30 Mar, 2020 1 commit