- 03 Aug, 2018 3 commits
-
-
Clemens Hammacher authored
Move them to builtins-utils-inl.h instead. R=titzer@chromium.org Bug: v8:8015, v8:7965 Change-Id: I692e5871e320896923bed5cc6a2efc609c793446 Reviewed-on: https://chromium-review.googlesource.com/1160845 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54899}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I62027d97c40276b5dfa9579fc4e903ee21a55b54 Reviewed-on: https://chromium-review.googlesource.com/1160539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54894}
-
Clemens Hammacher authored
arguments.h used methods only defined in objects-inl.h and handles-inl.h. These uses are now moved to arguments-inl.h. Since builtins-utils.h used these methods, it also needs to be split to have an inl header now. R=titzer@chromium.org Bug: v8:7754, v8:7965 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I21db7a86f7c15776eccf060f81f2bde000b92a40 Reviewed-on: https://chromium-review.googlesource.com/1160647Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54889}
-
- 02 Aug, 2018 3 commits
-
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I810f362f57a690f890d962a88f80df14c7de65db Reviewed-on: https://chromium-review.googlesource.com/1160226Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54861}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: Ie7eb8243186238e71e8c51d133d2c334f946727f Reviewed-on: https://chromium-review.googlesource.com/1160223Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54860}
-
Clemens Hammacher authored
The generate-header-include-checks.py script generates the cc files to check that headers can be included in isolation. It currently always writes to all the cc files. This means that after "gclient runhooks", all these files have to be recompiled. This CL fixes this by not touching the file if it already contains the expected content. This avoids hundreds of recompilations after running the hook. R=machenbach@chromium.org Bug: v8:7965 Change-Id: I93a0abb936863f6c21ed22ba1b7d900b96725fa3 Reviewed-on: https://chromium-review.googlesource.com/1156514 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54858}
-
- 01 Aug, 2018 2 commits
-
-
Sergiy Byelozyorov authored
All status messages will be printed into STDERR and only the results will continue to be written to STDOUT as documentation suggests. Additionally the following changes are made: - on Buildbot each log entry will have a timestamp to make it easy to measure time between status messages printed by test runner, users will continue to see just the message itself - when devil (or any other module) logs error, they will not be interleaved with our own output since logging module is thread-safe - critical logs replaced with warning since they do not immediately stop the test runner - logging.exception is used for all exceptions to get formatted stack trace TBR=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I197fcc3bc5890130ce8b35c3e21237f9614fc468 Reviewed-on: https://chromium-review.googlesource.com/1159361 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54851}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I9389bc60eab8283d9b70a49a9a71c6d092146de0 Reviewed-on: https://chromium-review.googlesource.com/1158071Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54836}
-
- 31 Jul, 2018 2 commits
-
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I5cb76b4e989fbe6d4d08bafb60dbbb26c3d58e2d Reviewed-on: https://chromium-review.googlesource.com/1156515Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54820}
-
Ben L. Titzer authored
As discussed offline, this header is not really useful without its inline definitions. So instead of trying to split it (unnaturally), declare defeat and make it an inline header file. Also remove two unnecessary uses of it, move the JSON stringifier class into its .cc file (because it needs IncrementalStringBuilder inline) and forward declare in prettyprinter.h. R=petermarshall@chromium.org, mstarzinger@chromium.org BUG=v8:7965 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ba032ca718a195e156ec3e59f8e858a25423450 Reviewed-on: https://chromium-review.googlesource.com/1156401Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54818}
-
- 30 Jul, 2018 6 commits
-
-
Michael Lippautz authored
Tbr: cbruni@chromium.org No-try: true Change-Id: Ica8c64e0956d4ca362646814e675104f94e77fac Reviewed-on: https://chromium-review.googlesource.com/1155585Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54791}
-
Michael Lippautz authored
The following are ready for iwyu: - src/heap/mark-compact.h - src/heap/objects-visiting.h Bug: v8:7490 Change-Id: I4cb9b1146586adcef8c0e0cf187ca363fe6e9a8d Reviewed-on: https://chromium-review.googlesource.com/1154970Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54788}
-
Peter Marshall authored
Fixes: src/parsing/parse-info.h src/parsing/preparsed-scope-data.h src/profiler/heap-profiler.h src/profiler/heap-snapshot-generator.h src/profiler/heap-snapshot-generator-inl.h' src/property.h src/prototype.h src/prototype-inl.h Bug: v8:7754,v8:7490,v8:7965 Change-Id: Iba14292cdfbbaf29d5b989c16d579a1ee0edcc25 Reviewed-on: https://chromium-review.googlesource.com/1154967 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54787}
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: Id6e50a201732b4ca1fd1f69f8c43298e216ce95b Reviewed-on: https://chromium-review.googlesource.com/1154788Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54785}
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: I6bed10a6389d83b1941ba894f06b2d9540e84139 Reviewed-on: https://chromium-review.googlesource.com/1152733Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54781}
-
Peter Marshall authored
Fixes: src/map-updater.h src/objects/property-descriptor-object.h src/objects/prototype-info-inl.h src/objects/regexp-match-info.h src/objects/shared-function-info-inl.h Bug: v8:7754,v8:7490,v8:7965 Change-Id: I7ae9dc86491c8e147d628f5fd8362534e861b15e Reviewed-on: https://chromium-review.googlesource.com/1154221Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54780}
-
- 28 Jul, 2018 7 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838266 Change-Id: I898579f780e40ee0fb5fd1948a92a6c500242dfd Reviewed-on: https://chromium-review.googlesource.com/1154219Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54771}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838266 Change-Id: I0c288eeaf28569d671220ab320aaec677825bb37 Reviewed-on: https://chromium-review.googlesource.com/1154218Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54770}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: Icd00b7b4b86e1cc2de0234c69632eb5e6a63b11a Reviewed-on: https://chromium-review.googlesource.com/1154216Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54769}
-
Matheus Marchini authored
The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see https://github.com/nodejs/llnode/issues/211). R=bmeurer@google.com, yangguo@google.com Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54768}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: Ic7c6093331f1bd35fffbfc98cd3f1d0ed3571eb4 Reviewed-on: https://chromium-review.googlesource.com/1154212 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54767}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: I63c96969382fff550a64f80d35a7576d84092a0a Reviewed-on: https://chromium-review.googlesource.com/1154211 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54766}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838864 Change-Id: Ie0e6e1742344bfd69ec109f55fcccbaca0d66d66 Reviewed-on: https://chromium-review.googlesource.com/1154209 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54764}
-
- 27 Jul, 2018 3 commits
-
-
Sergiy Byelozyorov authored
This reverts commit ba023371. Reason for revert: decided to use CIPD package instead, see reasoning here: http://shortn/_MgZHcjC60Q. Original change's description: > [tools] Add an option to checkout v8-perf repo before running perf tests > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:838864 > Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883 > Reviewed-on: https://chromium-review.googlesource.com/1151295 > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54723} TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Try: true No-Tree-Checks: true Bug: chromium:838864 Change-Id: I65a5b075c6fede61b59528ba92f6803011f187c7 Reviewed-on: https://chromium-review.googlesource.com/1153687 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54759}
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: I72444df6f75bc61c467c2df51f87581ef44fe09e Reviewed-on: https://chromium-review.googlesource.com/1151632 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54751}
-
Peter Marshall authored
Fixes: src/objects/intl-objects-inl.h src/objects/js-collection.h src/objects/js-collection-inl.h src/objects/js-regexp-string-iterator-inl.h src/objects/microtask-inl.h src/objects/module-inl.h src/objects/ordered-hash-table-inl.h src/objects/promise-inl.h Bug: v8:7754,v8:7490 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a5017713fa9920add2b38dbc56ab74abd4addd Reviewed-on: https://chromium-review.googlesource.com/1152732Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54748}
-
- 26 Jul, 2018 2 commits
-
-
Peter Marshall authored
Fixes: src/objects/arguments.h src/objects/arguments-inl.h src/objects/compilation-cache-inl.h src/objects/data-handler-inl.h src/objects/hash-table-inl.h Bug: v8:7754,v8:7490 Change-Id: Ic17d4c3477c7d2003b325497cb9082899a0bf3fc Reviewed-on: https://chromium-review.googlesource.com/1151312Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#54736}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883 Reviewed-on: https://chromium-review.googlesource.com/1151295 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54723}
-
- 25 Jul, 2018 6 commits
-
-
Jakob Kummerow authored
The test driver compares command-line arguments against test names it finds on disk. Using Python's "fnmatch" for this nicely handles wildcards, but is relatively slow. For given test names that don't contain any '*', we can use string equality testing, which is much faster. Example: the time to evaluate tools/run-tests.py --arch x64 --mode release \ $(grep 'object-spread' -l -r test/test262/data/test/ | \ sed -E 's|\.js$||' | \ sed -E 's|^test/test262/data/test/|test262/|') goes from "I gave up and killed the process after several minutes" to a couple of seconds with this patch. Change-Id: I9ec404b7516afd801fe6126347f6dff533d1977c Reviewed-on: https://chromium-review.googlesource.com/1149196 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54704}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Change-Id: I2d8d07f048204874995dd4d349b6fb2b5b226630 Reviewed-on: https://chromium-review.googlesource.com/1150158Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54695}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: Ifbdd9fe986e84197fd1ff6441c1565fed44c2c6f Reviewed-on: https://chromium-review.googlesource.com/1149869 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54689}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7965 Change-Id: I1bdd5b3bc8626727c94b95b519a8896384ff990b Reviewed-on: https://chromium-review.googlesource.com/1148573 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54684}
-
Peter Marshall authored
Change-Id: I87b141d44706fedf7821c266c6207564fd77a9b6 Reviewed-on: https://chromium-review.googlesource.com/1148577Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54677}
-
Clemens Hammacher authored
Drive-by: Convert const to constexpr. R=titzer@chromium.org Bug: v8:7965 Change-Id: Ifddfba78e819a0d340fba27a6efedea654b057e8 Reviewed-on: https://chromium-review.googlesource.com/1148722Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54676}
-
- 24 Jul, 2018 6 commits
-
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-list-format/ Design Doc: go/add-intl.listformat-to-v8 Test: intl/list-format/* R=gsathya@chromium.org, mvstanton@chromium.org Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0dfb91b7806007e4f02f3b0438c30528c8143081 Reviewed-on: https://chromium-review.googlesource.com/1124343 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54668}
-
Peter Marshall authored
Change-Id: Ib0a047c0e02b3feaf878af2ec87d5d0f35167280 Reviewed-on: https://chromium-review.googlesource.com/1148561 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54665}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7965 Change-Id: I5e44e8a4dd522703e7a20e32abae1f66ba44451e Reviewed-on: https://chromium-review.googlesource.com/1148566Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54661}
-
Clemens Hammacher authored
This is a reland of a462a785 Original change's description: > [turboassembler] Introduce hard-abort mode > > For checks and assertions (mostly for debug code, like stack alignment > or zero extension), we had two modes: Emit a call to the {Abort} > runtime function (the default), and emit a debug break (used for > testing, enabled via --trap-on-abort). > In wasm, where we cannot just call a runtime function because code must > be isolate independent, we always used the trap-on-abort behaviour. > This causes problems for our fuzzers, which do not catch SIGTRAP, and > hence do not detect debug code failures. > > This CL introduces a third mode ("hard abort"), which calls a C > function via {ExternalReference}. The C function still outputs the > abort reason, but does not print the stack trace. It then aborts via > "OS::Abort", just like the runtime function. > This will allow fuzzers to detect the crash and even find a nice error > message. > > Even though this looks like a lot of code churn, it is actually not. > Most added lines are new tests, and other changes are minimal. > > R=mstarzinger@chromium.org > > Bug: chromium:863799 > Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b > Reviewed-on: https://chromium-review.googlesource.com/1142163 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54592} Bug: chromium:863799 Change-Id: I7729a47b4823a982a8e201df36520aa2b6ef5326 Reviewed-on: https://chromium-review.googlesource.com/1146100Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54656}
-
Tobias Tebbi authored
This also fixes all resulting failures. Bug: v8:7965 Change-Id: I5451cdd3a3ec48c708107a22445808c268efe861 Reviewed-on: https://chromium-review.googlesource.com/1148336 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54643}
-
Michael Achenbach authored
Bug: chromium:846711 Change-Id: Ic51e31a48106e495c3dc7d75ef4c97fa82071a64 Reviewed-on: https://chromium-review.googlesource.com/1148057Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54633}
-