Commit 6cd560b2 authored by Sergiy Byelozyorov's avatar Sergiy Byelozyorov Committed by Commit Bot

Revert "[tools] Add an option to checkout v8-perf repo before running perf tests"

This reverts commit ba023371.

Reason for revert: decided to use CIPD package instead, see reasoning here: http://shortn/_MgZHcjC60Q.

Original change's description:
> [tools] Add an option to checkout v8-perf repo before running perf tests
>
> R=​machenbach@chromium.org
>
> No-Try: true
> Bug: chromium:838864
> Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883
> Reviewed-on: https://chromium-review.googlesource.com/1151295
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54723}

TBR=machenbach@chromium.org,sergiyb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Try: true
No-Tree-Checks: true
Bug: chromium:838864
Change-Id: I65a5b075c6fede61b59528ba92f6803011f187c7
Reviewed-on: https://chromium-review.googlesource.com/1153687
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54759}
parent 670fa86f
......@@ -126,7 +126,6 @@ RESULT_LIST_RE = re.compile(r"^\[([^\]]+)\]$")
TOOLS_BASE = os.path.abspath(os.path.dirname(__file__))
ANDROID_BUILD_TOOLS = os.path.join(
os.path.dirname(TOOLS_BASE), 'build', 'android')
V8_PERF_INTERNAL_REPO = 'https://chrome-internal.googlesource.com/v8/v8-perf'
def LoadAndroidBuildTools(path): # pragma: no cover
......@@ -1043,11 +1042,6 @@ def Main(args):
"--filter=JSTests/TypedArrays/ will run only TypedArray "
"benchmarks from the JSTests suite.",
default="")
parser.add_option('--checkout-internal-perf-at',
help="When specified the script will clone V8 repository "
"with internal perf tests at the specified revision to "
"v8-perf subdirectory in current working directory. The "
"caller must have read access to the repo.")
(options, args) = parser.parse_args(args)
......@@ -1102,15 +1096,6 @@ def Main(args):
options.json_test_results_secondary = os.path.abspath(
options.json_test_results_secondary)
if options.checkout_internal_perf_at:
v8_perf_internal_path = os.path.abspath('v8-perf')
# TODO(sergiyb): Add logic to reuse Git cache on the bot if available.
subprocess.check_call(
['git', 'clone', V8_PERF_INTERNAL_REPO, v8_perf_internal_path])
subprocess.check_call(
['git', 'reset', '--hard', options.checkout_internal_perf_at],
cwd=v8_perf_internal_path)
# Ensure all arguments have absolute path before we start changing current
# directory.
args = map(os.path.abspath, args)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment