- 26 Oct, 2021 23 commits
-
-
Maya Lekova authored
This reverts commit 40b062ce. Reason for revert: Failing Fuzz tests on arm - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/27306/overview Original change's description: > [future] Use mid-tier regalloc for huge functions > > Stage the --turbo-use-mid-tier-regalloc-for-huge-functions behind > --future. > > R=thibaudm@chromium.org > > Bug: v8:12287, v8:12320 > Change-Id: I7145ca1b022bfdcb0b61d6666daf855f14cbc4ce > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236547 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77549} Bug: v8:12287, v8:12320 Change-Id: Id86e9c0d44e6a273abdeb384f722ff308c56e70f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245342 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77553}
-
Jakob Gruber authored
We used to apply an invalid optimization which skips `length` writes if the JSArray is 'fast' and the old value equals the new value. This optimization is not valid if e.g. `length` is non-writable. Fixed: chromium:1262478 Change-Id: I49ef50de293dae5c3a62c64b303ec34b9c0f6cbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236720Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77552}
-
Kim-Anh Tran authored
A test was overflowing on the progress counter when using int as type. This CL is fixing the progress counter to use uint32_t, and re-enables the test. Why uint32_t instead of size_t? In the referenced bug, the progress_counter_ (but not the progress_total_) triggered an overflow; and since these two counters should be relatively similar (the total count is an estimate, and can be less than the actual progress count), we do not expect the count to increase much more than we can already encode with int. Bug: chromium:1246860 Change-Id: I9769884ef60d352b3787c2223e528ddf33b0b23e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245116 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77551}
-
Camillo Bruni authored
As per output of ./tools/release/list_deprecated.py Bug: v8:11165 Change-Id: Ib5ae6fd1ec7209cc89d436d337b97a4c82391da3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245118 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77550}
-
Clemens Backes authored
Stage the --turbo-use-mid-tier-regalloc-for-huge-functions behind --future. R=thibaudm@chromium.org Bug: v8:12287, v8:12320 Change-Id: I7145ca1b022bfdcb0b61d6666daf855f14cbc4ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236547Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77549}
-
Camillo Bruni authored
- More compact output - Fix off-by-one for deprecation messages Bug: v8:11165 Change-Id: I35e89e9496b4306ed0c692bde321d33c4bc1cd97 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245119 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77548}
-
Victor Gomes authored
Reduce sampling interval to increase test accuracy. Flakes happen specially when compiling with Sparkplug. Bug: v8:12054 Change-Id: Ic58bc97d0ad9861259fc8df4b121425b375669e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245336 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77547}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I7edcb864e2fefe105c4da9120fbe3891822c4f85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240787 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
R=mslekova@chromium.org Change-Id: I47b9a286cc0f1b9dd64bf564423b4fb4af4a19ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244954 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77545}
-
Clemens Backes authored
R=hpayer@chromium.org CC=neis@chromium.org Change-Id: Ic9fef5f964b548bc3dc7bd0f7abfe8e1a6c777e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231338 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#77544}
-
Clemens Backes authored
The dominator tree is usually computed as part of scheduling (in {Scheduler::ComputeSchedule}). For tests it was missing, leading to DCHECK errors in the mid-tier register allocator, which uses the dominator tree. R=mslekova@chromium.org Bug: v8:12330 Change-Id: I02bc8dee3aecb6a1613fa1d07d3aae85cd28de17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245114Reviewed-by: -
Thibaud Michaud authored
R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: Ied9ab5fa5009e5ab268d1c9893729d8210ae62ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220344 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77542}
-
Maria Tîmbur authored
Add support for immutable arrays. Bug: v8:11954 Change-Id: Ia343247d5fbc960e0e5b1f9b7cb75e734a747d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240827Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77541}
-
Camillo Bruni authored
- Check that we only store internalized strings for context-allocated function names - Fix call to FunctionContextSlotIndex from V8HeapExplorer that could end up passing in a non-internalized string Bug: chromium:1255105 Change-Id: Ie8bd5577bd0086241d47991fbe285f5d64ae3d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245113Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77540}
-
Leszek Swirski authored
Tar and Gzip would include timestamps for files in the gcmole package, which meant that they weren't deterministic across multiple builds. Now we strip out the timestamps (as well as owner/group information) to make the packaging more deterministic. Change-Id: Iec3195ede4150c1603927fec748455329a8da677 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245112Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77539}
-
Samuel Groß authored
When pointer compression is enabled, the heap layout inside the pointer compression region is expected to be predictable (see mkgrokdump) and so random page allocator hints should not be used when allocating the pages. This used to work before crrev.com/c/3220151 as the BoundedPageAllocator would simply ignore any hints. Bug: v8:12334 Change-Id: I6e10f1a60728fb88a7a99a2a435090b063a03f6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236546Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add a SerializedCodeData constructor which skips all sanity checks aside from the source hash check, to be used after off-thread deserialization (which does these other checks already). In particular, this skips doing the checksum again, which would otherwise require a second walk over the serialized data. This requires saving the off-thread sanity check result (in the case of a failure), since it is no longer recomputed. Change-Id: I664c309c9cb8dca94a74b4293c84ceb353f37ed4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240402 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77537}
-
Jakob Gruber authored
A follow-up to crrev.com/c/3240782. Drive-by: extend JSRegExp printing. Fixed: chromium:1263327 Bug: v8:11069 Change-Id: Iff64ded27ca93641f0f572df2ce0a9f846948f7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245110 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#77536}
-
Omer Katz authored
Some fields didn't have default values, which made it impossible to check whether or not all fields are initialized. Bug: chromium:1056170 Change-Id: I8c6f89e64661420460bfc351473a47a623ef6399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3243462Reviewed-by:
-
Michael Lippautz authored
v8_enable_v8_checks has very little coverage outside of V8 itself. Move pointer verification checks behind DEBUG so that they fire in regular debug or dcheck_always_on builds. Change-Id: Ib2803240dd996f4223e403d20e927aff2955afbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3242006Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77534}
-
Camillo Bruni authored
This fixes webkit/run-json-stringify broken by https://crrev.com/c/3222765 Failure: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8832393633085738145/+/u/Bisect_23af060d/Retry_-_default/run-json-stringify Bug: chromium:1244145 Change-Id: I1235f6db8ab10356476cd1028b20300f86510119 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3242005 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77533}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/80d70dd..365670e Added Doxygen support. (#1228) (Vitaly Zaitsev) https://chromium.googlesource.com/external/github.com/google/benchmark/+/365670e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I124d163fd57ea7702462ff8e8998e5aff56092d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77532}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/acad0f2..0afcdef Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/f5750f5..850fe71 Rolling v8/third_party/aemu-linux-x64: 8buMrGFlldiiEGiS-u8rclQGhORwxrcN14vZGo5U8sgC..anmoXU7qoa185RNsOxsBoD0U-T6rHNnNeGfdCNx1LB0C Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7a6ff98..7bd4c88 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I15b45d42227221ebbd7c99efdf612ecc789ecfc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244930Reviewed-by:
-
- 25 Oct, 2021 17 commits
-
-
Omer Katz authored
Bug: v8:12050 Change-Id: I599338eba458e177327870699b6ea8a423e144c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211577 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/main@{#77530}
-
Michael Lippautz authored
Check for the most commonly used wrong sentinel value (-1). Users should use cppgc::kSentinelPointer instead. Bug: chromium:1263009 Change-Id: I200954bcd70c6a100ffec24aece3e1843e1438a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3242002 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Bug: v8:12297 Change-Id: Ifbf6ac61e6b61e419b361d1fc14009d6d745193c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231484Reviewed-by:
Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Omer Katz authored
ObjectSizeTrait::GetSize is used by Trace methods in Blink and may be called while concurrent marking is active. The current version is non-atmoic and therefore can race with marking on other threads. Bug: chromium:1261860 Change-Id: Ia0b41ec496ac64ae3dd5a040b25f6972b21561c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240832Reviewed-by:
-
Milad Fa authored
variable 'pushed_stack_space' set but not used. Change-Id: I427f76448b9933f9c8f1169709e28eef4512241f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241543Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77526}
-
Thibaud Michaud authored
R=ahaas@chromium.org Change-Id: I860cd7aebdf46f323c7f6ad0cd563246a061c4d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226338 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Camillo Bruni authored
For the upcoming host_defined_options fixes we will have to explicitly pass the host-defined options to Invoke so we will be able to install it in the script context in the future. Bug: chromium:1244145 Change-Id: I690cc774d6a17278db4381aba8c3408e979606c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222765 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Persistent node slots are dynamically allocated and their allocation may fail. Delegate to the proper OOM handler in this case. Bug: chromium:1243257 Change-Id: I985f5b0c940f7ac4996f3f3243123a07119005b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240786Reviewed-by:
-
v8-ci-autoroll-builder authored
R=clemensb@chromium.org Change-Id: Ia804d29a61e9d716b5ee5acebce7cb9c273697d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241363 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Maya Lekova authored
This CL fixes an issue in EffectControlLinearizer, where the primitive type of the argument of a fast C call was used to compute its MachineType even when the argument was actually a TypedArray, which should always be treated as a Tagged type. This resulted in Float32/64 typed arrays being passed in FP registers, leading to a crash in the register allocator. Drive-by fix: Fixed output from --trace-turbo-alloc so that all of its sub-parts are printed with PrintF, avoiding interleaved log lines. Bug: chromium:1260954 Change-Id: I249c8629daae3af437fb52f53f45211f3a214222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231341Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77521}
-
Victor Gomes authored
Drive-by: Use only LocalIsolate in AllocateConcurrentSP Bug: v8:12054 Change-Id: Ibdd8b562548f249fc2be4dca723ce4fedc7c09ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240783 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77520}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I9a936c293e261142111e235c041e3526680d9629 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240828Reviewed-by:
-
Michael Lippautz authored
Marking verification should only process young generation objects when verifying the marking state of a young generation garbage collection. Bug: v8:12324 Change-Id: I01db261437ec5c42ddb6c79c44e31b5fe0e536d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231343Reviewed-by:
-
Jakob Gruber authored
No-Try: true Bug: chromium:1262423 Change-Id: I9d56e347d046944f01e33aa6fb8752c889e2d38d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240784 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1254189 Change-Id: I77854c767cf5c5748999fdd40a4a42e25dff3f79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236989Reviewed-by:
-
Manos Koukoutos authored
We introduce simple escape analysis for wasm-gc objects, where struct allocations that are only assigned to are eliminated. Handling phi uses of allocated objects is left for future work. Bug: v8:11510 Change-Id: Ibd0b220466546e150b26b02890572a5174c6872d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229744Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77515}
-
Jakob Gruber authored
Character class handling in the irregexp pipeline is quite complex; codepoints outside the BMP (basic multilingual plane) are only translated into surrogate pairs when needed, e.g. when the subject string is two-byte. If not needed, the codepoints simply stay part of the list of CharacterRanges. In EmitCharClass, we determine the valid subset of ranges through ranges_length; until this CL, we forgot to pass that information on to MakeRangeArray. Do that now by truncating the list of CharacterRanges. Fixed: chromium:1262423 Change-Id: I5bb5b839e9935890ca2d10908ad66d72c3217178 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240782 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
