- 15 Nov, 2018 6 commits
-
-
Jakob Gruber authored
This CL adds support for embedded builtins in nosnap builds by creating and setting an 'embedded blob' after builtin generation. Unlike snapshot builds, the blob is not embedded into the .text section but located on the C++ heap. This makes nosnap builds more consistent with mksnapshot, and allows us to simplify there and in serializer cctests. Complications arise from the different workflows we need to support: 1. the standard mksnapshot build process, 2. nosnap builds (which reuse the blob created by the first Isolate), 2. and tests with various complicated serialization workflows. To cover all of these cases, this CL introduces two knobs to twiddle: 1. A 'sticky' embedded blob which overrides compiled-in default embedded blobs at Isolate setup. 2. The blob lifecycle can be managed manually or through refcounting. These are described in more detail in isolate.cc. Tbr: ulan@chromium.org Bug: v8:6666, v8:8350 Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d Reviewed-on: https://chromium-review.googlesource.com/c/1310195Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57523}
-
Mike Stanton authored
R=jarin@chromium.org Change-Id: Ia585398db7e9c69283450def924bc10edc37448f Reviewed-on: https://chromium-review.googlesource.com/c/1335563Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57522}
-
Frank Tang authored
Add regression test to verify array with packed, holey and dictionary elements. Change ToUnicodeStringArray to return vector<UnicodeString> instead allocate raw UnicodeString before calling. Simplify ToUnicodeStringArray to loop only once. Bug: chromium:903566 Change-Id: I7ad74179be97d3cf929d2949384dbaa8b66a9a02 Reviewed-on: https://chromium-review.googlesource.com/c/1328642 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57521}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6600235..ccf9ff5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6b8b30c..8a6451c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ef71a5f..f66e551 Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id6ee2891245ec1ce147c83ba1f9715646bb15c56 Reviewed-on: https://chromium-review.googlesource.com/c/1336783Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57520}
-
Deepti Gandluri authored
BUG:v8:6020 Change-Id: I289a43d834765635425276afb80c2361152fdcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1336113 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57519}
-
Erik Luo authored
`console.table` used to have a 1k limit on preview properties, which regressed to 100 during refactoring. This CL restores the 1k limit, and ensures that `buildEntryPreview` does not use the 1k limit. Bug: chromium:903623 Change-Id: I8fab3182a79d1bb6b662e2ff9b229db3d3a889ca Reviewed-on: https://chromium-review.googlesource.com/c/1332127Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#57518}
-
- 14 Nov, 2018 32 commits
-
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8af70c5..6600235 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0cf6ee7..6b8b30c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/332c9ff..ef71a5f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/2e68926..879ac09 Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0cbffcb71b49e1d54e2aedb19f6dab65448586a0 Reviewed-on: https://chromium-review.googlesource.com/c/1336187Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test after recent changes made Debug-mode stack frames a bit larger. a bit of Debug-mode stack space. Bonus: drops an unnecessary cast from SerializeJSObject to save Change-Id: I22696a1d80a6a73b5049b018e72cc8a3d8693042 Reviewed-on: https://chromium-review.googlesource.com/c/1334448Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57516}
-
Tobias Tebbi authored
This allows to call generic callables without mentioning all type parameters, if they can be deduced from the types passed as arguments. Bug: v8:7793 Change-Id: Idb37bb6b93c48bd6344c5be19da4e5b19d29593f Reviewed-on: https://chromium-review.googlesource.com/c/1335936Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57515}
-
Toon Verwaest authored
The functions are sufficiently different and AnalyzePartially is performance-sensitive so it's helpful to see what exact code is in there. Change-Id: I8807684e58a7af48bdba62f0adf41e78f7b6557d Reviewed-on: https://chromium-review.googlesource.com/c/1335701Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57514}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I1b6a54b73be163386be6915402f7d8f9ba838a25 Reviewed-on: https://chromium-review.googlesource.com/c/1335697 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57513}
-
Toon Verwaest authored
Change-Id: I3d07bb2d1ae8c77a6b245f5e4ca6f755e2617730 Reviewed-on: https://chromium-review.googlesource.com/c/1335698Reviewed-by:
-
Michael Starzinger authored
This avoids creating an on-heap copy for import wrappers by directly adding the {WasmCode} into the native heap instead. It reduces compilation time as well as useless GC pressure. R=clemensh@chromium.org BUG=v8:8423 Change-Id: Ia063523834c963591027c7d1ed78b795d24907bf Reviewed-on: https://chromium-review.googlesource.com/c/1335566 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Igor Sheludko authored
in order to be able to properly deserialize the latter in case of enabled pointer compression where the cleared weak reference value is Isolate-dependent. Bug: v8:7703 Change-Id: Ied995bc15317c83fcc03cf27de3fbf135659a9d5 Reviewed-on: https://chromium-review.googlesource.com/c/1333676 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This updates fast path checks in string's search/match/replace/split/matchAll methods. Bug: v8:8361 Change-Id: I0377aff21e380d6c718e7471f8964e10c030281b Reviewed-on: https://chromium-review.googlesource.com/c/1333668 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I53fc5b8ff39c91fe509e292cf32f54ff4f8e2eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1335694 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I9925db0d74ef96bf91ea261f275e37c10908c9ef Reviewed-on: https://chromium-review.googlesource.com/c/1335695 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57507}
-
Leszek Swirski authored
Moves the unicode predicate cache tables out of the unicode cache, and turns them into generic predicates in char-predicates.h which use static constexpr tables. This drops the per-isolate cost of unicode caches, and removes the need for accessing the unicode cache from most files. It does remove the mutability of the cache, which means that there may be regressions when parsing non-ASCII identifiers. Most likely the benefits to ASCII identifiers/keywords will outweigh any non-ASCII costs. Change-Id: I9a7a8b7c9b22d3e9ede824ab4e27f133ce20a399 Reviewed-on: https://chromium-review.googlesource.com/c/1335564Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57506}
-
Maya Lekova authored
Promise.resolve shouldn't be optimized when the async hooks are enabled. Bug: chromium:900674 Change-Id: I225c3d9002f293395993ded37a1d475635467a94 Reviewed-on: https://chromium-review.googlesource.com/c/1335693 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57505}
-
Toon Verwaest authored
Change-Id: I3331676ac226da976d7123ead81e05703272b14a Reviewed-on: https://chromium-review.googlesource.com/c/1335929Reviewed-by:
-
Michael Starzinger authored
This makes the above factory function use a fine-grained scope when unlocking code space for modification. It now uses a cumulative per-page scope that collects only those memory chunks that needed to be touched during allocation. R=ulan@chromium.org Change-Id: I22de0fae8be507ba9d51868f668b902b3bae3d6a Reviewed-on: https://chromium-review.googlesource.com/c/1335558Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57503}
-
Clemens Hammacher authored
Variables of type {ExecutionTier} should be called "tier", not "mode". R=ahaas@chromium.org Bug: v8:8238 Change-Id: I09c640398ab8ad34ac6591d42ea7b0f9ba83d620 Reviewed-on: https://chromium-review.googlesource.com/c/1335688Reviewed-by: -
Clemens Hammacher authored
The callbacks must follow a specific order. This CL adds checks for that. This helped debugging an issue in a follow-up CL. R=ahaas@chromium.org Bug: v8:7921 Change-Id: I78e1caf9923e95401652d2a3952dcf29c2967062 Reviewed-on: https://chromium-review.googlesource.com/c/1325965Reviewed-by:
-
Igor Sheludko authored
Also add comments and regression tests. Bug: chromium:904272 Change-Id: I89e8ec537bbdce09fda120cd29d5a5e54e77cf19 Reviewed-on: https://chromium-review.googlesource.com/c/1335556Reviewed-by:
-
Sathya Gunasekaran authored
Now we can pass in the prefix size to OrderedHashTable directly from the Derived class and have it calculate the hash table start offset based on this. Bug: v8:6443, v8:7569 Change-Id: I80d54b65116e18f5a0cab18eb51649adad447cce Reviewed-on: https://chromium-review.googlesource.com/c/1333682 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes the above factory function use a fine-grained scope when unlocking code space for modification. It is now based on the memory chunk of the resulting code object. R=ulan@chromium.org Change-Id: Iabe6fba7595ba3264b21bcd6f6634ab9725eaad9 Reviewed-on: https://chromium-review.googlesource.com/c/1335687Reviewed-by:
-
Leszek Swirski authored
Always generate a token for the first character in ScanSingleToken, and switch on that. If the token could change with subsequent characters, e.g. Token::ADD into Token::ASSIGN_ADD, then handle that in that token's case rather than going character-by-character. This allows us to have a tighter packing of the cases, and early detect numbers, keywords and identifiers. Change-Id: I8c3ac7a5453547abeb09fc90826a26390b15a415 Reviewed-on: https://chromium-review.googlesource.com/c/1335547Reviewed-by:
-
Ivica Bogosavljevic authored
This CL implements AtomicPair operators: Load, Store, Add, Sub, Or, Xor, And, Exchange and CompareExchange using runtime on MIPS32R2 and older. MIPS32R6 includes instructions for 64-bit atomic access so they are implemented using those. Change-Id: I1309c1ea4771480516ec5a92f7592533bdcb205c Reviewed-on: https://chromium-review.googlesource.com/c/1326466Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
-
Predrag Rudic authored
Build started to fail after this commit: bd0a7fd6. Change-Id: I2b628c067f6e5120d19498fd0b766c5233baf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1335552Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57495}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Idb11b07df72f2d9d1c606d04af701cb4e9853664 Reviewed-on: https://chromium-review.googlesource.com/c/1335549Reviewed-by:
-
Toon Verwaest authored
Change-Id: I084b57a3a32c9ecb01bb17c9339dfeada436ea66 Reviewed-on: https://chromium-review.googlesource.com/c/1335449 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iacfa93bdce7d8d175db9e606b7c667e4c967da51 Reviewed-on: https://chromium-review.googlesource.com/c/1335451Reviewed-by:
-
Georg Neis authored
Bug: chromium:904417, v8:7790 Change-Id: Ie1edc179c88747a2515f2c42b4820ce3126bfe43 Reviewed-on: https://chromium-review.googlesource.com/c/1331478Reviewed-by:
-
Michael Achenbach authored
Apparently the first attempt wasn't working yet: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/8806 TBR=sergiyb@chromium.org NOTRY=true Change-Id: I5864845e59508cd4cd1836798b56539d74bbb82e Reviewed-on: https://chromium-review.googlesource.com/c/1335450Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ib910d034aff130dfe4324d020eacb0e7bf185d30 Reviewed-on: https://chromium-review.googlesource.com/c/1335447Reviewed-by:
-
peterwmwong authored
[builtins] Adjust String.prototype.matchAll as per spec changes (https://github.com/tc39/proposal-string-matchall/pull/38) - Removes IsRegExp check and special handling when false - Removes MatchAllIterator - Extracts previously inlined CreateRegExpStringIterator - Update comments to match spec text and numbering Bug: v8:6890 Change-Id: Ie81757a499acc77910f029835fb042e70d86d83d Reviewed-on: https://chromium-review.googlesource.com/c/1317830 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: Ie45a93dc851f0bc12800cbd91fe324c854b1dcb6 Reviewed-on: https://chromium-review.googlesource.com/c/1335448Reviewed-by:
-
Michael Achenbach authored
This is to prevent errors like: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/8792 The error code suggests the OS killed the tests due to OOM. The time it took suggests OS paging. Fewer tests in parallel should mitigate this. NOTRY=true Change-Id: I847058cfb02a9a36795581df47760d921d695141 Reviewed-on: https://chromium-review.googlesource.com/c/1333674 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
- 13 Nov, 2018 2 commits
-
-
Junliang Yan authored
Port bd0a7fd6 Original Commit Message: This reduces the build steps after touching counters.h from 710 to 191, thus detaching counters.h from the giant include cluster. R=marja@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:7490,v8:8238 LOG=N Change-Id: I7694a21856c228c6d0335c1f1e5e9177c96cc7da Reviewed-on: https://chromium-review.googlesource.com/c/1333940Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57485}
-
Frank Tang authored
Remove old code in v8::Date::DateTimeConfigurationChangeNotification Add code to clear date time cache object in isolate. Running benchmark python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Dates" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Numbers" \ test/js-perf-test/JSTests.json BEFORE THE FIX: StringLocaleCompare-Strings(Score): 184287 toLocaleDateString-Dates(Score): 10456 toLocaleString-Dates(Score): 10436 toLocaleTimeString-Dates(Score): 10700 toLocaleString-Numbers(Score): 2935 AFTER THE FIX in Patch Set 13: StringLocaleCompare-Strings(Score): 57470000 toLocaleDateString-Dates(Score): 6141000 toLocaleString-Dates(Score): 4093000 toLocaleTimeString-Dates(Score): 6323000 toLocaleString-Numbers(Score): 3371000 Bug: chromium:901748, chromium:901747, v8:5751 Change-Id: I7578e2ced0fe967dce6424d17f15ab806cc522be Reviewed-on: https://chromium-review.googlesource.com/c/1320892 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
