• Frank Tang's avatar
    [Intl] Cache intl objects in isolate · 7aced299
    Frank Tang authored
    Remove old code in v8::Date::DateTimeConfigurationChangeNotification
    Add code to clear date time cache object in isolate.
    
    Running benchmark
    python -u tools/run_perf.py --binary-override-path \
      out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \
      test/js-perf-test/JSTests.json
    python -u tools/run_perf.py --binary-override-path \
      out/x64.release/d8 --filter "JSTests/Dates" \
      test/js-perf-test/JSTests.json
    python -u tools/run_perf.py --binary-override-path \
      out/x64.release/d8 --filter "JSTests/Numbers" \
      test/js-perf-test/JSTests.json
    
    BEFORE THE FIX:
    StringLocaleCompare-Strings(Score): 184287
    toLocaleDateString-Dates(Score): 10456
    toLocaleString-Dates(Score): 10436
    toLocaleTimeString-Dates(Score): 10700
    toLocaleString-Numbers(Score): 2935
    
    AFTER THE FIX in Patch Set 13:
    StringLocaleCompare-Strings(Score): 57470000
    toLocaleDateString-Dates(Score): 6141000
    toLocaleString-Dates(Score): 4093000
    toLocaleTimeString-Dates(Score): 6323000
    toLocaleString-Numbers(Score): 3371000
    
    Bug: chromium:901748, chromium:901747, v8:5751
    Change-Id: I7578e2ced0fe967dce6424d17f15ab806cc522be
    Reviewed-on: https://chromium-review.googlesource.com/c/1320892
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57484}
    7aced299
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...