Skip to content

V
V8
Switch branch/tag
  1. 05 May, 2021 1 commit
    • Daniel Dromboski's avatar
      [tools] More Python 3 compatibility fixes · 8807f0ad
      Daniel Dromboski authored 
      These should all be forward/backward compatible with Python 2/Python 3.

[tools] Tweak statusfile.py for Python 3

.iteritems() does not exist in Python 3, only .items().

(While .iteritems() was meant to be an optimization over .items()
in Python 2, .items() should work fine, and it is forward/backward
compatible.)


[tools] Fix another Python 3 issue in mb.py

sys.platform used to return e.g. 'linux2', which is 'linux' plus
whatever the first digit of `uname -r` was when Python was built.
As of Python 3.3, it always returns just 'linux' for Linux OSes.
Use `sys.platform.startswith('linux')` for forward/backward
compatibility.


[tools] Make base_runner.py Python 3 compatible

dict.keys() returns a dict_keys in Python 3, whereas it
used to return a simple array. list() is forward/backward
compatible with identical results on Python 2/3 (returns array).

(Tested on Linux x64, trying to recreate NodeJS's CI workflow.)


[tools] Make tools/dev/v8gen.py work with Python 3

dict.keys() returns a dict_keys in Python 3, whereas it
used to return a simple array. list() is forward/backward
compatible with identical results on Python 2/3 (returns array).

Comparing a None-type value numerically used to result in the
None-type value always being considered "less than" the thing
it is compared to. As of Python 3, numerically comparing against
None or None-typed values results in an error. Check if a value
is truthy before numerically comparing it, for forward/backward
compatibility.

print() used to transparently decode byte strings in Python 2.
In Python 3, they must be explicitly decoded first.

(Tested on Linux 64-bit, trying to recreate NodeJS's CI workflow.)

Bug: v8:9871
Change-Id: I059bf98577a67649bbe7ec49848989d468da96b0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867270Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74369}
      8807f0ad
  3. 19 Apr, 2021 1 commit
  5. 24 Mar, 2021 1 commit
  7. 12 Mar, 2021 1 commit
  9. 10 Mar, 2021 1 commit
  11. 04 Mar, 2021 1 commit
    • Jakob Kummerow's avatar
      [gm.py] Fix goma detection · 76a302f9
      Jakob Kummerow authored 
      Now that Goma is part of depot_tools (and any stale standalone
checkouts in ~/goma are dysfunctional), update gm.py's detection
logic.
Note: this only affects new args.gn files created by gm.py. On
machines where the build is already set up, this has no effect.

Fixed: v8:11160
No-Try: true
Change-Id: I19f475a51d4345d803d49d3ad2720a0f4f6f84bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2735637Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73194}
      76a302f9
  13. 11 Feb, 2021 1 commit
  15. 09 Feb, 2021 1 commit
  17. 28 Jan, 2021 1 commit
  19. 28 Jul, 2020 1 commit
  21. 24 Jul, 2020 1 commit
  23. 22 Jun, 2020 1 commit
  25. 18 Jun, 2020 1 commit
  27. 11 Mar, 2020 1 commit
  29. 10 Mar, 2020 1 commit
  31. 09 Jan, 2020 1 commit
  33. 20 Nov, 2019 1 commit
  35. 08 Nov, 2019 1 commit
  37. 16 Sep, 2019 1 commit
  39. 28 May, 2019 1 commit
  41. 05 Mar, 2019 1 commit
  43. 25 Feb, 2019 1 commit
  45. 19 Feb, 2019 1 commit
  47. 18 Feb, 2019 1 commit
  49. 11 Jan, 2019 1 commit
  51. 18 Dec, 2018 1 commit
  53. 07 Nov, 2018 1 commit
    • Igor Sheludko's avatar
      [gm.py] Allow arbitrary mode suffixes · f17b0d26
      Igor Sheludko authored 
      which will allow gm to work for more directories than just [<arch>].[<mode>]:
  gm.py ia32.release-nosnap.check
  gm.py x64.optdebug-ptr-compr cctest unittests

Basically the new usage is:
  gm.py [<arch>].[<mode>[-<suffix>]].[<target>] [testname...]

Once default gn configuration is created based on <arch> and <mode> the script user
may change it and then use gm as usual.

Bug: v8:8238
Change-Id: I9659b87073e815e0e4754f0a2f1056f3403c149c
Reviewed-on: https://chromium-review.googlesource.com/c/1323734Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57328}
      f17b0d26
  55. 24 Oct, 2018 1 commit
  57. 15 Oct, 2018 1 commit
  59. 29 Jun, 2018 1 commit
  61. 28 Jun, 2018 2 commits
    • Jakob Gruber's avatar
      Revert "[build] Disable slow asserts for v8_enable_fast_mksnapshot" · cf66f737
      Jakob Gruber authored 
      This reverts commit 7a0d6a50.

Reason for revert: Breaks no-slow-assert builds.

Original change's description:
> [build] Disable slow asserts for v8_enable_fast_mksnapshot
> 
> Slow asserts double the time spent in mksnapshot. While we want them
> enabled on our bot builds, local builds should be fast and don't
> necessarily need them.
> 
> This also adds v8_enable_fast_mksnapshot as default in gm.py.
> 
> Bug: v8:7891,v8:6688
> Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9
> Reviewed-on: https://chromium-review.googlesource.com/1116552
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54074}

TBR=jkummerow@chromium.org,jgruber@chromium.org

Change-Id: I6b048e819846c4bd9a064f82e2f3c7609369cd33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7891, v8:6688
Reviewed-on: https://chromium-review.googlesource.com/1118138Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54077}
      cf66f737
    • jgruber's avatar
      [build] Disable slow asserts for v8_enable_fast_mksnapshot · 7a0d6a50
      jgruber authored 
      Slow asserts double the time spent in mksnapshot. While we want them
enabled on our bot builds, local builds should be fast and don't
necessarily need them.

This also adds v8_enable_fast_mksnapshot as default in gm.py.

Bug: v8:7891,v8:6688
Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9
Reviewed-on: https://chromium-review.googlesource.com/1116552Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54074}
      7a0d6a50
  63. 21 May, 2018 1 commit
  65. 19 Jan, 2018 1 commit
  67. 29 Nov, 2017 1 commit
  69. 05 Sep, 2017 2 commits
  71. 18 Jul, 2017 1 commit
  73. 30 Jun, 2017 1 commit
  75. 14 Jun, 2017 1 commit