Commit 8d2c8d10 authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

[gm.py] More convenience for "mkgrokdump"

Now the following command builds mkgrokdump for x64.release and runs it
to update v8heapconst.py:

  gm.py mkgrokdump

Building the binary for other architectures still works as before.

No-Try: true
Change-Id: Iacfa1a50702b0452d00ba18e1306423b161ffe65
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317352
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69054}
parent 5fc196ac
......@@ -300,6 +300,11 @@ class Config(object):
return return_code
def RunTests(self):
# Special handling for "mkgrokdump": if it was built, run it.
if (self.arch == "x64" and self.mode == "release" and
"mkgrokdump" in self.targets):
_Call("%s/mkgrokdump > tools/v8heapconst.py" %
GetPath(self.arch, self.mode))
if not self.tests: return 0
if "ALL" in self.tests:
tests = ""
......@@ -352,6 +357,10 @@ class ArgumentParser(object):
targets = []
actions = []
tests = []
# Special handling for "mkgrokdump": build it for x64.release.
if argstring == "mkgrokdump":
self.PopulateConfigs(["x64"], ["release"], ["mkgrokdump"], [])
return
# Specifying a single unit test looks like "unittests/Foo.Bar", test262
# tests have names like "S15.4.4.7_A4_T1", don't split these.
if argstring.startswith("unittests/") or argstring.startswith("test262/"):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment