- 11 Nov, 2019 9 commits
-
-
Liviu Rau authored
When a test fails the exit code of the process is printed in the logs in the decimal format. On Windows searching for the actual error is pretty difficult in this format since we are dealing with negative values errors. We print now the hex format of the same exit value next to the original one. Example failure of a test: https://ci.chromium.org/p/v8/builders/try/v8_win64_dbg/b8897355488287117696 https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8897355488287117696/+/steps/Check/0/stdout https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8897355488287117696/+/steps/Check/0/logs/RunWasmInterpreter_Int32Const_many/0 Bug: v8:9810 Change-Id: I51b65d6105bda6516707a764dbd41fd36c9dfc80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903975 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64878}
-
Andreas Haas authored
I changed the verification algorithm of switch nodes from a quadratic algorithm to a linear one. On my machine this speeds up the test from 17 seconds to 2 seconds in the x64.optdebug build. R=mslekova@chromium.org Bug: v8:9810 Change-Id: I952d3fcc641b4e269b8ebac8f65fe545c6062587 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905768 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64877}
-
Tobias Tebbi authored
Overview: - Change basic type hierarchy to split Tagged into StrongTagged (= Object) and and WeakHeapObject. This enables to emit the right CSA types (Object, MaybeObject). - The new Weak<T> type encodes a possibly cleared weak bit pattern that points to type T if it's not cleared. - Make TNode<Object> a subtype of TNode<MaybeObject> so that the generated code compiles on the C++ side. Drive-by change: simplify a few CSA helpers by using MaybeObject as a common supertype of MaybeObject and Object. - Port CreateObjectWithoutProperties and LoadMapPrototypeInfo. Bug: v8:7793 Change-Id: I895a6501ce3e287ea8cf4065aaff3a5535245ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889870Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64876}
-
Dan Elphick authored
Also fixes its uses in interpreter-generator.cc and accessor-assembler.cc. Bug: v8:9810 Change-Id: Ie9817f3e53c54588a4ad28c2c98da1a48ac73681 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906571Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64875}
-
Michael Achenbach authored
TBR=tmrts@chromium.org No-Try: true Bug: chromium:1021522 Change-Id: I1f5f9bb4f9feb6eae34e62667421a8956c4d007e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906382 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This fixes MSVC Windows builds that were broken due to a missing deps definition. Bug: v8:9954 Change-Id: I19c5112226caadae6a0221acee7bcf19cf0abbc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906379 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Live sets represent sets of live virtual registers at block entry and exit points. They are usually sparsely populated; for example, a sample taken from Octane2 shows 80% of sampled live sets with a fill ratio of 10% or less. Prior to this CL, live sets were implemented as a statically-sized bit vector. This is fine for low-ish virtual register counts, but becomes wasteful at higher numbers. This CL attempts to address this issue through an adaptive implementation. Small live sets remain bit vectors, while larger sets switch to a PersistentMap-based implementation. PersistentMap has very memory-efficient add/remove/copy operations. Of course, with adaptive data structures we enter the territory of parameter fiddling. In this case, two parameters are used: kMaxSmallSetSize controls when to switch implementations, and kMaxDeletionsBeforePrune controls when pruning (= managing the # of deleted entries in the map) sets in. On the (degenerate) test case from the linked bug, the register allocation zone shrinks from 1008MB to 475MB. For more realistic cases I expect savings on the order of 10s of KB. Bug: v8:9574 Change-Id: Id903bbe23f030b418e8d887ef4839c8d65126c52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1891693Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64872}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1023247 Change-Id: I23abb26425d7adcd69d07af906738a69bac8688d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906380 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64871}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e6adad9..789c8f5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibb2f7b826ec35925c3ddaef2b8549e7cd5a1ce6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1908650Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64870}
-
- 10 Nov, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/184cee3..e6adad9 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I82f851809195a2137618b58c36932f4fa509e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1908648Reviewed-by:
-
- 09 Nov, 2019 2 commits
-
-
Zhao Jiazhong authored
port b6edadc0 https://crrev.com/c/1872930 Original Commit Message: [wasm-simd] Implement f64x2 comparisons for arm Change-Id: If0fab2307a7f6da75f27ecd90cef6e15945214dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903290Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#64868}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3cf8d94..184cee3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f9004ee..56af378 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1917f7a..ea1884b TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I10e6a47cc088ff8e1ed1e74595d2bd1a4ae12301 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906234Reviewed-by:
-
- 08 Nov, 2019 20 commits
-
-
Ng Zhi An authored
Implements v32x4.load_splat and v64x2.load_splat. Bug: v8:9886 Change-Id: I18f3b012f9980d258985edf2ff26577fe495eff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903747Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64866}
-
Dan Elphick authored
Shrink RO_SPACE since it contains Immortal immovable objects and is otherwise reporting a virtual size of 256KB when only half of that will ever be used. Bug: v8:9230, v8:7464 Change-Id: I68c17bb6c4ff12170774bad6a07dbb8b9d49cce1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906207 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64865}
-
Dan Elphick authored
Bug: v8:9810 Change-Id: Ie2cba5da240f53f7be7d6aee0426489d972a22a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906569Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64864}
-
David Carlier authored
Using proper register (RIP) on this platform. Change-Id: Iaa0a25e328bd82c152db0ef3632523fd7d621020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1857221Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64863}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1021463 Change-Id: I15d45a51b7341b5767d8eb4c16e7d41508a2811b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906568Reviewed-by:
-
Dan Elphick authored
Exception variables can be Object (e.g. throw 4) so loosen the type from HeapObject. Bug: v8:9810 Change-Id: I14600978ed5159b2b661bd09e69ad6d6530553ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906566 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port: 05918654 Change-Id: I758bd32868186fd3257f88e2c0eb1179332d52d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1904851Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64860}
-
Milad Farazmand authored
All the data types defined under ArgValue are 8 bytes expect "bool as_bool". When casting to <uint64_t> under "tracing/trace-event.h", boolean gets placed on the lower byte of the memory on LE, and on the higher byte on BE machines. When using a "Union" to read back the value as a boolean, only the lower byte of the memory location is read which makes it fine on LE machines, however the value will not be present on BE machines. Using an 8 byte data type as boolean will assure the entire filed is read instead of only the lower byte. Change-Id: I0740b9c019588c963a4c7878af60c6df04827141 TBR: petermarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1896835 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This combines flags switching off CPU-features randomly with all other flags on the numfuzz fuzzers. In a follow up we can add also other interesting flags for testing more features. Bug: chromium:1021463 No-Try: true Change-Id: Ia27d1b8b82dff2bf497242b30ec0b6ef2dfd722d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905846 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:4153 Change-Id: Ieea327828a364ae1934f1a342f361dc68d7bbab6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903433Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64857}
-
Dan Elphick authored
Move the API from Isolate to V8 and add better memory fields. Bug: v8:7464 Change-Id: Ic82c7c74ac8f20a2f2cb896dc0203fdd0b5d8d5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905546Reviewed-by:
-
Michael Starzinger authored
This removes the support to emit runtime calls in Liftoff code and uses WebAssembly runtime stubs instead. Calls to such stubs are smaller and more efficient. They also use embedded builtins directly instead of the on-heap {Code} object trampolines. This also removes the last use of a runtime call that passes a dynamically loaded CEntry builtin from the macro assembler. R=clemensb@chromium.org Change-Id: I9fa9f3b7a2b66cb76a677b70ce3cee49cb340f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903443 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Clemens Backes authored
A minor optimization to the four bit rotation functions. Drive-by: Make them constexpr. R=ahaas@chromium.org Bug: v8:9810 Change-Id: Ic563310030aa487f976017032291a553705d1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903972Reviewed-by:
-
Clemens Backes authored
This removes dead classes and functions from utils.h. R=sigurds@chromium.org Bug: v8:9810, v8:8912 Change-Id: I8e15600f77b8ccc8ce25b4fd25e6a1b4303ad657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903969 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=jkummerow@chromium.org Notry: true Bug: v8:9810 Change-Id: I3859508de250225b9d8ae322e107079f6dc0c88b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903974 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64852}
-
Clemens Backes authored
{WhichPowerOf2} is basically the same as {CountTrailingZeros}, with a restriction to powers of two. Since it does not use or depend on any v8 internals, it can be moved to src/base/bits.h. This CL also changes the implementation to use the CTZ builtin if available, and falls back to popcnt otherwise. Drive-by: Make it constexpr, and rename to {WhichPowerOfTwo}. R=sigurds@chromium.org Bug: v8:9810, v8:8912 Change-Id: I8368d098f9ab1247f3b9f036f1385a38de10cc6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903966Reviewed-by: -
Clemens Backes authored
This function is trivial, can and be inlined to the single use. This makes utils.h a tiny little bit smaller. R=verwaest@chromium.org Bug: v8:9810, v8:8912 Change-Id: I877f3713530644a1cb9e0f286cf87f55072d33da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903444Reviewed-by:
-
Clemens Backes authored
In streaming compilation, we were computing a way too low code size estimate, since all {WasmFunction::code} fields were still zero when we were calling {EstimateNativeModuleCodeSize}. This lead to many separate code spaces being created during compilation, creating significant performance and memory overhead. This CL fixes this by passing the code section length when creating the {NativeModule}. From this, we can compute the code size estimate just as before. Drive-by: Rename "functions_count" to "num_functions" in {ProcessCodeSectionHeader} to be consistent with the declaration. R=ahaas@chromium.org Bug: v8:9950 Change-Id: I30a54c01ed24d0dfecb8a4b6d123015f1803ddeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903439 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Ulan Degenbaev authored
Now incremental marker and stop-the-world marker use the same visitor, which is derived from MarkingVisitorBase. This removes code duplication and also should reduce binary size. The marking worklist processing code also changes to not color the object black before visiting it. Instead the visitor colors the object black in ShouldVisit method. Bug: chromium:1019218 Change-Id: I57971122f3c77ad2770b6754d696b79d802ef1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901271 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#64848}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6f08017..3cf8d94 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1944f6e..f9004ee Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/23247b9..1917f7a Rolling v8/tools/clang/dsymutil: OWlhXkmj18li3yhJk59Kmjbc5KdgLh56TwCd1qBdzlIC..M56jPzDv1620Rnm__jTMYS62Zi8rxHVq7yw0qeBFEgkC TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie03147c4aaff505fd88c8de6a435db9ae8fdc997 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905106Reviewed-by:
-
- 07 Nov, 2019 8 commits
-
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Ie99fdbf5307a1515a1838ac6902a5bcd99d11e14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900660Reviewed-by:
-
Clemens Backes authored
This makes the {code_size_estimate} computation explicit in the caller, and removes one of the two {NewNativeModule} constructors. It turns out that the calculation is totally off in the streaming calculation phase, since no function bodies have been parsed yet. So all {WasmFunction::code} fields are still empty, and we compute an estimate that is way too low. This CL prepares the actual fix for that (by computing a better estimate at specific call sites). R=ahaas@chromium.org Bug: v8:9950 Change-Id: I68a891c97e5f65a9c7e73e21684bdfa7e261e216 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901273 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Milad Farazmand authored
Change-Id: I145dd2ea5fd2308301ba7e6710f84f276dc70367 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903809Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Change-Id: Ia6b805c48f71cea7a0f0ada06c9a35713ed49f28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903968Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1021712 Change-Id: I9523760f2fa11726dd7015058b2267035f3f9f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903442 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
R=ahaas@chromium.org Bug: v8:9810 Change-Id: I9f6d13445c8c577256cabe070f9082d041af3a2d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903437Reviewed-by:
-
Dominic Farolino authored
This CL fixes the lengths of the console dir() and table() methods to match the WHATWG Console Standard and the IDL WPTs. R=mathias@chromium.org Bug: chromium:948678 Change-Id: I2c603e202a3e5995eec06dadac09807f76ee9167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1902968Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#64840}
-
Hannes Payer authored
Change-Id: I5c6004e77ffdf76679ecf764d3048917f2890b23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903438Reviewed-by:
-
