• Clemens Backes's avatar
    [wasm] Remove one {NewNativeModule} method · dde3166b
    Clemens Backes authored
    This makes the {code_size_estimate} computation explicit in the caller,
    and removes one of the two {NewNativeModule} constructors. It turns out
    that the calculation is totally off in the streaming calculation phase,
    since no function bodies have been parsed yet. So all
    {WasmFunction::code} fields are still empty, and we compute an estimate
    that is way too low.
    This CL prepares the actual fix for that (by computing a better estimate
    at specific call sites).
    
    R=ahaas@chromium.org
    
    Bug: v8:9950
    Change-Id: I68a891c97e5f65a9c7e73e21684bdfa7e261e216
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901273
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64845}
    dde3166b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...