Skip to content

V
V8
Switch branch/tag
  1. 29 Oct, 2018 1 commit
  3. 03 Aug, 2018 1 commit
    • Ben Newman's avatar
      [debug] Fully implement Debug::ArchiveDebug and Debug::RestoreDebug. · a8f68691
      Ben Newman authored 
      I have a project that embeds V8 and uses a single `Isolate` from multiple
threads. The program runs just fine, but sometimes the inspector doesn't
stop on the correct line after stepping over a statement that switches
threads behind the scenes, even though the original thread is restored by
the time the next statement is executed.

After some digging, I discovered that the `Debug::ArchiveDebug` and
`Debug::RestoreDebug` methods, which should be responsible for
saving/restoring this `ThreadLocal` information when switching threads,
currently don't do anything.

This commit implements those methods using MemCopy, in the style of other
Archive/Restore methods in the V8 codebase.

Related: https://groups.google.com/forum/#!topic/v8-users/_Qf2rwljRk8

Note: I believe my employer, Meteor Development Group, has previously
signed the CLA using the group email address google-contrib@meteor.com.

R=yangguo@chromium.org,jgruber@chromium.org
CC=info@bnoordhuis.nl

Bug: v8:7230
Change-Id: Id517c873eb81cd53f7216c7efd441b956cf7f943
Reviewed-on: https://chromium-review.googlesource.com/833260
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54902}
      a8f68691
  5. 18 Oct, 2017 1 commit
  7. 13 Oct, 2017 1 commit
  9. 30 May, 2017 1 commit
  11. 25 Apr, 2017 1 commit
    • ulan's avatar
      Decouple root visitors from object visitors. · e671ed36
      ulan authored 
      This patch adds a new interface called RootVisitor and changes the root
iteration functions to accept a RootVisitor instead of an ObjectVisitor.

Future CLs will change ObjectVisitor to provide the host object to all
visiting functions, which will bring it in sync with static visitors.

Having separate visitors for roots and objects removes ambiguity in
VisitPointers and reduces chances of forgetting to record slots.

This is intended as pure refactoring. All places that require behavior
change are marked with TODO and will addressed in future CLs.

BUG=chromium:709075

Review-Url: https://codereview.chromium.org/2801073006
Cr-Commit-Position: refs/heads/master@{#44852}
      e671ed36
  13. 01 Sep, 2015 1 commit
  15. 20 Aug, 2015 1 commit
  17. 13 Aug, 2015 1 commit
  19. 31 Jul, 2015 1 commit
  21. 08 Dec, 2014 1 commit
  23. 08 Oct, 2014 2 commits
  25. 13 Aug, 2014 1 commit
  27. 04 Aug, 2014 1 commit
  29. 20 Jun, 2014 1 commit
  31. 03 Jun, 2014 1 commit
  33. 09 May, 2014 1 commit
  35. 29 Apr, 2014 1 commit
  37. 25 Apr, 2014 1 commit
  39. 16 Apr, 2014 1 commit
  41. 21 Nov, 2013 1 commit
  43. 27 Sep, 2013 1 commit
  45. 19 Sep, 2013 1 commit
  47. 04 Sep, 2013 2 commits
  49. 03 Sep, 2013 1 commit
  51. 29 Aug, 2013 1 commit
  53. 31 Jul, 2013 1 commit
  55. 30 Jul, 2013 1 commit
  57. 05 Jul, 2013 1 commit
  59. 18 Jan, 2013 1 commit
  61. 02 Jul, 2012 1 commit
  63. 16 Jan, 2012 1 commit
  65. 18 Aug, 2011 1 commit
  67. 08 Aug, 2011 1 commit
  69. 05 Jul, 2011 1 commit
  71. 10 Jun, 2011 3 commits