Skip to content

V
V8
Switch branch/tag
  1. 11 Feb, 2016 1 commit
  3. 10 Feb, 2016 1 commit
  5. 28 Jan, 2016 1 commit
  7. 26 Jan, 2016 1 commit
  9. 21 Jan, 2016 1 commit
  11. 18 Dec, 2015 1 commit
  13. 16 Dec, 2015 2 commits
    • yangguo's avatar
      [debugger] simplify step over recursive function call. · 2bb6e197
      yangguo authored 
      The problem is this: when stepping over a recursive function call,
the recursive function is flooded with one-shot break points so that
we break after the call, but since the callee is the same function,
the callee is also flooded, resulting a break in the callee. That
however would have been a "step in" instead of "step over".

The original solution was to recognize this by comparing FP. If we
end up in Debug::Break, we still have to check the current FP against
the remembered FP to see whether we are on the same stack height.
If we are deeper, then it's not a "step over", and we do not trigger
a debug break event. In that case, we queue up the step-over, and
temporarily step out until we hit the desired stack height. Note that
in order to step out, we flood the caller, which in our example is
the same function as the callee. So we break at every flooded break
location, and comparing with FP to make sure we stepped out prevents
us from triggering debug break events.

The new solution simply ignores breaks when the FP compare fails.
We simply carry on until we hit a break where the FP compare succeeds.
There is no need to do a step out. The number of calls to Debug::Break
that do not trigger a debug break event due to failing FP compare is
the same. But the code is a lot easier to read.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1527253002

Cr-Commit-Position: refs/heads/master@{#32897}
      2bb6e197
    • yangguo's avatar
      [debugger] remove some dead code. · b68f7e4c
      yangguo authored 
      credits to gcov.

R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/1522273003

Cr-Commit-Position: refs/heads/master@{#32877}
      b68f7e4c
  15. 15 Dec, 2015 2 commits
  17. 04 Dec, 2015 3 commits
  19. 03 Dec, 2015 2 commits
  21. 02 Dec, 2015 1 commit
  23. 01 Dec, 2015 1 commit
  25. 27 Nov, 2015 2 commits
  27. 26 Nov, 2015 3 commits
  29. 25 Nov, 2015 2 commits
  31. 19 Nov, 2015 1 commit
  33. 17 Nov, 2015 1 commit
  35. 02 Nov, 2015 1 commit
  37. 23 Oct, 2015 1 commit
  39. 13 Oct, 2015 1 commit
  41. 30 Sep, 2015 2 commits
  43. 28 Sep, 2015 1 commit
  45. 01 Sep, 2015 1 commit
  47. 20 Aug, 2015 1 commit
  49. 14 Aug, 2015 1 commit
  51. 12 Aug, 2015 2 commits
  53. 31 Jul, 2015 1 commit
  55. 27 Jul, 2015 1 commit
    • yangguo's avatar
      Debugger: do not hold onto debug infos weakly. · 48e38e56
      yangguo authored 
      SharedFunctionInfos that have a debug info must not be collected.
Otherwise we lose previously set break points. This means that
there is no need to hold onto debug infos weakly. The reason this
has not caused an issue up till now is that code flushing has been
disabled when the debugger is active.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/1255793003

Cr-Commit-Position: refs/heads/master@{#29869}
      48e38e56
  57. 23 Jul, 2015 1 commit
    • danno's avatar
      Unify "runtime-style" IC functions with Runtime intrinsics · bc8041dc
      danno authored 
      Previous to this CL, ICs used a slightly different code idiom
to get to C++ code from generated code than runtime intrinsics,
using an IC_Utility class that in essence provided exactly
the same functionality as Runtime::FunctionForId, but in its
own quirky way.

This CL unifies the two mechanisms, folding IC_Utility
away by making all IC entry points in C++ code, e.g. IC
miss handlers, full-fledged runtime intrinsics. This makes
it possible to eliminate a bunch of ad-hoc declarations and
adapters that the IC system had to needlessly re-invent.

As a bonus and the original reason for this yak-shave:
IC-related C++ runtime functions are now callable from
TurboFan.

Review URL: https://codereview.chromium.org/1248303002

Cr-Commit-Position: refs/heads/master@{#29811}
      bc8041dc