1. 03 Nov, 2020 1 commit
  2. 02 Nov, 2020 1 commit
  3. 24 Oct, 2020 1 commit
    • Camillo Bruni's avatar
      Reland "[runtime] Use Isolate::ThrowAt with MessageLocation" · 447915ef
      Camillo Bruni authored
      This is a reland of eb6b4ce1
      
      Skip test that serializes Error which references a Script. All errors
      created by ThrowAt store the current Script under the
      error_script_symbol.
      
      Original change's description:
      > [runtime] Use Isolate::ThrowAt with MessageLocation
      >
      > Fix various missing source positions when reporting parse and compile
      > errors. Namely this fixes missing source positions when having invalid
      > module imports.
      >
      > - Use Isolate::ThrowAt with valid MessageLocation objects
      > - Change public Isolate::Throw to no longer accept MessageLocation to
      >   avoid misues
      > - Introduce private Isolate::ThrowInternal that accepts MessageLocation
      >
      > Bug: v8:6513
      > Change-Id: I3ee633c9fff8c9d361bddb37f56e28a50c280ec1
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467839
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Marja Hölttä <marja@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#70623}
      
      Bug: v8:6513
      Change-Id: Icba74f74178e28fbda0fd0c237eeb7bacbc33570
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487123Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70741}
      447915ef
  4. 19 Oct, 2020 2 commits
  5. 22 Jul, 2020 1 commit
  6. 04 Feb, 2020 1 commit
  7. 24 Jan, 2020 1 commit
  8. 22 Jan, 2020 2 commits
  9. 17 Jan, 2020 1 commit
  10. 16 Jan, 2020 1 commit
  11. 05 Dec, 2019 1 commit
  12. 29 Nov, 2019 3 commits
    • Sigurd Schneider's avatar
      Reland "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · b9df6e1c
      Sigurd Schneider authored
      This is a reland of 4ed9d48f
      
      CompileRun leads to undefined behavior if the compile fails;
      CompileRunChecked can be used to assert that the compile must
      succeed. I've removed the attempt to compile and rely on a
      simpler check in the tests now.
      
      Original change's description:
      > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
      >
      > This CL changes InvokeWithTryCatch to not re-request the terminate
      > execution interrupt, but instead schedule the termination exception.
      > This ensures that leaving the outermost TryCatch scope will clear
      > the exception, and no interrupt remains.
      >
      > Previously, the interrupt request could remain and prevent further
      > JavaScript execution even after the TryCatch scope was left.
      >
      > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      > Bug: chromium:1014415
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65255}
      
      Tbr: yangguo@chromium.org, verwaest@chromium.org
      Bug: chromium:1014415
      Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65258}
      b9df6e1c
    • Leszek Swirski's avatar
      Revert "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · 48367856
      Leszek Swirski authored
      This reverts commit 4ed9d48f.
      
      Reason for revert: UBSan failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/9084
      
      Original change's description:
      > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
      > 
      > This CL changes InvokeWithTryCatch to not re-request the terminate
      > execution interrupt, but instead schedule the termination exception.
      > This ensures that leaving the outermost TryCatch scope will clear
      > the exception, and no interrupt remains.
      > 
      > Previously, the interrupt request could remain and prevent further
      > JavaScript execution even after the TryCatch scope was left.
      > 
      > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      > Bug: chromium:1014415
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65255}
      
      TBR=yangguo@chromium.org,sigurds@chromium.org,verwaest@chromium.org
      
      Change-Id: Iedefe5320d8bdc442a87e03698a20daf6a0ebf4f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1014415
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943149Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65256}
      48367856
    • Sigurd Schneider's avatar
      [exceptions] Don't re-request interrupt in InvokeWithTryCatch · 4ed9d48f
      Sigurd Schneider authored
      This CL changes InvokeWithTryCatch to not re-request the terminate
      execution interrupt, but instead schedule the termination exception.
      This ensures that leaving the outermost TryCatch scope will clear
      the exception, and no interrupt remains.
      
      Previously, the interrupt request could remain and prevent further
      JavaScript execution even after the TryCatch scope was left.
      
      Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      Bug: chromium:1014415
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65255}
      4ed9d48f
  13. 12 Jul, 2019 1 commit
  14. 28 Jun, 2019 1 commit
  15. 27 Jun, 2019 1 commit
  16. 13 Jun, 2019 2 commits
  17. 06 Jun, 2019 1 commit
  18. 27 May, 2019 1 commit
  19. 23 May, 2019 1 commit
  20. 22 May, 2019 1 commit
  21. 21 May, 2019 1 commit
  22. 17 May, 2019 1 commit
  23. 16 May, 2019 3 commits
  24. 07 May, 2019 1 commit
  25. 17 Apr, 2019 2 commits
    • Clemens Hammacher's avatar
      Reland "[wasm] Add stack guard for logging code" · 48635511
      Clemens Hammacher authored
      This is a reland of 067ba2a0.
      Unchanged reland, hence TBR.
      
      Original change's description:
      > [wasm] Add stack guard for logging code
      >
      > Benchmarks or worker threads might never return to the event queue,
      > hence they will never execute the scheduled foreground task to log
      > compiled and published wasm code.
      > This CL adds a stack guard to log the code, to ensure that we also log
      > it for wasm code that never returns to the event queue.
      >
      > R=mstarzinger@chromium.org
      >
      > Bug: v8:9104
      > Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60879}
      
      TBR=mstarzinger@chromium.org
      
      Bug: v8:9104
      Change-Id: I105b37ef8429d16ef5b983919ba8bca615e347c0
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570017Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60899}
      48635511
    • Michael Hablich's avatar
      Revert "[wasm] Add stack guard for logging code" · 6ce63fd8
      Michael Hablich authored
      This reverts commit 067ba2a0.
      
      Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1570208
      
      21:26:22.251 27507   # Fatal error in ../../v8/src/profiler/profile-generator.cc, line 19
      21:26:22.251 27507   # Debug check failed: line > 0 (0 vs. 0).
      21:26:22.251 27507   #
      21:26:22.251 27507   #
      21:26:22.251 27507   #
      21:26:22.252 27507   #FailureMessage Object: 0x7ffe851046a0#0 0x56532cb371f9 base::debug::CollectStackTrace()
      21:26:22.252 27507   #1 0x56532ca70863 base::debug::StackTrace::StackTrace()
      21:26:22.252 27507   #2 0x56532e99610b gin::(anonymous namespace)::PrintStackTrace()
      21:26:22.252 27507   #3 0x56532e989468 V8_Fatal()
      21:26:22.252 27507   #4 0x56532e9891c5 v8::base::(anonymous namespace)::DefaultDcheckHandler()
      21:26:22.252 27507   #5 0x56532b2bb876 v8::internal::SourcePositionTable::SetPosition()
      21:26:22.252 27507   #6 0x56532b2c2268 v8::internal::ProfilerListener::CodeCreateEvent()
      21:26:22.252 27507   #7 0x56532ae25275 v8::internal::(anonymous namespace)::LogFunctionCompilation()
      21:26:22.252 27507   #8 0x56532ae26008 v8::internal::OptimizedCompilationJob::RecordFunctionCompilation()
      21:26:22.252 27507   #9 0x56532ae32a08 v8::internal::Compiler::FinalizeOptimizedCompilationJob()
      21:26:22.252 27507   #10 0x56532ae228eb v8::internal::OptimizingCompileDispatcher::InstallOptimizedFunctions()
      21:26:22.252 27507   #11 0x56532af14e4a v8::internal::StackGuard::HandleInterrupts()
      21:26:22.252 27507   #12 0x56532b35f2ec v8::internal::__RT_impl_Runtime_StackGuard()
      21:26:22.252 27507   #13 0x56532bba6720 <unknown>
      
      Original change's description:
      > [wasm] Add stack guard for logging code
      > 
      > Benchmarks or worker threads might never return to the event queue,
      > hence they will never execute the scheduled foreground task to log
      > compiled and published wasm code.
      > This CL adds a stack guard to log the code, to ensure that we also log
      > it for wasm code that never returns to the event queue.
      > 
      > R=​mstarzinger@chromium.org
      > 
      > Bug: v8:9104
      > Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60879}
      
      TBR=mstarzinger@chromium.org,clemensh@chromium.org
      
      Change-Id: I63dc56a41747caf683b14869a2d62017fd0301c1
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:9104
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570012Reviewed-by: 's avatarMichael Hablich <hablich@chromium.org>
      Commit-Queue: Michael Hablich <hablich@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60890}
      6ce63fd8
  26. 16 Apr, 2019 1 commit
  27. 25 Mar, 2019 1 commit
    • Benedikt Meurer's avatar
      [tracing] Properly trace stack guards and interrupts. · b8490293
      Benedikt Meurer authored
      Add tracing support for the %StackGuard() and %Interrupt() runtime calls
      and the individual actions performed in StackGuard::HandleInterrupts().
      This includes:
      
       - "V8.GCHandleGCRequest" (in "disabled-by-default-v8.gc") when the
         GC_REQUEST bit is set.
       - "V8.WasmGrowSharedMemory" (in "disabled-by-default-v8.wasm") when
         the GROW_SHARED_MEMORY bit is set.
       - "V8.TerminateExecution" (in "v8.execute") when the
         TERMINATE_EXECUTION bit is set.
       - "V8.GCDeoptMarkedAllocationSites" (in "disabled-by-default-v8.gc")
         when the DEOPT_MARKED_ALLOCATION_SITES bit is set.
       - "V8.InstallOptimizedFunctions" (in "disabled-by-default-v8.compile")
         when the INSTALL_CODE bit is set.
       - "V8.InvokeApiInterruptCallbacks" (in "v8.execute") when the
         API_INTERRUPT bit is set.
      
      Now we also emit a trace event "V8.MarkCandidatesForOptimization" (in
      "disabled-by-default-v8.compile") in addition to the above from the
      RuntimeProfiler when we mark candidates for optimization at the end
      of each stack check.
      
      An example of the "V8.InstallOptimizedFunctions" in action (in the
      trace viewer) can be seen here:
      
        https://i.paste.pics/094a04af035eedc0690cd4079afa28f1.png
      
      This supersedes the previously introduced --trace-interrupts CLI flag,
      which is thus removed as part of this change.
      
      Bug: v8:8598
      Change-Id: I3c3375d00b07cbe700b6912097d7264031ace802
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538116
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60428}
      b8490293
  28. 06 Mar, 2019 3 commits
    • Deepti Gandluri's avatar
      Reland "[wasm] Lazy update instances on a shared Memory.Grow" · 365b637c
      Deepti Gandluri authored
      This is a reland of 80f06d6f
      
      Original change's description:
      > [wasm] Lazy update instances on a shared Memory.Grow
      > 
      >  - Introduce a GROW_SHARED_MEMORY interrupt, and handler
      >  - Memory objects for isolates are updated on a stack check, add
      >    tracking for isolates that hit the stack check
      >  - When enough memory is not reserved ahead of time, fail to grow
      >  - Add tracking for externalized buffers in the MemoryTracker so
      >    that the MemoryTracker will know when backing_stores can be freed.
      >  - For shared buffer, do not always allocate a new buffer when
      >    growing an externalized buffer
      > 
      > 
      > Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4
      > Bug: v8:8564
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430
      > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      > Reviewed-by: Ben Smith <binji@chromium.org>
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60064}
      
      Bug: v8:8564
      Change-Id: Id0cf8e42a9d54ac702dba351e248a1b92713c98a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506357Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60071}
      365b637c
    • Bill Budge's avatar
      Revert "[wasm] Lazy update instances on a shared Memory.Grow" · e15bb0b3
      Bill Budge authored
      This reverts commit 80f06d6f.
      
      Reason for revert: failing grow-memory tests
      
      Original change's description:
      > [wasm] Lazy update instances on a shared Memory.Grow
      > 
      >  - Introduce a GROW_SHARED_MEMORY interrupt, and handler
      >  - Memory objects for isolates are updated on a stack check, add
      >    tracking for isolates that hit the stack check
      >  - When enough memory is not reserved ahead of time, fail to grow
      >  - Add tracking for externalized buffers in the MemoryTracker so
      >    that the MemoryTracker will know when backing_stores can be freed.
      >  - For shared buffer, do not always allocate a new buffer when
      >    growing an externalized buffer
      > 
      > 
      > Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4
      > Bug: v8:8564
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430
      > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      > Reviewed-by: Ben Smith <binji@chromium.org>
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60064}
      
      TBR=binji@chromium.org,titzer@chromium.org,gdeepti@chromium.org,ahaas@chromium.org
      
      Change-Id: I2ed0b59bcbb285b701172b401d606963261d375c
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8564
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506355Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60068}
      e15bb0b3
    • Deepti Gandluri's avatar
      [wasm] Lazy update instances on a shared Memory.Grow · 80f06d6f
      Deepti Gandluri authored
       - Introduce a GROW_SHARED_MEMORY interrupt, and handler
       - Memory objects for isolates are updated on a stack check, add
         tracking for isolates that hit the stack check
       - When enough memory is not reserved ahead of time, fail to grow
       - Add tracking for externalized buffers in the MemoryTracker so
         that the MemoryTracker will know when backing_stores can be freed.
       - For shared buffer, do not always allocate a new buffer when
         growing an externalized buffer
      
      
      Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4
      Bug: v8:8564
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430
      Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
      Reviewed-by: 's avatarBen Smith <binji@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60064}
      80f06d6f
  29. 04 Mar, 2019 1 commit
  30. 04 Feb, 2019 1 commit