Revert "[wasm] Add stack guard for logging code"

This reverts commit 067ba2a0.

Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1570208

21:26:22.251 27507   # Fatal error in ../../v8/src/profiler/profile-generator.cc, line 19
21:26:22.251 27507   # Debug check failed: line > 0 (0 vs. 0).
21:26:22.251 27507   #
21:26:22.251 27507   #
21:26:22.251 27507   #
21:26:22.252 27507   #FailureMessage Object: 0x7ffe851046a0#0 0x56532cb371f9 base::debug::CollectStackTrace()
21:26:22.252 27507   #1 0x56532ca70863 base::debug::StackTrace::StackTrace()
21:26:22.252 27507   #2 0x56532e99610b gin::(anonymous namespace)::PrintStackTrace()
21:26:22.252 27507   #3 0x56532e989468 V8_Fatal()
21:26:22.252 27507   #4 0x56532e9891c5 v8::base::(anonymous namespace)::DefaultDcheckHandler()
21:26:22.252 27507   #5 0x56532b2bb876 v8::internal::SourcePositionTable::SetPosition()
21:26:22.252 27507   #6 0x56532b2c2268 v8::internal::ProfilerListener::CodeCreateEvent()
21:26:22.252 27507   #7 0x56532ae25275 v8::internal::(anonymous namespace)::LogFunctionCompilation()
21:26:22.252 27507   #8 0x56532ae26008 v8::internal::OptimizedCompilationJob::RecordFunctionCompilation()
21:26:22.252 27507   #9 0x56532ae32a08 v8::internal::Compiler::FinalizeOptimizedCompilationJob()
21:26:22.252 27507   #10 0x56532ae228eb v8::internal::OptimizingCompileDispatcher::InstallOptimizedFunctions()
21:26:22.252 27507   #11 0x56532af14e4a v8::internal::StackGuard::HandleInterrupts()
21:26:22.252 27507   #12 0x56532b35f2ec v8::internal::__RT_impl_Runtime_StackGuard()
21:26:22.252 27507   #13 0x56532bba6720 <unknown>

Original change's description:
> [wasm] Add stack guard for logging code
> 
> Benchmarks or worker threads might never return to the event queue,
> hence they will never execute the scheduled foreground task to log
> compiled and published wasm code.
> This CL adds a stack guard to log the code, to ensure that we also log
> it for wasm code that never returns to the event queue.
> 
> R=​mstarzinger@chromium.org
> 
> Bug: v8:9104
> Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60879}

TBR=mstarzinger@chromium.org,clemensh@chromium.org

Change-Id: I63dc56a41747caf683b14869a2d62017fd0301c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9104
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570012Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60890}

src/execution.cc

@@ -11,7 +11,6 @@
 #include "src/isolate-inl.h"
 #include "src/runtime-profiler.h"
 #include "src/vm-state-inl.h"
-#include "src/wasm/wasm-engine.h"
 
 namespace v8 {
 namespace internal {
@@ -656,15 +655,10 @@ Object StackGuard::HandleInterrupts() {
 
   if (CheckAndClearInterrupt(API_INTERRUPT)) {
     TRACE_EVENT0("v8.execute", "V8.InvokeApiInterruptCallbacks");
-    // Callbacks must be invoked outside of ExecutionAccess lock.
+    // Callbacks must be invoked outside of ExecusionAccess lock.
     isolate_->InvokeApiInterruptCallbacks();
   }
 
-  if (CheckAndClearInterrupt(LOG_WASM_CODE)) {
-    TRACE_EVENT0("v8.wasm", "LogCode");
-    isolate_->wasm_engine()->LogOutstandingCodesForIsolate(isolate_);
-  }
-
   isolate_->counters()->stack_interrupts()->Increment();
   isolate_->counters()->runtime_profiler_ticks()->Increment();
   isolate_->runtime_profiler()->MarkCandidatesForOptimization();

src/execution.h

@@ -96,8 +96,7 @@ class V8_EXPORT_PRIVATE StackGuard final {
   V(INSTALL_CODE, InstallCode, 2)                                 \
   V(API_INTERRUPT, ApiInterrupt, 3)                               \
   V(DEOPT_MARKED_ALLOCATION_SITES, DeoptMarkedAllocationSites, 4) \
-  V(GROW_SHARED_MEMORY, GrowSharedMemory, 5)                      \
-  V(LOG_WASM_CODE, LogWasmCode, 6)
+  V(GROW_SHARED_MEMORY, GrowSharedMemory, 5)
 
 #define V(NAME, Name, id)                                                    \
   inline bool Check##Name() { return CheckInterrupt(NAME); }                 \

src/wasm/wasm-engine.cc

@@ -548,7 +548,6 @@ void WasmEngine::LogCode(WasmCode* code) {
           &mutex_, &info->log_codes_task, isolate, this);
       info->log_codes_task = new_task.get();
       info->foreground_task_runner->PostTask(std::move(new_task));
-      isolate->stack_guard()->RequestLogWasmCode();
     }
     info->code_to_log.push_back(code);
     code->IncRef();
@@ -566,19 +565,15 @@ void WasmEngine::LogOutstandingCodesForIsolate(Isolate* isolate) {
   // If by now we should not log code any more, do not log it.
   if (!WasmCode::ShouldBeLogged(isolate)) return;
 
-  // Under the mutex, get the vector of wasm code to log. Then log and decrement
-  // the ref count without holding the mutex.
-  std::vector<WasmCode*> code_to_log;
-  {
-    base::MutexGuard guard(&mutex_);
-    DCHECK_EQ(1, isolates_.count(isolate));
-    code_to_log.swap(isolates_[isolate]->code_to_log);
-  }
-  if (code_to_log.empty()) return;
-  for (WasmCode* code : code_to_log) {
+  base::MutexGuard guard(&mutex_);
+  DCHECK_EQ(1, isolates_.count(isolate));
+  IsolateInfo* info = isolates_[isolate].get();
+  if (info->code_to_log.empty()) return;
+  for (WasmCode* code : info->code_to_log) {
     code->LogCode(isolate);
   }
-  WasmCode::DecrementRefCount(VectorOf(code_to_log));
+  WasmCode::DecrementRefCount(VectorOf(info->code_to_log));
+  info->code_to_log.clear();
 }
 
 std::shared_ptr<NativeModule> WasmEngine::NewNativeModule(

test/inspector/inspector.status

@@ -14,6 +14,9 @@
 
   # Bad OOM timing on noembed builds (https://crbug.com/v8/8494).
   'debugger/pause-on-oom': [PASS, ['embedded_builtins == False', SKIP]],
+
+  # https://crbug.com/v8/9104
+  'cpu-profiler/console-profile-wasm': [SKIP],
 }],  # ALWAYS
 
 ##############################################################################