Skip to content

V
V8
Switch branch/tag
  1. 17 Jun, 2021 1 commit
  3. 15 Jun, 2021 1 commit
  5. 01 Jun, 2021 1 commit
  7. 31 May, 2021 1 commit
  9. 18 May, 2021 3 commits
  11. 06 May, 2021 1 commit
  13. 23 Apr, 2021 1 commit
  15. 08 Apr, 2021 2 commits
  17. 19 Mar, 2021 1 commit
  19. 15 Mar, 2021 1 commit
  21. 18 Feb, 2021 1 commit
  23. 11 Feb, 2021 1 commit
  25. 10 Feb, 2021 1 commit
    • Daniel Clark's avatar
      Fix top-level await crash from synthetic module being evaluated twice · f033e2a1
      Daniel Clark authored 
      With top-level await, when Evaluate is performed on an already-evaluated
synthetic module, Module::InnerEvaluate returns undefined.  This breaks
top-level await's assumption that the returned value is always a
promise.

In order to make SyntheticModule's behavior consistent with
SourceTextModule, the top_level_capability field is moved up to Module
and SyntheticModule::Evaluate places the promise returned from the
host's evaluation steps in that field.  Now SourceTextModule and
SyntheticModule can share the same code to handle the case where the
module is either kErrored or kEvaluated, so the code for this
is moved up to Module.

Thus, SyntheticModule is now guaranteed to return the
promise from the evaluation steps even on subsequent Evaluate() calls.

Unfortunately Node hasn't yet updated their EvaluationStepsCallback
to return a Promise, so we can't yet assume that the returned value
is a Promise without breaking Node.  So, this change also adds a clause
to check for this condition and create a new resolved Promise if one
was not provided by the callback steps.  This could eventually be
removed once Node's callback steps are updated for top-level await.

Change-Id: I2d6ae918abfeba9e3a757838502d4df92946edaa
Bug: v8:11398
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673794Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#72629}
      f033e2a1
  27. 04 Feb, 2021 1 commit
  29. 03 Feb, 2021 1 commit
  31. 26 Jan, 2021 3 commits
  33. 21 Jan, 2021 1 commit
  35. 24 Nov, 2020 1 commit
  37. 19 Nov, 2020 1 commit
  39. 12 Nov, 2020 2 commits
  41. 03 Nov, 2020 1 commit
  43. 29 Oct, 2020 1 commit
  45. 26 Oct, 2020 1 commit
  47. 24 Oct, 2020 1 commit
    • Camillo Bruni's avatar
      Reland "[runtime] Use Isolate::ThrowAt with MessageLocation" · 447915ef
      Camillo Bruni authored 
      This is a reland of eb6b4ce1

Skip test that serializes Error which references a Script. All errors
created by ThrowAt store the current Script under the
error_script_symbol.

Original change's description:
> [runtime] Use Isolate::ThrowAt with MessageLocation
>
> Fix various missing source positions when reporting parse and compile
> errors. Namely this fixes missing source positions when having invalid
> module imports.
>
> - Use Isolate::ThrowAt with valid MessageLocation objects
> - Change public Isolate::Throw to no longer accept MessageLocation to
>   avoid misues
> - Introduce private Isolate::ThrowInternal that accepts MessageLocation
>
> Bug: v8:6513
> Change-Id: I3ee633c9fff8c9d361bddb37f56e28a50c280ec1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467839
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70623}

Bug: v8:6513
Change-Id: Icba74f74178e28fbda0fd0c237eeb7bacbc33570
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487123Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70741}
      447915ef
  49. 28 Sep, 2020 1 commit
  51. 25 Sep, 2020 1 commit
  53. 22 Sep, 2020 1 commit
  55. 13 Aug, 2020 1 commit
  57. 10 Aug, 2020 1 commit
  59. 06 Aug, 2020 3 commits
  61. 27 Jul, 2020 1 commit
  63. 21 Jul, 2020 1 commit