1. 19 Feb, 2019 1 commit
  2. 08 Jan, 2019 1 commit
  3. 07 Jan, 2019 1 commit
  4. 20 Dec, 2018 1 commit
  5. 11 Dec, 2018 1 commit
  6. 11 Oct, 2018 1 commit
  7. 19 Dec, 2017 1 commit
  8. 10 Dec, 2017 1 commit
  9. 18 Oct, 2017 1 commit
  10. 02 Aug, 2017 1 commit
  11. 20 Jun, 2017 1 commit
  12. 16 Aug, 2016 1 commit
    • jkummerow's avatar
      [js2c] Fix ordering issue of TextMacro expansion · 95db63ab
      jkummerow authored
      If a key is a substring of an earlier value, then the earlier value
      will unintentionally be clobbered. For example with:
        macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val);
        SET_PRIVATE(iterator, arrayIteratorObjectSymbol, object);
      if the mapping is:
        {'val': 'object',
         'obj': 'iterator',
         'sym': 'arrayIteratorObjectSymbol'}
      then 'obj' -> 'iterator' will clobber 'val' -> 'object', resulting in
      'val' -> 'iteratorect'. To fix this, replace all substitutions
      simultaneously.
      
      Patch from Zoe Clifford <zoeclifford@google.com>
      
      Review-Url: https://codereview.chromium.org/2249873004
      Cr-Commit-Position: refs/heads/master@{#38665}
      95db63ab
  13. 05 Nov, 2015 2 commits
  14. 04 Nov, 2015 5 commits
  15. 03 Nov, 2015 2 commits
  16. 02 Nov, 2015 1 commit
  17. 14 Oct, 2015 1 commit
    • domenic's avatar
      Put experimental extras through the same filters as non-experimental · 0db37104
      domenic authored
      When introducing experimental extras I forgot to update this check. That resulted in experimental extras running through the steps normally reserved for non-extra natives: macro and constant expansion, validation, and minification. This causes problems since per the linked bug minification is buggy.
      
      R=yangguo@chromium.org, jochen@chromium.org
      BUG=v8:4064
      LOG=N
      
      Review URL: https://codereview.chromium.org/1400253002
      
      Cr-Commit-Position: refs/heads/master@{#31270}
      0db37104
  18. 25 Sep, 2015 1 commit
  19. 08 Sep, 2015 1 commit
    • vogelheim's avatar
      Remove all gyp BUILD rules with multiple outputs. · 244cc0a6
      vogelheim authored
      - Modify js2c to accept --js and --nojs,
      - modify mksnapshot to accept --startup_src
        (instead of a positional parameter, so that it can be omitted),
      - modify v8.gyp to use the above so that no target has multiple
        output dependencies, and
      - update GN to use the switches above.
      
      (I have not succeeded in fixing the GYP->make translator to properly map
       multi-output rules, so that they work as expected in all edge cases.
       This CL signals defeat on that front, and instead I rewrite the GYP
       file to avoid that situation in the first place.)
      
      R=jochen@chromium.org
      BUG=v8:4382
      LOG=N
      
      Review URL: https://codereview.chromium.org/1310273009
      
      Cr-Commit-Position: refs/heads/master@{#30640}
      244cc0a6
  20. 07 Sep, 2015 1 commit
  21. 31 Jul, 2015 1 commit
  22. 17 Jul, 2015 1 commit
  23. 22 Jun, 2015 1 commit
  24. 15 May, 2015 1 commit
  25. 11 May, 2015 1 commit
  26. 08 May, 2015 1 commit
    • domenic's avatar
      Re-land: Make V8 extras a separate type of native · 570fca61
      domenic authored
      Instead of making them an extra option that gets passed in and compiled
      at the end of the natives file for a given run of js2c, we now make them a
      separate run of js2c with a separate natives file output.
      
      This natives file output is then compiled in the bootstrapper. It is not part
      of the snapshot (yet), but instead is treated similar to the experimental
      natives, just without any of the complexity that comes from tieing the
      behavior to flags. We also don't need counterparts to
      InitializeExperimentalGlobal and InstallExperimentalNativeFunctions (yet?).
      
      This fixes the issue with https://codereview.chromium.org/1129743003 by making
      the dummy file that is generated for snapshots with no extras (or no experimental
      features) nonempty.
      
      R=yangguo@chromium.org, jochen@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1130993003
      
      Cr-Commit-Position: refs/heads/master@{#28311}
      570fca61
  27. 07 May, 2015 2 commits
    • domenic's avatar
      Revert of Make V8 extras a separate type of native (patchset #4 id:60001 of... · 010c515d
      domenic authored
      Revert of Make V8 extras a separate type of native (patchset #4 id:60001 of https://codereview.chromium.org/1129743003/)
      
      Reason for revert:
      https://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2745
      
      Original issue's description:
      > Make V8 extras a separate type of native
      >
      > Instead of making them an extra option that gets passed in and compiled
      > at the end of the natives file for a given run of js2c, we now make them a
      > separate run of js2c with a separate natives file output.
      >
      > This natives file output is then compiled in the bootstrapper. It is not part
      > of the snapshot (yet), but instead is treated similar to the experimental
      > natives, just without any of the complexity that comes from tieing the
      > behavior to flags. We also don't add counterparts to
      > InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet.
      >
      > R=yangguo@chromium.org, jochen@chromium.org
      > BUG=
      >
      > Committed: https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902
      > Cr-Commit-Position: refs/heads/master@{#28296}
      
      TBR=jochen@chromium.org,yangguo@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=
      
      Review URL: https://codereview.chromium.org/1131903002
      
      Cr-Commit-Position: refs/heads/master@{#28299}
      010c515d
    • domenic's avatar
      Make V8 extras a separate type of native · c93aff4a
      domenic authored
      Instead of making them an extra option that gets passed in and compiled
      at the end of the natives file for a given run of js2c, we now make them a
      separate run of js2c with a separate natives file output.
      
      This natives file output is then compiled in the bootstrapper. It is not part
      of the snapshot (yet), but instead is treated similar to the experimental
      natives, just without any of the complexity that comes from tieing the
      behavior to flags. We also don't add counterparts to
      InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet.
      
      R=yangguo@chromium.org, jochen@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1129743003
      
      Cr-Commit-Position: refs/heads/master@{#28296}
      c93aff4a
  28. 30 Apr, 2015 1 commit
  29. 29 Apr, 2015 1 commit
    • domenic's avatar
      Don't run macros or jsmin on extra snapshot scripts · 8e2e83f0
      domenic authored
      js2c.py now distinguishes between the JS internal sources and any
      extra scripts passed in. The latter only get validation and
      comment/trailing whitespace removal applied now.
      
      Also added a --js option to js2c.py, which will output a JS file
      instead of a C++ file, for debugging. (I got tired of finding the
      generated .cc file and extracting its byte array so that I could feed
      it to a separate helper script I wrote.)
      
      R=yangguo@chromium.org, jochen@chromium.org
      BUG=v8:4064
      LOG=N
      
      Review URL: https://codereview.chromium.org/1117663002
      
      Cr-Commit-Position: refs/heads/master@{#28133}
      8e2e83f0
  30. 28 Apr, 2015 2 commits
  31. 27 Apr, 2015 1 commit
  32. 24 Apr, 2015 1 commit