- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 08 Jan, 2019 1 commit
-
-
peterwmwong authored
- Remove macros.py - Inlines macros into d8.js - Remove dead code (macros and message templates) from js2c.py - Remove empty src/js directory Bug: v8:7624 Change-Id: I8dfb69f2f8cb3746b67de816ffc8eb305cbcdee6 Reviewed-on: https://chromium-review.googlesource.com/c/1400150 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58631}
-
- 07 Jan, 2019 1 commit
-
-
peterwmwong authored
- Removes build step and bootstrapping associated with building/loading `EXPERIMENTAL_EXTRAS` JS natives. - Removes `--experimental-extras` flag Bug: v8:7624 Change-Id: I4c45fe70da42847545037d63e9f1da77f5957f8b Reviewed-on: https://chromium-review.googlesource.com/c/1397906Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#58590}
-
- 20 Dec, 2018 1 commit
-
-
Jakob Gruber authored
V8 is almost completely JS-free. There's no need to ship the minifier any more. Bug: v8:7624,v8:5505,v8:4240,v8:4235,v8:4188,v8:1557 Change-Id: Iee15bf68c66bac27a67fe70e10b1edd4dcef89d1 Reviewed-on: https://chromium-review.googlesource.com/c/1386146Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58392}
-
- 11 Dec, 2018 1 commit
-
-
Yang Guo authored
We no longer implement part of the debugger in JS. Therefore we can remove the infrastructure to support this in the bootstrapper. Also includes some drive-by cleanups. Bug: v8:5530 R=petermarshall@chromium.org Change-Id: I06628a559c17f99c70029fcc94848b0c78f1d3e9 Reviewed-on: https://chromium-review.googlesource.com/c/1369945 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58140}
-
- 11 Oct, 2018 1 commit
-
-
Jakob Kummerow authored
The primary purpose of this is to untangle a circular dependency objects.h -> handles.h -> objects.h. Most compilation units only need message-template.h, without the rest of messages.h. Bonus: change the enum to an enum class for improved type safety. Bug: v8:3770 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8102c55197a450811de2588a68a08e7f99ea6b9e Reviewed-on: https://chromium-review.googlesource.com/c/1272193 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56583}
-
- 19 Dec, 2017 1 commit
-
-
marcin authored
Patch will decrease size of JS files included into Chrome APK (about 11 KB now) Bug: Change-Id: I701c9904fbf22fd295199f255601dea6524a3766 Reviewed-on: https://chromium-review.googlesource.com/821071Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#50179}
-
- 10 Dec, 2017 1 commit
-
-
Mikhail Gusarov authored
If the source checkout had 'debug' somewhere in the path name, then IsDebuggerFile() marked all modules as debug ones, which triggered an assertion during snapshot generation. Bug: Change-Id: I93537efca9152c5469bb760f32ca53b06351f7a4 Reviewed-on: https://chromium-review.googlesource.com/809205Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49980}
-
- 18 Oct, 2017 1 commit
-
-
Camillo Bruni authored
Change-Id: I82782f170c48dbe3f853dc04ec7e07e3968583f3 Reviewed-on: https://chromium-review.googlesource.com/724183Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48698}
-
- 02 Aug, 2017 1 commit
-
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 20 Jun, 2017 1 commit
-
-
Adam Klein authored
Also remove support for "python macros" as the last existing one is removed in this patch. Change-Id: I537d604a0a1c9ca11cd5c195841b9f5a0ec74850 Reviewed-on: https://chromium-review.googlesource.com/540836 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46069}
-
- 16 Aug, 2016 1 commit
-
-
jkummerow authored
If a key is a substring of an earlier value, then the earlier value will unintentionally be clobbered. For example with: macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val); SET_PRIVATE(iterator, arrayIteratorObjectSymbol, object); if the mapping is: {'val': 'object', 'obj': 'iterator', 'sym': 'arrayIteratorObjectSymbol'} then 'obj' -> 'iterator' will clobber 'val' -> 'object', resulting in 'val' -> 'iteratorect'. To fix this, replace all substitutions simultaneously. Patch from Zoe Clifford <zoeclifford@google.com> Review-Url: https://codereview.chromium.org/2249873004 Cr-Commit-Position: refs/heads/master@{#38665}
-
- 05 Nov, 2015 2 commits
-
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 Cr-Commit-Position: refs/heads/master@{#31773} Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 Cr-Commit-Position: refs/heads/master@{#31782} Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc Cr-Commit-Position: refs/heads/master@{#31804} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31824}
-
yangguo authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: browser_tests failure with --gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} > > Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc > Cr-Commit-Position: refs/heads/master@{#31804} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1426413002 Cr-Commit-Position: refs/heads/master@{#31818}
-
- 04 Nov, 2015 5 commits
-
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 Cr-Commit-Position: refs/heads/master@{#31773} Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 Cr-Commit-Position: refs/heads/master@{#31782} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31804}
-
hablich authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: Breaks Chromium tests and blocks the roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/124490 Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1432683002 Cr-Commit-Position: refs/heads/master@{#31801}
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 Cr-Commit-Position: refs/heads/master@{#31773} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31782}
-
yangguo authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #3 id:50001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: Performance issue. Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1409013006 Cr-Commit-Position: refs/heads/master@{#31780}
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 Cr-Commit-Position: refs/heads/master@{#31753} Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31773}
-
- 03 Nov, 2015 2 commits
-
-
machenbach authored
Revert of Implement flag and source getters on RegExp.prototype. (patchset #3 id:50001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: [Sheriff] Changes layout tests. Please rebase upstream first. E.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2686 Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Review URL: https://codereview.chromium.org/1427733005 Cr-Commit-Position: refs/heads/master@{#31758}
-
yangguo authored
R=littledan@chromium.org BUG=v8:3715, v8:4528 LOG=Y Review URL: https://codereview.chromium.org/1419823010 Cr-Commit-Position: refs/heads/master@{#31753}
-
- 02 Nov, 2015 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1425333002 Cr-Commit-Position: refs/heads/master@{#31710}
-
- 14 Oct, 2015 1 commit
-
-
domenic authored
When introducing experimental extras I forgot to update this check. That resulted in experimental extras running through the steps normally reserved for non-extra natives: macro and constant expansion, validation, and minification. This causes problems since per the linked bug minification is buggy. R=yangguo@chromium.org, jochen@chromium.org BUG=v8:4064 LOG=N Review URL: https://codereview.chromium.org/1400253002 Cr-Commit-Position: refs/heads/master@{#31270}
-
- 25 Sep, 2015 1 commit
-
-
ben authored
Review URL: https://codereview.chromium.org/1359033002 Cr-Commit-Position: refs/heads/master@{#30941}
-
- 08 Sep, 2015 1 commit
-
-
vogelheim authored
- Modify js2c to accept --js and --nojs, - modify mksnapshot to accept --startup_src (instead of a positional parameter, so that it can be omitted), - modify v8.gyp to use the above so that no target has multiple output dependencies, and - update GN to use the switches above. (I have not succeeded in fixing the GYP->make translator to properly map multi-output rules, so that they work as expected in all edge cases. This CL signals defeat on that front, and instead I rewrite the GYP file to avoid that situation in the first place.) R=jochen@chromium.org BUG=v8:4382 LOG=N Review URL: https://codereview.chromium.org/1310273009 Cr-Commit-Position: refs/heads/master@{#30640}
-
- 07 Sep, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1324103003 Cr-Commit-Position: refs/heads/master@{#30620}
-
- 31 Jul, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1265923002 Cr-Commit-Position: refs/heads/master@{#29951}
-
- 17 Jul, 2015 1 commit
-
-
binji authored
BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1208933006 Cr-Commit-Position: refs/heads/master@{#29736}
-
- 22 Jun, 2015 1 commit
-
-
ben authored
Without this change, V8 won't build on RHEL/CentOS 6 because the distro python is too old to know about the argparse module. Can this commit be cherry-picked to the 4.4 branch? It should apply cleanly. BUG= Review URL: https://codereview.chromium.org/1192973004 Cr-Commit-Position: refs/heads/master@{#29186}
-
- 15 May, 2015 1 commit
-
-
domenic authored
570fca61 introduced a regression that caused minification etc. to be applied to V8 extras. R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1125103003 Cr-Commit-Position: refs/heads/master@{#28427}
-
- 11 May, 2015 1 commit
-
-
yangguo authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1130253006 Cr-Commit-Position: refs/heads/master@{#28333}
-
- 08 May, 2015 1 commit
-
-
domenic authored
Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output. This natives file output is then compiled in the bootstrapper. It is not part of the snapshot (yet), but instead is treated similar to the experimental natives, just without any of the complexity that comes from tieing the behavior to flags. We also don't need counterparts to InitializeExperimentalGlobal and InstallExperimentalNativeFunctions (yet?). This fixes the issue with https://codereview.chromium.org/1129743003 by making the dummy file that is generated for snapshots with no extras (or no experimental features) nonempty. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1130993003 Cr-Commit-Position: refs/heads/master@{#28311}
-
- 07 May, 2015 2 commits
-
-
domenic authored
Revert of Make V8 extras a separate type of native (patchset #4 id:60001 of https://codereview.chromium.org/1129743003/) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2745 Original issue's description: > Make V8 extras a separate type of native > > Instead of making them an extra option that gets passed in and compiled > at the end of the natives file for a given run of js2c, we now make them a > separate run of js2c with a separate natives file output. > > This natives file output is then compiled in the bootstrapper. It is not part > of the snapshot (yet), but instead is treated similar to the experimental > natives, just without any of the complexity that comes from tieing the > behavior to flags. We also don't add counterparts to > InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902 > Cr-Commit-Position: refs/heads/master@{#28296} TBR=jochen@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131903002 Cr-Commit-Position: refs/heads/master@{#28299}
-
domenic authored
Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output. This natives file output is then compiled in the bootstrapper. It is not part of the snapshot (yet), but instead is treated similar to the experimental natives, just without any of the complexity that comes from tieing the behavior to flags. We also don't add counterparts to InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1129743003 Cr-Commit-Position: refs/heads/master@{#28296}
-
- 30 Apr, 2015 1 commit
-
-
domenic authored
https://codereview.chromium.org/1117663002 contained a copy-paste error; this is a follow-up fixing that so that error messages now contain the correct filename when using the --extra option to js2c.py. R=yangguo@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1120593002 Cr-Commit-Position: refs/heads/master@{#28158}
-
- 29 Apr, 2015 1 commit
-
-
domenic authored
js2c.py now distinguishes between the JS internal sources and any extra scripts passed in. The latter only get validation and comment/trailing whitespace removal applied now. Also added a --js option to js2c.py, which will output a JS file instead of a C++ file, for debugging. (I got tired of finding the generated .cc file and extracting its byte array so that I could feed it to a separate helper script I wrote.) R=yangguo@chromium.org, jochen@chromium.org BUG=v8:4064 LOG=N Review URL: https://codereview.chromium.org/1117663002 Cr-Commit-Position: refs/heads/master@{#28133}
-
- 28 Apr, 2015 2 commits
-
-
domenic authored
The use of "const" prevented the actual JavaScript const keyword from functioning as intended. R=jochen@chromium.org,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1110963003 Cr-Commit-Position: refs/heads/master@{#28111}
-
domenic authored
BUG= R=jochen@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/1113593002 Cr-Commit-Position: refs/heads/master@{#28110}
-
- 27 Apr, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1106633002 Cr-Commit-Position: refs/heads/master@{#28074}
-
- 24 Apr, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1096243003 Cr-Commit-Position: refs/heads/master@{#28040}
-