- 18 Aug, 2021 1 commit
-
-
Michael Achenbach authored
This adds the option to list disallowed flags for differential fuzzing directly in the harness. Flags that can crash in smoke tests shoule be added there. No-Try: true Bug: chromium:1240812 Change-Id: I57c772bedeac0ca6ba023c6b4929515b4b0e6cca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3103314 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76369}
-
- 16 Aug, 2021 1 commit
-
-
Georg Neis authored
- Remove flag --block-concurrent-recompilation and its implementation, including %UnblockConcurrentCompilation. - Rewrite tests that used it in terms of the primitives introduced in my previous CL: https://chromium-review.googlesource.com/c/v8/v8/+/3071400/ - Remove "sync"/"no sync" arguments from %GetOptimizationStatus, assertOptimized, etc. These are now always "no sync": they don't do any magic. - Remove "if %IsConcurrentRecompilationSupported then quit" from some tests in favor of --concurrent-recompilation in their Flags line. Bug: v8:12041, v8:7790 Change-Id: I966aae4fec85e6f9e7aeed2ba2c12e9198a3991f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3077149Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76298}
-
- 12 Aug, 2021 1 commit
-
-
Ross McIlroy authored
These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#76256}
-
- 01 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Add d8.file.read() and d8.file.execute() helpers - Change tools and tests to use new d8.file helper - Unify error throwing in v8::Shell::ReadFile Change-Id: I5ef4cb27f217508a367106f01e872a4059d5e399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928505 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74883}
-
- 17 May, 2021 1 commit
-
-
Michael Achenbach authored
tldr: This adds an on-demand comparison with x64 when a difference to a non-x64 build is detected. Normally foozzie compares the baseline build (just ignition), with two secondary builds. One, the default, always uses the shipping configuration, the second passes additional flags. Both can use a different architecture than the baseline build as well. Differences between ignition and turbofan are then often detected independent of the architectures used, but reported several times (for each compared architecture). This makes the reporting more specific, by running another build on demand that uses the baseline architecture, but otherwise the same configuration that showed a difference. If it shows the difference as well, the baseline architecture is used for the report. As a result only pure architecture differences will be reported with an architecture other than x64. This also adds some minor refactorings to reduce the code complexity when looping over comparisons. For testing this, the fake-d8s are extended with different behavior for different flags passed. We add two test cases for testing: x64 vs. ia32 with difference in x64 and ia32 x64 vs. ia32 with difference only in ia32 Bug: chromium:1196633 No-Try: true Test: tools/clusterfuzz/v8_foozzie_test.py Change-Id: Ic470ae8f0b37fb1628b32e4fafc0c39377e16f8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897099Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74612}
-
- 12 Apr, 2021 1 commit
-
-
Michael Achenbach authored
Fuzz tests could mess with some library methods used by stubs for NaN-pattern problems in typed arrays. This change makes the stubs more robust. Bug: chromium:1197627 Change-Id: I84975f798d616fd5e82fd9ab84ad01fc35336a04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2820968 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73896}
-
- 22 Mar, 2021 1 commit
-
-
Clemens Backes authored
Generic wasm wrappers are enabled by default now (since https://crrev.com/c/2562241), so we can remove the flag from the nooptimization variant. Instead, we should have a configuration which tests --no-wasm-generic-wrapper to find bugs in the compiled wrappers earlier. Also add an entry for contradictory flags, and reformat that list to respect the 80 columns limit. R=machenbach@chromium.org CC=ahaas@chromium.org Bug: v8:10982 Change-Id: I780aaedbbf7fe761c39a41af1ff2db58c7447a76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773057Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73560}
-
- 19 Mar, 2021 1 commit
-
-
Leszek Swirski authored
Add an always_sparkplug testing variant, and fix a couple of issues it found. Bug: v8:11420 Change-Id: I7d87a41e3413f40271a0140118531f075d633b23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773047Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73529}
-
- 10 Mar, 2021 1 commit
-
-
Leszek Swirski authored
Robustify %CompileBaseline against fuzzing, and allowlist it in the fuzzer. Bug: v8:11420 Change-Id: I44947014c8c9362d80ea98636dbbaa5d07d6a177 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739643 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73325}
-
- 12 Feb, 2021 1 commit
-
-
Michael Achenbach authored
No-Try: true Bug: v8:11442 Change-Id: I13849c9fa90fa5a971c24694db56a07cc1cccc24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692570 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72707}
-
- 01 Dec, 2020 2 commits
-
-
Michael Achenbach authored
This is a reland of 4ad08c82 The reland organizes the different error types in separate functions for separate call stacks. Error simulation is also guarded by a minimum file size to prevent Clusterfuzz from getting stuck with its bad-build check. Original change's description: > Enable simulating errors to test fuzzer reliability > > This adds a d8 flag --simulate-errors, which on shutdown will cause > certain errors. This enables testing the reliability of sanitizers. > > This will cause a fatal error, a dcheck (if available) or a > violation that can be detected with one of the following sanitizers: > ASAN, UBSAN, MSAN, CFI. > > The same flag used in differential fuzzing will cause an error > subsumed with the error state "fake_difference". > > Bug: chromium:1152412 > Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71430} Bug: chromium:1152412 Change-Id: I604258b4c1ebd215c26b1de6b2822663f857bf64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565125 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71538}
-
Michael Achenbach authored
When one comparison run crashes, we cap the outputs to compare to the shorter one. If one of those, however, contains ignored lines, the comparison get's skewed. This makes the main source of ignored lines more robust (the line printed for unknown flags), by not printing it in the first place in the context of differential fuzzing. Bug: chromium:1153871 Change-Id: If2e534959779be14a686be5e43630cbf66e215a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567692 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71522}
-
- 30 Nov, 2020 1 commit
-
-
Michael Achenbach authored
This reverts commit 4ad08c82. Reason for revert: Need to retry with bugs in separate stack frames. Original change's description: > Enable simulating errors to test fuzzer reliability > > This adds a d8 flag --simulate-errors, which on shutdown will cause > certain errors. This enables testing the reliability of sanitizers. > > This will cause a fatal error, a dcheck (if available) or a > violation that can be detected with one of the following sanitizers: > ASAN, UBSAN, MSAN, CFI. > > The same flag used in differential fuzzing will cause an error > subsumed with the error state "fake_difference". > > Bug: chromium:1152412 > Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71430} TBR=machenbach@chromium.org,clemensb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1152412 Change-Id: If20cdef372b0e7e92e7080687f446539a587a815 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565120Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71475}
-
- 27 Nov, 2020 2 commits
-
-
Michael Achenbach authored
No-Try: true Bug: v8:10619 Change-Id: I1e227c64fa34caf010271b299d9310d19bdfc53a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563273 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71454}
-
Michael Achenbach authored
The error simulation works and crashes during the smoke test are detected. But now this masks real crashes (https://crbug.com/1153200), therefore this change subsumes smoke-test crashes with --simulate-errors under a separate crash state. Now Clusterfuzz will detect the case "unexpected crash" as fixed, but create a new bug for "simulated crash". Which we will keep open forever. No-Try: true Bug: chromium:1152412 Change-Id: I511af167d33430d9b89692151cb8abaf3a90c715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563270Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71452}
-
- 26 Nov, 2020 2 commits
-
-
Michael Achenbach authored
This passes the --simulate-errors flag for differential fuzzing with a probability of 0.01%. No-Try: true Bug: chromium:1152412 Change-Id: I3146c0ea5706be8b5ec13ee8740e1d185e008075 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562248Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71432}
-
Michael Achenbach authored
This adds a d8 flag --simulate-errors, which on shutdown will cause certain errors. This enables testing the reliability of sanitizers. This will cause a fatal error, a dcheck (if available) or a violation that can be detected with one of the following sanitizers: ASAN, UBSAN, MSAN, CFI. The same flag used in differential fuzzing will cause an error subsumed with the error state "fake_difference". Bug: chromium:1152412 Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71430}
-
- 23 Nov, 2020 1 commit
-
-
Michael Achenbach authored
Don't pass the correctness-fuzzing suppressions to normal fuzzing as they turn stack overflows and invalid string length checks into crashes. This became first now a problem after the flag was passed in an mjsunit test case. No-Try: true Bug: chromium:1151600,chromium:1151599 Change-Id: I5d29900a4b155762cae447fc102055eab1916309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551112 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71333}
-
- 19 Nov, 2020 1 commit
-
-
Clemens Backes authored
For people not too familiar with cloud storage, the direct URL makes it easier to download the zip archive. R=machenbach@chromium.org Bug: chromium:1142437, v8:10891 Change-Id: I6b29ebaac37489a73c4f75473d07e04e7200f2c3 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543395 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71276}
-
- 17 Nov, 2020 1 commit
-
-
Clemens Backes authored
It took me a while to figure out how to set up everything to run the fuzzer locally. These improved error messages would have helped to find errors earlier. R=machenbach@chromium.org Bug: chromium:1142437 Change-Id: I414de0a8448cd81fdbf999cc7c3c8cf9394354f6 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543397 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71239}
-
- 16 Nov, 2020 1 commit
-
-
Michael Achenbach authored
No-Try: true Bug: chromium:1142437 Change-Id: Icba7a00ac996c0f81a67e0141496829e657a9a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539917 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71203}
-
- 20 Oct, 2020 1 commit
-
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for v8. R=jkummerow@chromium.org, ochang@chromium.org, yangguo@chromium.org Bug: chromium:1113033 Change-Id: I82cbb62e438d82dbbc408e87120af39fa9da0afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476680Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#70669}
-
- 22 Sep, 2020 1 commit
-
-
Marja Hölttä authored
It's inherently timing-dependent, leading to false positives. Bug: chromium:1127612, v8:10239 Change-Id: Ibf6f3cb07f520a404daf8e860a0c2e5f2319529e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423707 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70046}
-
- 31 Jul, 2020 1 commit
-
-
Michael Achenbach authored
This is a JavaScript fuzzer originally authored by Oliver Chang. It is a mutation based fuzzer using Babel code transformations. For more information see the included README.md. The original code was altered: - Add new V8 copyright headers. - Make the test expectation generator aware of the headers. - Fix file endings for presubmit checks. - Fix `npm test` on fresh checkout with a new fake DB. - Make test skipping work with new v8/tools location. - OWNERS file. - New title section in README.md. No-Try: true Bug: chromium:1109770 Change-Id: Ie71752c0a37491a50500c49060a3c526716ef933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320330 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69164}
-
- 27 Jul, 2020 1 commit
-
-
Michael Achenbach authored
Updating was prepared on depot_tools side by https://crbug.com/1098560. No-Try: true Bug: v8:10619 Change-Id: If24aec3344e83857c09ce165be4203846b3a91b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316302Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69083}
-
- 22 Jul, 2020 1 commit
-
-
Michael Achenbach authored
This summarizes more dupes of https://crbug.com/1042556 TBR=mslekova@chromium.org No-Try: true Bug: chromium:1108048,chromium:1108322 Change-Id: If572b5eeeac9c2750eb1a630dd76490529e60d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314476Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69011}
-
- 03 Jul, 2020 1 commit
-
-
Michael Achenbach authored
This is another case of the known .caller difference that's now added to the mapping of known issues. No-Try: true Bug: chromium:1101870 Change-Id: I6cfca6887362564f625648ba34820cb92a77efb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280087Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68674}
-
- 30 Jun, 2020 2 commits
-
-
Michael Achenbach authored
Mostly gc-related flags didn't flush out any bugs yet, but often reduce test performance and lead to timeouts. No-Try: true Bug: chromium:1044942 Change-Id: I2a7b55f78bfa3d597de1a5674658829e0812d01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273861Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68608}
-
Michael Achenbach authored
Previously we ran baseline (e.g. ignition) and one random secondary comparison configuration (e.g. turbofan) from the list of experiments. But Clusterfuzz imposes limitations on the total amount of fuzz tests. Therefore this change enables more throughput by always running the default configuration (ignition_turbofan like V8 is shipped) additionally to the baseline and the secondary configuration. This, hence, doubles the number of comparisons we run, with less than 50% additional runtime, since the slow baseline configuration is only run once. The experiments table is updated accordingly. Explicit entries running ignition_turbofan are removed (as it always runs now), instead some of the other configurations are increased in their relative percentage. We also get a few new configurations that didn't run before (e.g. forcing the slow path on x86). No-Try: true Bug: chromium:1100114 Change-Id: I69b2a41d78c06e556b309743a2aace1053c22f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270307Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68607}
-
- 29 Jun, 2020 5 commits
-
-
Michael Achenbach authored
This shares the code of running the comparisons on the fuzz test and on the smoke tests. While this change retains behavior for running the fuzz test, the smoke test has slight changes in favor of code readability: 1. Smoke tests can now bail out on output suppressions (There are none now. And if we'd ever add any we'd need to write them in a way, such that they ignore the output of the smoke tests, which don't have much output anyways). 2. Crashes in smoke tests are now a hard failure. This is a desired feature anyways. It's unlikely that the smoke test crashes as then nothing would work. No-Try: true Bug: chromium:1100114 Change-Id: Ice3c6d18b549727c486a70756a72038c8b2029ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273125 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#68586}
-
Michael Achenbach authored
This adds a class representing all values needed for an execution. It simplifies the parameters passed to formatting functions and lifts the restriction of a first/second config pair in the options. This will allow to run more than two configs in a follow up. No-Try: true Bug: chromium:1100114 Change-Id: I568253b8ca3220870b8f5af615108140587680a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270550Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68583}
-
Michael Achenbach authored
This makes output and test-case suppressions independent of the used comparison configs and architecture. Such fine-grained suppressions were only needed during the inception of differential fuzzing, but by now, most remaining suppressions are implemented in d8 behind a flag. This prepares for running with more than two comparison configs in a follow up. No-Try: true Bug: chromium:1100114 Change-Id: I072769adb3ef7c6e6c43459aa23ac906f461b307 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270095 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#68579}
-
Michael Achenbach authored
It is obsolete to filter out error-message differences since the time we pass --correctness-fuzzer-suppressions to d8, which already stubs all messages: https://cs.chromium.org/chromium/src/v8/src/execution/messages.cc?l=1031 No-Try: true Bug: chromium:1100114 Change-Id: Iac42a8e2a32f9bae4034f79eaff429bf3ee41724 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270024Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68577}
-
Michael Achenbach authored
This simplifies the lengthy main method by extracting some code and by replacing the scattered returns with exceptions. We introduce two exceptions for early bail-out. This enables helper methods on multiple layers. The early bail-out on time-out is moved to the point where it is detected. Previously on timeout and crash we also printed out the step number. Clusterfuzz doesn't parse this, it was only for statistical purposes, and the latest version of the experimental workbench only parses crashes and timeouts, not the step in which they happened. Hence, this CL removes those step numbers. Except the change described in the last paragraph, this CL doesn't intend to change behavior. No-Try: true Bug: chromium:1100114 Change-Id: Ie8c18f183e4fc538577f3eb49aaf6df1acd1e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270547Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68576}
-
- 24 Jun, 2020 1 commit
-
-
Michael Achenbach authored
If we pass flags that make runs very slow, also the validity checks might time out. Previously this wasn't checked and output was just cut off. This also tightens the timeout on validity checks as they are expected to run very fast. No-Try: true Bug: chromium:1098646 Change-Id: Iea9a932be86e84040b72a2311aaa1d44100b3378 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2262915Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68510}
-
- 22 Jun, 2020 1 commit
-
-
Ng Zhi An authored
This changes the use of "sane" to "sensible" or "valid". I tried to be sensible in my choice of replacement, by trying to read the comments or code to see which word matches the intention closest. Referenced https://fuchsia.dev/fuchsia-src/contribute/best-practices/respectful_code?hl=en#what_are_examples_of_terminology_to_be_avoided. Bug: v8:10619 Change-Id: Id957b2e6ff11e95270e1372005e1006d8cf1008d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254483 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68471}
-
- 19 Jun, 2020 1 commit
-
-
Michael Achenbach authored
Bug: chromium:1091698 Change-Id: Ida82d262f409c54e59640bcaa026879d18ff178d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252184 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68439}
-
- 17 Jun, 2020 1 commit
-
-
Michael Achenbach authored
This fixes a bug when an encoded character appears in the difference string. Python3 doesn't require any encoding. TBR=tmrts@chromium.org No-Try: true Bug: chromium:1095964 Change-Id: I49c66b5b9c105ad64d3a7839d0eb5df97ff5f404 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249660Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68384}
-
- 28 May, 2020 1 commit
-
-
Michael Achenbach authored
This prepares using ochang_js_fuzzer with foozzie. The fuzzer uses tests from CrashTests in the corpus. This leads to a loop when used with differential fuzzing, as foozzie dedupes failures based on the original file path. Foozzie finds a new failure for the existing failure in CrashTests, for which clusterfuzz creates a new crash test and so on. This subsumes all failures from CrashTests under the same key. Once such a failure is reported, a developer can add it to a mapping in foozzie.py, after which the global key can be used again by clusterfuzz to report another failure. No-Try: true Bug: chromium:1044942 Change-Id: I801a23faeb0c672d6ad64b4100c463f53e36cbc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214837 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68053}
-
- 06 May, 2020 1 commit
-
-
Michael Achenbach authored
This prevents bug flooding based on differences from calling %GetOptimizationStatus in correctness tests. It is supposed to be suppressed with --allow-natives-for-differential-fuzzing. This ensures early bail-out in case the flag is forgotten at some point. The v8_sanity_checks.js file is executed before each correctness test case for this purpose. NOTRY=true Bug: chromium:1044942 Change-Id: I74a836a82562604b35e94e5e123a2a8bff939423 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184294Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67618}
-