[wasm] Test --no-wasm-generic-wrapper in the stress variant

Generic wasm wrappers are enabled by default now (since
https://crrev.com/c/2562241), so we can remove the flag from the
nooptimization variant. Instead, we should have a configuration which
tests --no-wasm-generic-wrapper to find bugs in the compiled wrappers
earlier.

Also add an entry for contradictory flags, and reformat that list to
respect the 80 columns limit.

R=machenbach@chromium.org
CC=ahaas@chromium.org

Bug: v8:10982
Change-Id: I780aaedbbf7fe761c39a41af1ff2db58c7447a76
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773057Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73560}

tools/clusterfuzz/v8_fuzz_flags.json

@@ -28,5 +28,6 @@
   [0.25, "--no-lazy-feedback-allocation"],
   [0.1, "--no-lazy-feedback-allocation --interrupt-budget=100"],
   [0.05, "--budget-for-feedback-vector-allocation=0"],
+  [0.1, "--no-wasm-generic-wrapper"],
   [0.0001, "--simulate-errors"]
-]
\ No newline at end of file
+]

tools/testrunner/local/variants.py

@@ -24,10 +24,10 @@ ALL_VARIANT_FLAGS = {
   # For WebAssembly, we test "Liftoff-only" in the nooptimization variant and
   # "TurboFan-only" in the stress variant. The WebAssembly configuration is
   # independent of JS optimizations, so we can combine those configs.
-  "nooptimization": [["--no-opt", "--liftoff", "--no-wasm-tier-up",
-                      "--wasm-generic-wrapper"]],
+  "nooptimization": [["--no-opt", "--liftoff", "--no-wasm-tier-up"]],
   "slow_path": [["--force-slow-path"]],
-  "stress": [["--stress-opt", "--no-liftoff", "--stress-lazy-source-positions"]],
+  "stress": [["--stress-opt", "--no-liftoff", "--stress-lazy-source-positions",
+              "--no-wasm-generic-wrapper"]],
   "stress_concurrent_allocation": [["--stress-concurrent-allocation"]],
   "stress_concurrent_inlining": [["--stress-concurrent-inlining"]],
   "stress_js_bg_compile_wasm_code_gc": [["--stress-background-compile",
@@ -50,24 +50,34 @@ ALL_VARIANT_FLAGS = {
 # implications defined in flag-definitions.h.
 INCOMPATIBLE_FLAGS_PER_VARIANT = {
   "assert_types": ["--no-assert-types"],
-  "jitless": ["--opt", "--always-opt", "--liftoff", "--track-field-types", "--validate-asm", "--sparkplug", "--always-sparkplug"],
+  "jitless": ["--opt", "--always-opt", "--liftoff", "--track-field-types",
+              "--validate-asm", "--sparkplug", "--always-sparkplug"],
   "no_wasm_traps": ["--wasm-trap-handler"],
-  "nooptimization": ["--opt", "--always-opt", "--no-liftoff", "--wasm-tier-up"],
+  "nooptimization": ["--opt", "--always-opt", "--no-liftoff",
+                     "--wasm-tier-up"],
   "slow_path": ["--no-force-slow-path"],
   "stress_concurrent_allocation": ["--single-threaded-gc", "--predictable"],
-  "stress_concurrent_inlining": ["--single-threaded", "--predictable", "--no-turbo-direct-heap-access"],
+  "stress_concurrent_inlining": ["--single-threaded", "--predictable",
+                                 "--no-turbo-direct-heap-access"],
   "stress_incremental_marking": ["--no-stress-incremental-marking"],
   "future": ["--no-turbo-direct-heap-access"],
   "stress_js_bg_compile_wasm_code_gc": ["--no-stress-background-compile"],
-  "stress": ["--no-stress-opt", "--always-opt", "--no-always-opt", "--liftoff", "--max-inlined-bytecode-size=*",
-             "--max-inlined-bytecode-size-cumulative=*", "--stress-inline"],
+  "stress": ["--no-stress-opt", "--always-opt", "--no-always-opt", "--liftoff",
+             "--max-inlined-bytecode-size=*",
+             "--max-inlined-bytecode-size-cumulative=*", "--stress-inline",
+             "--wasm-generic-wrapper"],
   "sparkplug": ["--jitless", "--no-sparkplug" ],
-  "always_sparkplug": [ "--jitless", "--no-sparkplug", "--no-always-sparkplug" ],
-  "turboprop": ["--interrupt-budget=*", "--no-turbo-direct-heap-access", "--no-turboprop"],
-  "turboprop_as_toptier": ["--interrupt-budget=*", "--no-turbo-direct-heap-access", "--no-turboprop", "--no-turboprop-as-toptier"],
-  "code_serializer": ["--cache=after-execute", "--cache=full-code-cache", "--cache=none"],
+  "always_sparkplug": ["--jitless", "--no-sparkplug", "--no-always-sparkplug"],
+  "turboprop": ["--interrupt-budget=*", "--no-turbo-direct-heap-access",
+                "--no-turboprop"],
+  "turboprop_as_toptier": ["--interrupt-budget=*",
+                           "--no-turbo-direct-heap-access", "--no-turboprop",
+                           "--no-turboprop-as-toptier"],
+  "code_serializer": ["--cache=after-execute", "--cache=full-code-cache",
+                      "--cache=none"],
   "no_local_heaps": ["--concurrent-inlining", "--turboprop"],
-  "experimental_regexp": ["--no-enable-experimental-regexp-engine", "--no-default-to-experimental-regexp-engine"],
+  "experimental_regexp": ["--no-enable-experimental-regexp-engine",
+                          "--no-default-to-experimental-regexp-engine"],
 }
 
 # Flags that lead to a contradiction under certain build variables.