1. 27 Nov, 2019 1 commit
    • Leszek Swirski's avatar
      [isolate] Make field getters use a const Isolate* · 42a56e03
      Leszek Swirski authored
      To indicate that the Isolate* in getters might not be a "real" isolate,
      but rather a calculated one from GetIsolateForPtrCompr only used for
      calculating the isolate root, make that function return a const Isolate*
      and change field getters, Object::IsFoo predicates, and related
      functions to all take a const Isolate* instead of an Isolate*
      
      With this change, we can slightly more confidently use Objects that are
      in OffThreadSpace, without having to worry too much about having an
      Isolate* floating around that could accidentally be used.
      
      This is a slight abuse of const semantics, but it allows implicit
      conversion from Isolate* arguments to the const Isolate* parameter.
      
      Bug: v8:7703
      Bug: chromium:1011762
      Change-Id: I54d4a65d2299477195f4d754cabe64ce34fdaa4c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939455
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Auto-Submit: Leszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65199}
      42a56e03
  2. 11 Oct, 2019 1 commit
  3. 15 Jul, 2019 1 commit
    • Seth Brenith's avatar
      [torque] Use @generateCppClass in some simple cases · 14274bb1
      Seth Brenith authored
      This change is mostly mechanical, but it's worth mentioning a few
      slightly interesting cases:
      - A couple of field definitions didn't match the signedness of their
        corresponding accessors.
      - The generated accessors for Smi data use Smi values directly, but
        usually we want C++ accessors to use ints instead. I added a macro
        that hides the generated Smi accessors and exposes int accessors,
        but we might consider generating int accessors directly.
      - The data held in some fields is described in comments next to the
        accessor definition for those fields. With automatically generated
        accessors, those comments need a new home. In this change I put them
        in the Torque object definition, but I'm open to other suggestions.
      - gen-postmortem-metadata couldn't find updated class definitions after
        they got split across multiple lines, so I changed its matching
        logic. (Ideally debug-support.cc should be a Torque compiler output
        rather than something that involves parsing C++ with regexes, but
        this makes it correctly report subclass relationships for now.)
      - The end offsets generated by Torque were off by one from the values
        that would be generated by DEFINE_FIELD_OFFSET_CONSTANTS.
      
      Change-Id: I3df4fcd27997b46c41ca879065b9d97f6c939f07
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692192Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#62719}
      14274bb1
  4. 03 Jul, 2019 1 commit
  5. 17 Jun, 2019 1 commit
  6. 23 May, 2019 2 commits
  7. 22 May, 2019 2 commits
  8. 20 May, 2019 1 commit
  9. 09 May, 2019 1 commit
  10. 25 Apr, 2019 1 commit
  11. 17 Apr, 2019 1 commit
  12. 13 Feb, 2019 1 commit
  13. 09 Feb, 2019 1 commit
  14. 01 Feb, 2019 1 commit
  15. 09 Jan, 2019 1 commit
  16. 26 Dec, 2018 1 commit
  17. 20 Dec, 2018 1 commit
  18. 19 Dec, 2018 1 commit
    • Ulan Degenbaev's avatar
      [heap] Optimize marking of descriptor arrays. · 0400fc20
      Ulan Degenbaev authored
      Now a descriptor array tracks the number of descriptors that were
      already marked. The marking visitor of a map only marks the subset
      of the descriptors that it needs and that are not already marked.
      
      If a descriptor array is shared between M maps and has N descriptos,
      then the number of marking operations is reduced from O(M*N) to O(N).
      
      This patch also adds a marking barrier for descriptors.
      
      The marked descriptor counter in a descriptor array is not cleared
      after mark-compact GC. Instead, it embeds two bits from the global
      mark-compact epoch counter and is considered 0 if the bits do not match
      the current value of the global epoch counter.
      
      Bug: v8:8486
      Change-Id: I2a7822a6833f3143e1d351e5e4819c2ef2c07fb0
      Reviewed-on: https://chromium-review.googlesource.com/c/1382746
      Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58372}
      0400fc20
  19. 17 Dec, 2018 1 commit
  20. 14 Dec, 2018 1 commit
  21. 07 Dec, 2018 1 commit