• Clemens Backes's avatar
    [heap] Fix {InternalizeString} for char vectors · acc71c78
    Clemens Backes authored
    Even though {Factory::InternalizeString} was declared as a template,
    only two instantiations exists: uint8_t and uint16_t. Using any other
    type leads to link-time errors, which is inconvenient.
    
    This CL implements the two instantiations explicitly, and provides a
    third implementation taking a {Vector<const char>}. This will be used
    after the next CL, which changes {StaticCharVector} to actually return a
    {Vector<const char>}.
    
    This also avoid the cumbersome template exports.
    
    R=leszeks@chromium.org
    
    Bug: v8:10426
    Change-Id: I3f669fae2c711ade6f5a087e59210ad457423a66
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152837
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67207}
    acc71c78
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...