- 24 Sep, 2018 23 commits
-
-
Yang Guo authored
This is a reland of 33fa357b TBR=mvstanton@chromium.org Original change's description: > Do not use FixedDoubleArray to store RNG state > > Also: > - replace runtime call with cheaper C call > - change state to double conversion > > R=mvstanton@chromium.org > > Bug: v8:8212 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 > Reviewed-on: https://chromium-review.googlesource.com/1240116 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56165} Bug: v8:8212 Change-Id: Iccc9128034ce7b65801a04a54982219b5a4fe84e Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1238551Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56175}
-
Igor Sheludko authored
Bug: v8:8015 Change-Id: I1a423b356d09bdf46d49d69fb83cc24acabb6313 Reviewed-on: https://chromium-review.googlesource.com/1238550Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56174}
-
Toon Verwaest authored
This allows to inline the part where we call to the nested rule and the token check while keeping the bulk of the work if it's actually a unary/conditional expression outline. Change-Id: I1b1f7ebaf2d4f660f157ece7f9534525b80a95a6 Reviewed-on: https://chromium-review.googlesource.com/1238922Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56173}
-
Yang Guo authored
R=petermarshall@chromium.org Change-Id: I2738b6ccf8b3c56b58554aa8dd626da5d2c3865d Reviewed-on: https://chromium-review.googlesource.com/1240137Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56172}
-
Toon Verwaest authored
The previous clear mechanism would also unnecessarily allocate a preparser. This fixes regressions introduced by https://chromium-review.googlesource.com/c/v8/v8/+/1238614 Change-Id: Ia3eef371c80857f2cd6cdd5852c849fa7f8716fc Reviewed-on: https://chromium-review.googlesource.com/1238918 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56171}
-
Peter Marshall authored
This is more generic as it doesn't restrict embedded code to just builtins. Also, some builtins are still on-heap so the name was not totally accurate. Bug: v8:8116 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I44cd24d6baf2bce0e5d914d36a2bae98e77bdc6d Reviewed-on: https://chromium-review.googlesource.com/1238919 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... so that it is no longer needed to iterate over other lists. This CL also moves data handler maps to the RO roots list (because they are RO). Bug: v8:8015 Change-Id: If21fe5bac5a6ac1e44a47783ad930df5fcecda9a Reviewed-on: https://chromium-review.googlesource.com/1240134Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56169}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/218f466..868fbbf Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0dc1fa0..baf0927 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifb64ed8de7d45867a7b3bbae1357ba0f0aecc4b6 Reviewed-on: https://chromium-review.googlesource.com/1240103 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56168}
-
Maya Lekova authored
This reverts commit 33fa357b. Reason for revert: Breaking the V8 Linux - arm64 - sim - MSAN bot. Please see here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/23001 Original change's description: > Do not use FixedDoubleArray to store RNG state > > Also: > - replace runtime call with cheaper C call > - use xor instead of addition to remove bias > > R=mvstanton@chromium.org > > Bug: v8:8212 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 > Reviewed-on: https://chromium-review.googlesource.com/1240116 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56165} TBR=yangguo@chromium.org,mvstanton@chromium.org Change-Id: I05f23f0b52a706233bbc1a1877cc15691ed9f40a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8212 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1238549Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56167}
-
Jaroslav Sevcik authored
Change-Id: Id31c1178b84be5ec4e876495ce220302864713e0 Reviewed-on: https://chromium-review.googlesource.com/1240118Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56166}
-
Yang Guo authored
Also: - replace runtime call with cheaper C call - use xor instead of addition to remove bias R=mvstanton@chromium.org Bug: v8:8212 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 Reviewed-on: https://chromium-review.googlesource.com/1240116 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#56165}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/641370b..dfca77b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6f7c60d..218f466 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/92df4e6..0dc1fa0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5ae82581f54b2206f2574b61fa3c02aad5d7427c Reviewed-on: https://chromium-review.googlesource.com/1239190 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Dan Elphick authored
ToBoolean and BooleanValue cannot throw exceptions so the Maybe versions of the functions don't make sense. As such this deprecates the Maybe versions and undeprecates ToBoolean(Isolate*). It also adds BooleanValue(Isolate*). Fix up all of the v8 code to not use the deprecated functions. Bug: v8:7279, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50e7474d205c75baa153f0dea7f02dcf60232d1d Reviewed-on: https://chromium-review.googlesource.com/1238476 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This swaps out ebx in favor of esi. The root pointer value itself is pushed and restored from the stack through pushad/popad. Bug: v8:6666 Change-Id: I2a685f6659a5fbe2f7d91e431c5addff85664b5b Reviewed-on: https://chromium-review.googlesource.com/1238653 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56162}
-
Igor Sheludko authored
... containing ROOT_LIST-compatible entries. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia7a2620e2b6c9b2238cc0c2a6ead6bf7e6a46c00 Reviewed-on: https://chromium-review.googlesource.com/1238724 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
INTERNALIZED_STRING_ROOT_LIST, [PRIVATE|PUBLIC|WELL_KNOWN]_SYMBOL_ROOT_LIST Bug: v8:8015 Change-Id: I6f271fa8bfbe5e994ebcef191e6750fa3ff6dd7f Reviewed-on: https://chromium-review.googlesource.com/1238567Reviewed-by:
-
Ben L. Titzer authored
Neither the native module nor the trap handler flag are needed to compile JS to WASM wrappers. R=clemensh@chromium.org Change-Id: I46770d26e4063a6efbcaef55bebab5e1a131a0e8 Reviewed-on: https://chromium-review.googlesource.com/1238506 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Issues/problems addressed: - Fix line-wrapping and indenting for long declarations including strings, e.g. generates and constexpr clauses. - Implement proper formatting for typeswitch statements - Fix formatting of operator declarations - Fix formatting of constexpr if-clauses (the constexpr is now included on the same line as the if and it doesn't mess up the formatting that - Fix formatting of label declarations on callables, the "label" keyword now always starts a new line with indentation. - Remove space after identifier name in generic parameter declarations, e.g. "<a : T>" is now "<a: T>" which is consistent with type specification formatting elsewhere. - Indent "otherwise" clauses that have been pushed to the next line. Also ran the formatter over all existing .tq files. Bug: v8:7793 Change-Id: I5adbb2ffa3d573deed062f9a5c1da57348c8fc71 Reviewed-on: https://chromium-review.googlesource.com/1238580 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56158}
-
Toon Verwaest authored
Change-Id: I38e7ea204c84dfef22e1f87ac5923d93322b2620 Reviewed-on: https://chromium-review.googlesource.com/1238722Reviewed-by:
-
Clemens Hammacher authored
1) Avoid putting empty VirtualMemory objects in {owned_code_space_}. 2) After allocating more code space, the actual allocation in that space should also succeed. DCHECK that. 3) Remove pointless std::move. R=ahaas@chromium.org Bug: v8:8015 Change-Id: Ifda30d8279579ea290c6fa8e9c310f05a044b288 Reviewed-on: https://chromium-review.googlesource.com/1238721Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56156}
-
Toon Verwaest authored
Change-Id: Ic2efd81492836bf9f6dd1b48fdfb57ce19ef566a Reviewed-on: https://chromium-review.googlesource.com/1240117Reviewed-by:
-
Toon Verwaest authored
Change-Id: I5b5228427039ce31b9b978d406d860ff08b32dae Reviewed-on: https://chromium-review.googlesource.com/1238543Reviewed-by:
-
Benedikt Meurer authored
When we detect during SimplifiedLowering that the index for the MaybeGrowFastElements operation is less than the length of the array, which are both passed as explicit parameters to the operation, we can just drop the operation from the graph completely and go with the existing elements. This happens for example when code creates a new Array and immediately stores to it, i.e. like in the case of ```js const array = new Array(); array.push(something); ``` where the `new Array()` already creates a backing store of 4 elements, so the check for growing in `Array#push()` is redundant here. Change-Id: I548049b2c7b60c5f189f8ffdcb20b3a6ff1b0555 Reviewed-on: https://chromium-review.googlesource.com/1238655Reviewed-by:
-
- 21 Sep, 2018 17 commits
-
-
Aseem Garg authored
This CL ignores multiple name sections in wasm modules instead throwing an error. This is in line with the spec with regards to custom sections. BUG=v8:8186 R=clemensh@chromium.org,adamk@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c6610afe389d8f8d03f9fca164bd46cb5fb030d Reviewed-on: https://chromium-review.googlesource.com/1232676 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
After total liveedit rewrite, liveedit works with module, we can remove the guard. R=dgozman@chromium.org Bug: chromium:806261 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide15eca2ab6d8ba7df4e7fae541c4a65794eeea8 Reviewed-on: https://chromium-review.googlesource.com/1238914Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56151}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:838864 Change-Id: Iec0999284336deaf23030d151f075ca78268489e Reviewed-on: https://chromium-review.googlesource.com/1238474 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56150}
-
Igor Sheludko authored
In order to workaround MSVC compilation issue this CL explicitly adds _TYPE suffixes to struct instance type names in STRUCT_LIST. Bug: v8:8015 Change-Id: If71a26e4cbd41bc7372bf127bd050159d0d324ce Reviewed-on: https://chromium-review.googlesource.com/1238496 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
In an embedded handler build, it's not guaranteed that every handler is embedded (and thus immovable). The GC must still iterate the dispatch table to update pointers to moved code objects. TBR=rmcilroy@chromium.org Bug: v8:8068 Change-Id: I8b37f1758fdc670081e0c4f58795aea271811994 Reviewed-on: https://chromium-review.googlesource.com/1238236Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56148}
-
Jakob Gruber authored
Bug: v8:6666 Change-Id: I54ee5bcaef729d1a4b9edbae3157951df135df90 Reviewed-on: https://chromium-review.googlesource.com/1238239 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Simplify zone discarding for preparsed functions by simply giving the preparser its own zone that we reset whenever we finish preparsing something. Change-Id: I3135fbbcd6caefa4654b1ae2b2207377e51bee26 Reviewed-on: https://chromium-review.googlesource.com/1238614 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56146}
-
Mathias Bynens authored
The proposal is currently at Stage 2 of the TC39 process. Repository: https://github.com/tc39/proposal-well-formed-stringify Bug: v8:7782 Change-Id: I7383f0df5b330aa71e3d80b50b7e52d474f153a3 Reviewed-on: https://chromium-review.googlesource.com/1238475 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:8015 Change-Id: Ie14228aa4d75d1a7f2a057ce1a001c51a7732dcc Reviewed-on: https://chromium-review.googlesource.com/1238515 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#56144}
-
Igor Sheludko authored
... which are generated from ALLOCATION_SITE_LIST and DATA_HANDLER_LIST respectively. Bug: v8:8015 Change-Id: Ib729628e6b65ad98ff50234572f8edf2854f83ad Reviewed-on: https://chromium-review.googlesource.com/1238517 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:8015, v8:7490, v8:7965 Change-Id: Ic81c4c07b5b64ee3b77d7d1d245c3f5d32f9cdfa Reviewed-on: https://chromium-review.googlesource.com/1238613 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56142}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8207 Change-Id: Ic19cddc193e6a280f0f4f9289e1ab8f36f08e9c8 Reviewed-on: https://chromium-review.googlesource.com/1238216 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:8015 Change-Id: Iaeaaa5a1ccded0b6e43bd78dd04cc0b8e2c933a3 Reviewed-on: https://chromium-review.googlesource.com/1238495Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I2b1eb33e4b7a7c5158bec02c60823669921b619d Bug: v8:6666, v8:8015 Reviewed-on: https://chromium-review.googlesource.com/1238578Reviewed-by:
-
Marja Hölttä authored
Also fixing DEPS include rules for heap-write-barrier.h BUG=v8:5402,v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia785da321bc6c6f4c375ae8c866a0bf294e64f5b Reviewed-on: https://chromium-review.googlesource.com/1238453Reviewed-by:
-
Michael Starzinger authored
This also makes the {AddCodeCopy} method more specific to only apply to import wrappers, otherwise the use of {set_code} would be unprotected. R=clemensh@chromium.org BUG=v8:8015 Change-Id: I62561560f57e4cc235a338c0e769e50ff55ec42d Reviewed-on: https://chromium-review.googlesource.com/1238477Reviewed-by: -
Benedikt Meurer authored
Remove the following runtime functions, which are not used throughout the code base anymore: - %GetWeakMapEntries - %GetWeakSetValues - %MapIteratorClone - %SetIteratorClone - %StringNotEqual - %FunctionGetName - %IsConstructor - %SetCode Bug: v8:8015 Change-Id: Iaf441d58e9b9bc77ef5bf93cb82ada87fb1ff5a7 Reviewed-on: https://chromium-review.googlesource.com/1238574 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
