Skip to content

V
V8
Switch branch/tag
  1. 21 Jun, 2018 1 commit
  3. 20 Jun, 2018 2 commits
  5. 19 Jun, 2018 2 commits
  7. 14 Jun, 2018 1 commit
  9. 13 Jun, 2018 2 commits
  11. 11 Jun, 2018 2 commits
  13. 08 Jun, 2018 1 commit
  15. 07 Jun, 2018 6 commits
  17. 06 Jun, 2018 1 commit
  19. 04 Jun, 2018 2 commits
  21. 01 Jun, 2018 2 commits
  23. 28 May, 2018 1 commit
  25. 24 May, 2018 3 commits
  27. 23 May, 2018 3 commits
    • Alexei Filippov's avatar
      [cpu-profiler] Reuse free slots in code_entries_ · 3e1126bf
      Alexei Filippov authored 
      The patch makes it manage a free list of released code_entries_ slots,
and reuse the slots as needed.

BUG=v8:7719

Change-Id: I07df1ce983fe00e0ca3d1a1ea20e1a141aabad99
Reviewed-on: https://chromium-review.googlesource.com/1062769Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53314}
      3e1126bf
    • Alexei Filippov's avatar
      [cpu-profiler] Prefix wasm resource names with "wasm " · 1143a6c7
      Alexei Filippov authored 
      BUG=chromium:844150

Change-Id: I0f7e10fb9778b3de76591ad4819be45c8c50c8d4
Reviewed-on: https://chromium-review.googlesource.com/1064815Reviewed-by: 's avatarStephan Herhut <herhut@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53313}
      1143a6c7
    • Peter Marshall's avatar
      [cpu-profiler] Add a new profiling mode with a more detailed call tree. · ecae80cd
      Peter Marshall authored 
      The current profiling mode (called kLeafNodeLineNumbers in this CL)
produces a tree, with each node representing a stack frame that is seen
in one or more samples taken during profiling. These nodes refer to a
particular function in a stack trace, but not to a particular line or
callsite within that function.

This CL adds a new more (called kCallerLineNumbers) which produces a
different profile tree, where each stack trace seen during profiling,
including the line number, has a unique path in the tree.

The profile tree was previously keyed on CodeEntry*. Now it is keyed on
the pair of CodeEntry* and line_number, meaning it has distinct nodes
for those combinations which exist, and each distinct stack trace that
was sampled is represented in the tree.

For optimized code where we have inline frames, there are no line
numbers for the inline frames in the stack trace, causing duplicate
branches in the tree with kNoLineNumberInfo as the reported line number.
This will be addressed in follow-ups.

Bug: v8:7018
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I512e221508f5b50ec028306d212263b514a9fb24
Reviewed-on: https://chromium-review.googlesource.com/1013493
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53298}
      ecae80cd
  29. 22 May, 2018 1 commit
  31. 18 May, 2018 1 commit
    • Peter Marshall's avatar
      [cpu-profiler] Move bailout reason into rare_info struct · 29ea4d1e
      Peter Marshall authored 
      This was set very regularly in FillFunctionInfo, but it was almost
always set to kNoReason, because the associated SFI had no bailout
reason. Given that having a bailout reason is the rare case, we
just assume an empty bailout reason, and use the rare_data_ struct
to store the string pointer if we do need it.

This saves another pointer of space on the CodeEntry object (approx
1.4 MiB on the node server example).

Bug: v8:7719
Change-Id: I8e2272b572285ddf353ba0b303e6da095b7d5272
Reviewed-on: https://chromium-review.googlesource.com/1064370
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53244}
      29ea4d1e
  33. 17 May, 2018 1 commit
  35. 16 May, 2018 1 commit
    • Alexei Filippov's avatar
      [cpu-profiler] Eagerly delete not used CodeEntry'es · c6c28f7a
      Alexei Filippov authored 
      Currently ProfilerListener holds all the CodeEntries it ever
created during the profiling session. It is not capable of removing
entries corresponding to the code objects discarded by GC as there's
no such code event.

However it is sometimes possible to tell if a code object was GCed.
Hook up to the CodeMap code entry removal and if the entry has never
been hit by a sample we can safely delete it.

As a bonus the CodeEntryInfo size has been reduced on x64, which also
saves 8 x <number of code entries> bytes.

BUG=v8:7719

Change-Id: I988bc5b59f3fba07157a9f472cbcf68596fcd969
Reviewed-on: https://chromium-review.googlesource.com/1054346Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53222}
      c6c28f7a
  37. 11 May, 2018 1 commit
  39. 09 May, 2018 3 commits
  41. 08 May, 2018 2 commits
  43. 07 May, 2018 1 commit