Commit da2be4d0 authored by Marja Hölttä's avatar Marja Hölttä Committed by Commit Bot

[in-place weak refs] Fix HeapSnapshotGenerator.

WeakFixedArrays can also contain strong pointers.

(Separating this fix from
https://chromium-review.googlesource.com/c/v8/v8/+/1075053 ; after that CL tests
will fail without this fix.)

BUG=v8:7308

Change-Id: I0d47ab179625bcbf6149cf02ad696f8af250ae8d
Reviewed-on: https://chromium-review.googlesource.com/1075270Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53386}
parent 21eb2029
......@@ -1416,6 +1416,9 @@ void V8HeapExplorer::ExtractWeakArrayReferences(int header_size, int entry,
if (object->ToWeakHeapObject(&heap_object)) {
SetWeakReference(array, entry, i, heap_object,
header_size + i * kPointerSize);
} else if (object->ToStrongHeapObject(&heap_object)) {
SetInternalReference(array, entry, i, heap_object,
header_size + i * kPointerSize);
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment