Skip to content

V
V8
Switch branch/tag
  1. 07 Sep, 2022 1 commit
  3. 22 Aug, 2022 1 commit
    • ishell@chromium.org's avatar
      [runtime] Merge redirected and non-redirected callback fields · 134ca75c
      ishell@chromium.org authored 
      Namely:
 - AccessorInfo::getter and AccessorInfo::js_getter,
 - CallHandlerInfo::callback and CallHandlerInfo::js_callback.

The redirected/non-redirected callback distinction is required only
for simulated builds but we wasted memory also for all native builds.

Now we store these fields in "redirected" form which allows us to call
them directly from builtins or generated code. In case it's necessary
to call a callback from C++ code the C function address is read from
the redirection. This additional indirection makes the callback calls
from C++ code in simulated builds slower but saves memory for native
builds.

This CL should recover a part of memory regression caused by inlining
Foreign fields into AccessorInfo and CallHandlerInfo.

Bug: v8:12949, chromium:1336105, chromium:1335930
Change-Id: I38470ed21ee23b281247c11a9531542c7e4acca1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835686Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82631}
      134ca75c
  5. 23 Jun, 2022 1 commit
  7. 13 May, 2022 1 commit
  9. 05 May, 2022 1 commit
  11. 01 Apr, 2022 1 commit
  13. 14 Mar, 2022 1 commit
  15. 24 Nov, 2021 1 commit
  17. 22 Nov, 2021 2 commits
  19. 09 Nov, 2021 1 commit
  21. 05 Nov, 2021 1 commit
  23. 02 Nov, 2021 1 commit
  25. 01 Oct, 2021 1 commit
  27. 19 Aug, 2021 1 commit
  29. 10 Aug, 2021 1 commit
    • Bruce Dawson's avatar
      Explicitly include windows.h in Win ARM64 files · 67a565c0
      Bruce Dawson authored 
      Now that V8 doesn't globally include windows.h we need to explicitly
include it in source files that need it. This fixes a Windows ARM64
build break triggered by crrev.com/c/3042215.

I did a test build of ARM64 V8 with and without this patch in order to
reproduce the errors and confirm that there are no others.

Bug: chromium:796644, chromium:1237067
Change-Id: I43045fcaab9e6296629775a9705aae6b2066adef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3076019Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76208}
      67a565c0
  31. 21 Jul, 2021 1 commit
    • Clemens Backes's avatar
      [wasm] Add trap-handler support for arm64 simulator · e312038d
      Clemens Backes authored 
      This adds a little {Simulator::ProbeMemory} method that is used from
several places in the arm64 simulator to test if a memory address can be
accessed, and trigger a signal from a specific location such that the
trap-handler can handle it. In case of a trap, the simulator is
redirected to the landing pad and stops executing the memory
instruction that triggered the trap.

Standard memory accesses and SIMD memory loads and stores are
instrumented to probe the memory. This passes all existing tests. In
case this CL misses certain spots, we can still add them later. This
will not be a security problem, since we do not use the simulator in
production.

R=ahaas@chromium.org
CC=mseaborn@chromium.org, v8-arm-ports@googlegroups.com

Bug: v8:11955
Change-Id: I52a81341e99fabc5fcf9e41ef4d8dd2226092803
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015557
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75843}
      e312038d
  33. 10 Jun, 2021 1 commit
  35. 30 Apr, 2021 1 commit
  37. 22 Mar, 2021 1 commit
  39. 02 Feb, 2021 2 commits
    • Leszek Swirski's avatar
      [arm64/sim] Add a simple backtrace debug command · 5a0b81b4
      Leszek Swirski authored 
      Add a simple backtrace/bt command to the simulator debugger, which does
the frame-pointer stack walk and dumps pc/fp/sp for each frame.

This is strictly less powerful than the full JS stack dump, but can be
used to debug issues with corrupted frames that prevent the JS stack
dumper from working correctly.

Change-Id: I26cc962ab8d22c0a219d6a35548544602aa89418
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666688
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72480}
      5a0b81b4
    • Leszek Swirski's avatar
      [arm64/sim] Add a 'sim' gdb command · 1f72df06
      Leszek Swirski authored 
      Extract out the command processing from Simulator::Debug(), and expose
it to gdb as a new 'sim' command. Example usage:

    (gdb) sim p x15
    (gdb) sim stack

The sim command will execute that one command, and will return to gdb.

For a list of all commands, you can call

    (gdb) sim help

Note that sim won't resume simulator execution until gdb continues
execution; for example, `sim next` will set a breakpoint on the next
instruction, and will return to gdb. The user then has to continue
execution in gdb, at which point the simulator will break. The user can
then re-enter gdb with the gdb command. This will look like this:

    (gdb) sim next
    (gdb) continue
    ...
    sim> gdb
    (gdb) ...

Change-Id: I678e71e2642d8427950b5f7ed65890ceae69e18d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664448
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72479}
      1f72df06
  41. 24 Nov, 2020 1 commit
  43. 17 Nov, 2020 1 commit
  45. 03 Nov, 2020 1 commit
  47. 02 Nov, 2020 1 commit
  49. 22 Jun, 2020 1 commit
  51. 16 Jun, 2020 1 commit
  53. 09 Jun, 2020 1 commit
  55. 17 Mar, 2020 1 commit
  57. 20 Feb, 2020 1 commit
  59. 19 Feb, 2020 1 commit
  61. 17 Feb, 2020 1 commit
  63. 03 Feb, 2020 2 commits
  65. 16 Jan, 2020 1 commit
  67. 17 Sep, 2019 1 commit
  69. 16 Sep, 2019 1 commit
  71. 14 Aug, 2019 1 commit
  73. 24 Jul, 2019 1 commit