Commit 82bf9151 authored by Pierre Langlois's avatar Pierre Langlois Committed by Commit Bot

[arm64][simulator] Enable LOG_ALL with the debugger 'trace' command.

When enabling tracing with the debugger 'trace' command, enable logging
everything instead of just disassembly and general purpose registers. This is
not only more useful but also consistent with the --trace-sim flag.

Change-Id: I4537ceed30edc63f4b3f39f1958ebef0cb303bf1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033172Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#66079}
parent 14d1b9e9
......@@ -3440,13 +3440,12 @@ void Simulator::Debug() {
// trace / t
// -------------------------------------------------------------
} else if (strcmp(cmd, "trace") == 0 || strcmp(cmd, "t") == 0) {
if ((log_parameters() & (LOG_DISASM | LOG_REGS)) !=
(LOG_DISASM | LOG_REGS)) {
PrintF("Enabling disassembly and registers tracing\n");
set_log_parameters(log_parameters() | LOG_DISASM | LOG_REGS);
if ((log_parameters() & LOG_ALL) != LOG_ALL) {
PrintF("Enabling disassembly, registers and memory write tracing\n");
set_log_parameters(log_parameters() | LOG_ALL);
} else {
PrintF("Disabling disassembly and registers tracing\n");
set_log_parameters(log_parameters() & ~(LOG_DISASM | LOG_REGS));
PrintF("Disabling disassembly, registers and memory write tracing\n");
set_log_parameters(log_parameters() & ~LOG_ALL);
}
// break / b
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment