- 17 Jun, 2015 29 commits
-
-
bmeurer authored
Currently the Typer is installed on the Graph, no matter if we actually use the types or not (read: even in the generic pipeline). Also the Typer tries hard to eagerly type nodes during graph building, which takes time, just to remove those types later again, and retype everything from scratch. Plus this is inconsistent, since it only applies to the outermost graph, not the inlined graphs (which are eagerly typed once the nodes are copied). So in summary, what's currently implemented is neither useful nor well defined, so for now we stick to the full typing approach until a proper design for eager typing is available that will actually benefit us. R=rossberg@chromium.org,mstarzinger@chromium.org,jarin@chromium.org Review URL: https://codereview.chromium.org/1192553002 Cr-Commit-Position: refs/heads/master@{#29086}
-
machenbach authored
Revert of Added constructor call on object in InstantiateObject method (patchset #5 id:80001 of https://codereview.chromium.org/1137693003/) Reason for revert: [Sheriff] This breaks layout test expectations: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/437 See: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/437/layout-test-results/fast/dom/create-element-after-stack-overflow-pretty-diff.html Please land a needsmanualrebaseline change on the blink-side before relanding this, if the change was intended. Please include a blink trybot on relanding this. Original issue's description: > Added constructor call on object in InstantiateObject method > > I found after upgrading from 4.2.2 where apinatives.js still > existed to 4.4.56 where everything had been converted to C++ in > api-natives.cc, my constructors for ObjectTemplate instantiated objects > were no longer being called. After investigation, I noticed in > apinatives.js that a new call would handle that, but there was no > corresponding constructor call in api-natives.cc (or anywhere else > along the chain of InstantiateObject), so I added a call to > Execution::Call to actually construct the object. Forgive me if that > isn't the right place to add it (InitializeBody in objects-inl.h also > looked like a good place), or if there's a reason constructors are > not being called. > > I also added myself to the AUTHORS file in this CL. > > Committed: https://crrev.com/e61a957b2a9726294cdd2802a6a2b6e3a9ef657d > Cr-Commit-Position: refs/heads/master@{#29076} TBR=verwaest@chromium.org,svenpanne@chromium.org,dtalley@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1188233002 Cr-Commit-Position: refs/heads/master@{#29085}
-
ulan authored
Delayed tasks can be used to perform non-urgent clean up work. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1179153002 Cr-Commit-Position: refs/heads/master@{#29084}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1157943003 Cr-Commit-Position: refs/heads/master@{#29083}
-
jkummerow authored
- fix truthfulness of comments - use InitializeFieldsWithFiller more consistently - use unsigned comparisons for pointers No change in functionality intended. Bonus: improve JavaScriptFrame::Print() for an enhanced debugging experience: - print PC of each frame - print the function's source also for optimized frames Review URL: https://codereview.chromium.org/1186823003 Cr-Commit-Position: refs/heads/master@{#29082}
-
mstarzinger authored
Now that the graph is being trimmed after generic lowering, we can drop this workaround. The diamond will no longer confuse the scheduler. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1191913002 Cr-Commit-Position: refs/heads/master@{#29081}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1181013011 Cr-Commit-Position: refs/heads/master@{#29080}
-
jkummerow authored
This fixes a bug where new-space GC could be triggered by non-folded allocations for some of the in-object properties, while the object was only partially initialized. BUG=chromium:500497 LOG=y R=ishell@chromium.org Review URL: https://codereview.chromium.org/1182113007 Cr-Commit-Position: refs/heads/master@{#29079}
-
dusan.milosavljevic authored
TEST==mjsunit/asm/double-lo BUG= Review URL: https://codereview.chromium.org/1170923004 Cr-Commit-Position: refs/heads/master@{#29078}
-
bmeurer authored
Up until now that was still mixed with control reduction in the ControlReducer. This separation allows us to remove the horrible Reducer::Finish hack and also do graph trimming at more appropriate places in the pipeline (i.e. trim dead nodes after generic lowering, which can also make nodes dead). R=jarin@chromium.org,mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1188433010 Cr-Commit-Position: refs/heads/master@{#29077}
-
dtalley authored
I found after upgrading from 4.2.2 where apinatives.js still existed to 4.4.56 where everything had been converted to C++ in api-natives.cc, my constructors for ObjectTemplate instantiated objects were no longer being called. After investigation, I noticed in apinatives.js that a new call would handle that, but there was no corresponding constructor call in api-natives.cc (or anywhere else along the chain of InstantiateObject), so I added a call to Execution::Call to actually construct the object. Forgive me if that isn't the right place to add it (InitializeBody in objects-inl.h also looked like a good place), or if there's a reason constructors are not being called. I also added myself to the AUTHORS file in this CL. Review URL: https://codereview.chromium.org/1137693003 Cr-Commit-Position: refs/heads/master@{#29076}
-
verwaest authored
BUG=chromium:479528 LOG=n Review URL: https://codereview.chromium.org/1185373004 Cr-Commit-Position: refs/heads/master@{#29075}
-
verwaest authored
BUG=chromium:500173 LOG=n Review URL: https://codereview.chromium.org/1194513003 Cr-Commit-Position: refs/heads/master@{#29074}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#29073}
-
ulan authored
BUG=chromium:491907,chromium:499815 LOG=NO Review URL: https://codereview.chromium.org/1180203003 Cr-Commit-Position: refs/heads/master@{#29072}
-
svenpanne authored
The remaining uses need some non-mechanical work: * non-standard-layout type, probably due to mixed access control * extended field designators Review URL: https://codereview.chromium.org/1173343006 Cr-Commit-Position: refs/heads/master@{#29071}
-
machenbach authored
Revert of Add %TypedArray% to proto chain (patchset #6 id:100001 of https://codereview.chromium.org/1186733002/) Reason for revert: [Sheriff] Changes layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/429 See e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/429/layout-test-results/inspector/console/console-big-array-pretty-diff.html Please upload a blink side needsmanualrebaseline change first for these tests if the change is intended. Please also add a blink trybot on a reland of this CL. Original issue's description: > Add %TypedArray% to proto chain > > According to the ES6 spec, the main methods and getters shouldn't > be properties of the individual TypedArray objects and prototypes > but instead on %TypedArray% and %TypedArray%.prototype. This > difference is observable through introspection. This patch moves > some methods and getters to the proper place, with the exception > of %TypedArray%.prototype.subarray and harmony methods. These will > be moved in follow-on patches. > > BUG=v8:4085 > LOG=Y > R=adamk > > Committed: https://crrev.com/a10590158260737b256fac3254b4939f48f90095 > Cr-Commit-Position: refs/heads/master@{#29057} TBR=adamk@chromium.org,arv@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1192433003 Cr-Commit-Position: refs/heads/master@{#29070}
-
mstarzinger authored
This fixes CodeGenerator::EnsureSpaceForLazyDeopt to no longer be treated as a lazy deopt site in itself. Calls mark themselves as lazy bailout sites in CodeGenerator::RecordCallPosition, which suffices. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1186353003 Cr-Commit-Position: refs/heads/master@{#29069}
-
erikcorry authored
Tests are already there in mjsuint/regress/regress-latin-1.js R=yangguo@chromium.org BUG=v8:3550 LOG=n Review URL: https://codereview.chromium.org/1188793004 Cr-Commit-Position: refs/heads/master@{#29068}
-
machenbach authored
Revert of Update test262-es6 to 6/11 (patchset #2 id:40001 of https://codereview.chromium.org/1175313003/) Reason for revert: [Sheriff] Please fix test expectations for nosnap before reland. There are 54 tests failing: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/3422 Original issue's description: > Update test262-es6 to 6/11 > > This reverts commit 67b16919 and picks > up the fixes to the yaml parser upstream. > > BUG=N > LOG=N > R=adamk@chromium.org, machenbach@chromium.org > > Committed: https://crrev.com/bc847230610d0518a700a69546d23784e6ce3479 > Cr-Commit-Position: refs/heads/master@{#29056} TBR=adamk@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Review URL: https://codereview.chromium.org/1186093005 Cr-Commit-Position: refs/heads/master@{#29067}
-
machenbach authored
Revert of Skip slow tests in non debug too (patchset #1 id:1 of https://codereview.chromium.org/1184923003/) Reason for revert: [Sheriff] Needed for reverting: https://codereview.chromium.org/1175313003 Original issue's description: > Skip slow tests in non debug too > > BUG=N > LOG=N > TBR=adamk > > Committed: https://crrev.com/17b0f16c760e5b0d51ae87742a864de93b6f4c0b > Cr-Commit-Position: refs/heads/master@{#29058} TBR=adamk@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Review URL: https://codereview.chromium.org/1177223004 Cr-Commit-Position: refs/heads/master@{#29066}
-
yangguo authored
Revert of Serializer: clear string hash for code serializer. (patchset #1 id:1 of https://codereview.chromium.org/1183483006/) Reason for revert: This led to the roll being stuck: https://codereview.chromium.org/1189863003/ Original issue's description: > Serializer: clear string hash for code serializer. > > R=jochen@chromium.org > BUG=v8:4179 > LOG=N > > Committed: https://crrev.com/a0342678e865337215f9195f983c6013b60e7641 > Cr-Commit-Position: refs/heads/master@{#29016} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4179 Review URL: https://codereview.chromium.org/1186173004 Cr-Commit-Position: refs/heads/master@{#29065}
-
bmeurer authored
This optimization just duplicates part of the ToBoolean rule in the Typer, and it doesn't make sense to have adhoc partial typing rules in the ControlReducer anyway. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1189963002 Cr-Commit-Position: refs/heads/master@{#29064}
-
mtrofin authored
Revert "Revert of Decompiler improvements. (patchset #2 id:20001 of https://codereview.chromium.org/1177123002/)" This reverts commit e2ce4681, avoiding the hex->dec changes, and re-introducing the block pretty printing of the original CL. The hex-dec issue would be handled separately. BUG= Review URL: https://codereview.chromium.org/1186273005 Cr-Commit-Position: refs/heads/master@{#29063}
-
bmeurer authored
AstGraphBuilder::BuildToBoolean() can be optimized easily without types, especially since the types are only present on some nodes during graph building. So this optimization is both more efficient and more effective at the same time. We will probably refactor this code into a separate optimization method/class later. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1188503003 Cr-Commit-Position: refs/heads/master@{#29062}
-
mstarzinger authored
This ensures there is a lazy bailout point at the entry of every exception handler so that deoptimized code is not re-entered through caught exceptions. R=jarin@chromium.org TEST=cctest/test-run-deopt/DeoptExceptionHandler Review URL: https://codereview.chromium.org/1173253004 Cr-Commit-Position: refs/heads/master@{#29061}
-
https://codereview.chromium.org/1179703005/machenbach authored
Reason for revert: [Sheriff] gyp change breaks calling gyp on XP: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/2849 Original issue's description: > Update V8 DEPS. > > Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 > > Rolling v8/tools/clang to 4cc9c6714533a07ba02ca01ed04557f055820532 > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/6e7e5e833c8bddf7d6a97cd3c01f0afe5a882bd6 > Cr-Commit-Position: refs/heads/master@{#29059} TBR=v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1180193003 Cr-Commit-Position: refs/heads/master@{#29060}
-
v8-autoroll authored
Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 Rolling v8/tools/clang to 4cc9c6714533a07ba02ca01ed04557f055820532 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1179703005 Cr-Commit-Position: refs/heads/master@{#29059}
-
arv authored
BUG=N LOG=N TBR=adamk Review URL: https://codereview.chromium.org/1184923003 Cr-Commit-Position: refs/heads/master@{#29058}
-
- 16 Jun, 2015 11 commits
-
-
littledan authored
According to the ES6 spec, the main methods and getters shouldn't be properties of the individual TypedArray objects and prototypes but instead on %TypedArray% and %TypedArray%.prototype. This difference is observable through introspection. This patch moves some methods and getters to the proper place, with the exception of %TypedArray%.prototype.subarray and harmony methods. These will be moved in follow-on patches. BUG=v8:4085 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1186733002 Cr-Commit-Position: refs/heads/master@{#29057}
-
arv authored
This reverts commit 67b16919 and picks up the fixes to the yaml parser upstream. BUG=N LOG=N R=adamk@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/1175313003 Cr-Commit-Position: refs/heads/master@{#29056}
-
caitpotter88 authored
BUG=v8:4183 R=arv@chromium.org, rossberg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1184373002 Cr-Commit-Position: refs/heads/master@{#29055}
-
mtrofin authored
Opportunistically removed GreedyAllocator::TryReuseSpillForPhi because it is actually unsuitable for Greedy. It was copied from Linear and it relies on hints, however, the current implementation of hints assumes linear scan. This change doesn't aim to address performance nor correctness for Greedy. BUG= Review URL: https://codereview.chromium.org/1184183002 Cr-Commit-Position: refs/heads/master@{#29054}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1180263006 Cr-Commit-Position: refs/heads/master@{#29053}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1153233003 Cr-Commit-Position: refs/heads/master@{#29052}
-
hablich authored
LOG=n Review URL: https://codereview.chromium.org/1183743003 Cr-Commit-Position: refs/heads/master@{#29051}
-
vogelheim authored
crrev.com/1177163002 should have fixed the issues that broke this last time. Notes: - The current functionality is meant to stay. If you prefer the old way, just set v8_use_external_startup_data=0. - You might notice this if you call d8 via PATH. Either explicitly tell d8 where your external snapshot/built-ins are, or change the build options as above. - This follows Chromium practice, that mostly uses this feature these days. - Other platforms to follow later. BUG= Review URL: https://codereview.chromium.org/1189563004 Cr-Commit-Position: refs/heads/master@{#29050}
-
chunyang.dai authored
This patch includes the following changes. 1, Enable the turbofan backend support for X87 platform. It depends on previous CL: 3fdfebd2. 2, Enable the test cases which are disabled because turbofan for X87 was not enabled. BUG=v8:4135 LOG=N Review URL: https://codereview.chromium.org/1179763004 Cr-Commit-Position: refs/heads/master@{#29049}
-
kozyatinskiy authored
frame->GetExpression always returns the same function. We should iterate through expression stack when we use Function.call.apply for finding actual target. LOG=N BUG=chromium:499479 R=yurys@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1182703003 Cr-Commit-Position: refs/heads/master@{#29048}
-
yangguo authored
We use an alignment prefix for unusual alignment kinds (not kWordAligned). This will cause new objects to be aligned in ReadObject, and back references to be aligned to skip padding. The motivation to change the undefined next sentinel in WeakCell is this: When the deserializer aligns an object, it requires filler maps to already exist to create filler objects as padding. However, deserializing the filler map leads to deserializing NaN, which as heap number is aligned: filler map > meta map > weak cell cache > undefined > NaN If we use the-hole instead of undefined as sentinel, it works. R=jochen@chromium.org,bbudge@chromium.org BUG=v8:4178 LOG=N Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6 Cr-Commit-Position: refs/heads/master@{#29044} Review URL: https://codereview.chromium.org/1179873003 Cr-Commit-Position: refs/heads/master@{#29047}
-