• dtalley's avatar
    Added constructor call on object in InstantiateObject method · e61a957b
    dtalley authored
    I found after upgrading from 4.2.2 where apinatives.js still
    existed to 4.4.56 where everything had been converted to C++ in
    api-natives.cc, my constructors for ObjectTemplate instantiated objects
    were no longer being called.  After investigation, I noticed in
    apinatives.js that a new call would handle that, but there was no
    corresponding constructor call in api-natives.cc (or anywhere else
    along the chain of InstantiateObject), so I added a call to
    Execution::Call to actually construct the object.  Forgive me if that
    isn't the right place to add it (InitializeBody in objects-inl.h also
    looked like a good place), or if there's a reason constructors are
    not being called.
    
    I also added myself to the AUTHORS file in this CL.
    
    Review URL: https://codereview.chromium.org/1137693003
    
    Cr-Commit-Position: refs/heads/master@{#29076}
    e61a957b
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...