- 01 Dec, 2015 1 commit
-
-
yangguo authored
Native scripts must not accidentally pollute the global object. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1490783002 Cr-Commit-Position: refs/heads/master@{#32469}
-
- 30 Nov, 2015 1 commit
-
-
jochen authored
R=vogelheim@chromium.org LOG=n BUG=v8:2487 Review URL: https://codereview.chromium.org/1474353002 Cr-Commit-Position: refs/heads/master@{#32389}
-
- 12 Nov, 2015 1 commit
-
-
ishell authored
This CL fixes several sources of non-predictability by making Platform::MonotonicallyIncreasingTime() the only bottleneck for all time-querying functions and providing PredictablePlatform implementation. Review URL: https://codereview.chromium.org/1415383004 Cr-Commit-Position: refs/heads/master@{#31959}
-
- 12 Oct, 2015 2 commits
-
-
machenbach authored
Revert of Don't compile functions in a context the caller doesn't have access to (patchset #1 id:1 of https://codereview.chromium.org/1393713006/ ) Reason for revert: [Sheriff] Breaks layout tests. Please add needsmanualrebaseline upstream first if intended. E.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2263 (one of them is a timeout that only happens with this commit) Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead, just return undefined. > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > Based on https://codereview.chromium.org/294073002 but taking access > check callbacks into account > > BUG=chromium:541703 > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 > Cr-Commit-Position: refs/heads/master@{#31208} TBR=verwaest@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:541703 Review URL: https://codereview.chromium.org/1395583004 Cr-Commit-Position: refs/heads/master@{#31212}
-
jochen authored
Instead, just return undefined. A side effect of this is that it's no longer possible to compile functions in a detached context. Based on https://codereview.chromium.org/294073002 but taking access check callbacks into account BUG=chromium:541703 R=verwaest@chromium.org LOG=y Review URL: https://codereview.chromium.org/1393713006 Cr-Commit-Position: refs/heads/master@{#31208}
-
- 28 Sep, 2015 1 commit
-
-
jkummerow authored
Replacing it with SMI_ACCESSORS. This change makes accesses to Smi fields in objects more regular (the accessors now always consume/return an int rather than a Smi*), which avoids a bunch of manual Smi::FromInt() and Smi::value() conversions, and is a step on the way towards being able to generate objects-inl.h. Review URL: https://codereview.chromium.org/1371893002 Cr-Commit-Position: refs/heads/master@{#30975}
-
- 27 Aug, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1319003002 Cr-Commit-Position: refs/heads/master@{#30416}
-
- 18 Aug, 2015 4 commits
-
-
Ben Smith authored
TBR=adamk@chromium.org Review URL: https://codereview.chromium.org/1302593002 . Cr-Commit-Position: refs/heads/master@{#30231}
-
binji authored
BUG=chromium:518748 R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/1284683004 Cr-Commit-Position: refs/heads/master@{#30230}
-
binji authored
Don't use exit(), use Shell::Exit() (which calls _exit() instead). This won't run C++ static destructors, atexit() functions, etc., which can occasionally cause flaky failures. BUG=v8:4279 R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1294913005 Cr-Commit-Position: refs/heads/master@{#30229}
-
bradnelson authored
Place a copy of the v8-native-prototype in third_party/wasm. GYP_DEFINES='v8_wasm=1' gclient runhooks BUG=None TEST=None R=titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1294543006 Cr-Commit-Position: refs/heads/master@{#30225}
-
- 14 Aug, 2015 1 commit
-
-
vogelheim authored
- Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1292053002 Cr-Commit-Position: refs/heads/master@{#30174}
-
- 11 Aug, 2015 1 commit
-
-
binji authored
BUG=chromium:518747 R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/1277543006 Cr-Commit-Position: refs/heads/master@{#30099}
-
- 04 Aug, 2015 2 commits
-
-
binji authored
BUG=4399 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1260813008 Cr-Commit-Position: refs/heads/master@{#30016}
-
vogelheim authored
The race occurred when Workers were used. Since Workers call Shell::ExecuteString from a different thread, TSAN (correctly) flags this as a racy write. Solution would be to either synchronize the writes, or to 'lift' the write higher up in the call stack and only write the flag from the main thread. This implements this latter solution. These methods call Shell::ExecuteString, but do *not* set script_executed: - ExecuteInThread: Can only occur is JS has already been executed. - Shell::Load: Callback for JS; so JS has already been executed when we get there. - Shell::RunShell: Interactive shell. We no longer need script_executed once we're here. BUG=v8:4330 LOG=N Review URL: https://codereview.chromium.org/1258303004 Cr-Commit-Position: refs/heads/master@{#30003}
-
- 03 Aug, 2015 1 commit
-
-
binji authored
BUG=chromium:514081 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1264723002 Cr-Commit-Position: refs/heads/master@{#29982}
-
- 30 Jul, 2015 2 commits
-
-
binji authored
script_executed and last_run are read/written by multiple threads. Also externalized_shared_contents_ is modified by multiple threads. BUG=4306 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1252623003 Cr-Commit-Position: refs/heads/master@{#29912}
-
binji authored
When the main thread terminates, it forcibly terminates all Worker threads. When this happens, the threads objects were only half-created; they had a JavaScript Worker object, but not a C++ worker object. This CL fixes that bug, as well as some other fixes: * Signatures on Worker methods * Use SetAlignedPointerFromInternalField instead of using an External. * Remove state_ from Worker. Simplify to atomic bool running_. BUG=chromium:511880 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1255563002 Cr-Commit-Position: refs/heads/master@{#29911}
-
- 23 Jul, 2015 3 commits
-
-
Adam Klein authored
TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/1246983004 . Cr-Commit-Position: refs/heads/master@{#29824}
-
yangguo authored
Nobody seems to use it. A good alternative is rlwrap. R=jochen@chromium.org Review URL: https://codereview.chromium.org/1250223002 Cr-Commit-Position: refs/heads/master@{#29810}
-
yangguo authored
The code is unmaintained and full of errors... but this CL wipes them all away. Nobody seems to use it anyways. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1243213004 Cr-Commit-Position: refs/heads/master@{#29801}
-
- 20 Jul, 2015 2 commits
-
-
jochen authored
R=yangguo@chromium.org BUG=chromium:511988 LOG=n Review URL: https://codereview.chromium.org/1246643002 Cr-Commit-Position: refs/heads/master@{#29757}
-
jochen authored
Original issue's description: > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Review URL: https://codereview.chromium.org/1239053004 BUG=v8:4134 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1235603004 Cr-Commit-Position: refs/heads/master@{#29742}
-
- 17 Jul, 2015 3 commits
-
-
caitpotter88 authored
Prevents fatal error in debug builds BUG=v8:4271, 506954 R=binji@chromium.org LOG=N Committed: https://crrev.com/43ce9c6f101c4224addd9a54e0c39963188dc7fa Cr-Commit-Position: refs/heads/master@{#29524} Review URL: https://codereview.chromium.org/1214053004 Cr-Commit-Position: refs/heads/master@{#29737}
-
machenbach authored
Revert of Make d8 stop using to-be-deprecated APIs (patchset #3 id:40001 of https://codereview.chromium.org/1239053004/) Reason for revert: [Sheriff] Breaks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20code%20serializer/builds/3400 Original issue's description: > Make d8 stop using to-be-deprecated APIs > > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Committed: https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 > Cr-Commit-Position: refs/heads/master@{#29726} TBR=yangguo@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4134 Review URL: https://codereview.chromium.org/1240993003 Cr-Commit-Position: refs/heads/master@{#29730}
-
jochen authored
BUG=v8:4134 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1239053004 Cr-Commit-Position: refs/heads/master@{#29726}
-
- 16 Jul, 2015 1 commit
-
-
binji authored
Calling quit() from d8 will call exit(), which will run static destructors. If context_mutex_ is statically allocated, pthread_mutex_destroy will be called. When running d8 in "isolates" mode, another thread may be running. If it calls CreateEvaluationContext, it will lock the context_mutex_. If the mutex is destroyed while it is locked, it will return an error. This CL changes the Mutex to a LazyMutex, which will leak instead of being destroyed. BUG=v8:4279 R=jarin@chromium.org R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1240553003 Cr-Commit-Position: refs/heads/master@{#29709}
-
- 15 Jul, 2015 1 commit
-
-
epertoso authored
R=jochen@chromium.org LOG=y BUG= Review URL: https://codereview.chromium.org/1209403005 Cr-Commit-Position: refs/heads/master@{#29680}
-
- 14 Jul, 2015 4 commits
-
-
binji authored
Reland of d8 workers: make sure Shell::Quit is only called once (patchset #1 id:1 of https://codereview.chromium.org/1235083004/) Reason for revert: Looks like the failure is unrelated to my change (still fails after the revert). See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/856/steps/webkit_unit_tests/logs/stdio Original issue's description: > Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5 id:80001 of https://codereview.chromium.org/1230403003/) > > Reason for revert: > Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio > > Original issue's description: > > d8 workers: make sure Shell::Quit is only called once > > > > When running with isolates, Quit can be called simultaneously by two threads. > > If this happens, then both threads try to clean up the Workers, which could > > crash. > > > > BUG=v8:4279 > > R=jarin@chromium.org > > R=machenbach@chromium.org > > LOG=n > > > > Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c > > Cr-Commit-Position: refs/heads/master@{#29654} > > TBR=jarin@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4279 > > Committed: https://crrev.com/6b2c6eb75678747afca59b4a78ace597e218145d > Cr-Commit-Position: refs/heads/master@{#29656} TBR=jarin@chromium.org,machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4279 Review URL: https://codereview.chromium.org/1224203004 Cr-Commit-Position: refs/heads/master@{#29663}
-
binji authored
Note: the previous try was reverted for occasional flaky tests. This continued after the revert, and should be fixed by https://codereview.chromium.org/1226143003. Previously, the serialization code would call Externalize for every transferred ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If the buffer is already externalized, we should call GetContents instead. Also fix use-after-free bug when transferring ArrayBuffers. The transferred ArrayBuffer must be internalized in the new isolate, or be managed by the Shell. The current code gives it to the isolate externalized and frees it immediately afterward when the SerializationData object is destroyed. BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1223813008 Cr-Commit-Position: refs/heads/master@{#29658}
-
binji authored
Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5 id:80001 of https://codereview.chromium.org/1230403003/) Reason for revert: Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio Original issue's description: > d8 workers: make sure Shell::Quit is only called once > > When running with isolates, Quit can be called simultaneously by two threads. > If this happens, then both threads try to clean up the Workers, which could > crash. > > BUG=v8:4279 > R=jarin@chromium.org > R=machenbach@chromium.org > LOG=n > > Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c > Cr-Commit-Position: refs/heads/master@{#29654} TBR=jarin@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4279 Review URL: https://codereview.chromium.org/1235083004 Cr-Commit-Position: refs/heads/master@{#29656}
-
binji authored
When running with isolates, Quit can be called simultaneously by two threads. If this happens, then both threads try to clean up the Workers, which could crash. BUG=v8:4279 R=jarin@chromium.org R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1230403003 Cr-Commit-Position: refs/heads/master@{#29654}
-
- 13 Jul, 2015 1 commit
-
-
binji authored
* Fix embarrassing bug in DeserializeValue, using a static buffer in multithreaded code. * Fix thread leak when Worker.terminate() is not called. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1226143003 Cr-Commit-Position: refs/heads/master@{#29626}
-
- 09 Jul, 2015 1 commit
-
-
binji authored
When quit() is called, d8 shell exits without cleanup. If a worker is running, it might be holding the context_mutex_, which if destroyed will DCHECK. BUG=4279 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1231473002 Cr-Commit-Position: refs/heads/master@{#29557}
-
- 08 Jul, 2015 1 commit
-
-
binji authored
This one occurred when serializing an object. When the property getter threw an exception, that value was skipped, but the property count wasn't updated. The deserializer then tried to deserialize the wrong value. BUG=chromium:506549 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1220193004 Cr-Commit-Position: refs/heads/master@{#29541}
-
- 07 Jul, 2015 3 commits
-
-
machenbach authored
Revert of [d8] bounds-check before getting Shell::Worker internal field (patchset #4 id:80001 of https://codereview.chromium.org/1214053004/) Reason for revert: [Sheriff] Fails here: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/4737 Original issue's description: > [d8] bounds-check before getting Shell::Worker internal field > > Prevents fatal error in debug builds > > BUG=v8:4271 > R=binji@chromium.org > LOG=N > > Committed: https://crrev.com/43ce9c6f101c4224addd9a54e0c39963188dc7fa > Cr-Commit-Position: refs/heads/master@{#29524} TBR=binji@chromium.org,jochen@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4271 Review URL: https://codereview.chromium.org/1215333012 Cr-Commit-Position: refs/heads/master@{#29525}
-
caitpotter88 authored
Prevents fatal error in debug builds BUG=v8:4271 R=binji@chromium.org LOG=N Review URL: https://codereview.chromium.org/1214053004 Cr-Commit-Position: refs/heads/master@{#29524}
-
machenbach authored
Revert of Fix bug when transferring SharedArrayBuffer to multiple Workers. (patchset #3 id:40001 of https://codereview.chromium.org/1215233004/) Reason for revert: [Sheriff] Test hangs sometimes and times out flakily. E.g.: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse3/builds/4551/steps/Check%20%28flakes%29/logs/d8-worker-sharedarray.. Original issue's description: > Fix bug when transferring SharedArrayBuffer to multiple Workers. > > Previously, the serialization code would call Externalize for every transferred > ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If > the buffer is already externalized, we should call GetContents instead. > > Also fix use-after-free bug when transferring ArrayBuffers. The transferred > ArrayBuffer must be internalized in the new isolate, or be managed by the > Shell. The current code gives it to the isolate externalized and frees it > immediately afterward when the SerializationData object is destroyed. > > BUG=chromium:497295 > R=jarin@chromium.org > LOG=n > > Committed: https://crrev.com/dd7962bf7838f8379ba776ee6b7b0e4d3bec2140 > Cr-Commit-Position: refs/heads/master@{#29499} TBR=jarin@chromium.org,jochen@chromium.org,binji@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497295 Review URL: https://codereview.chromium.org/1224843008 Cr-Commit-Position: refs/heads/master@{#29506}
-
- 06 Jul, 2015 1 commit
-
-
binji authored
Previously, the serialization code would call Externalize for every transferred ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If the buffer is already externalized, we should call GetContents instead. Also fix use-after-free bug when transferring ArrayBuffers. The transferred ArrayBuffer must be internalized in the new isolate, or be managed by the Shell. The current code gives it to the isolate externalized and frees it immediately afterward when the SerializationData object is destroyed. BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1215233004 Cr-Commit-Position: refs/heads/master@{#29499}
-
- 01 Jul, 2015 1 commit
-
-
binji authored
This is more consistent with the DOM API, and is clearer w.r.t. which values are available in the lexical environment of the Worker. BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1218553004 Cr-Commit-Position: refs/heads/master@{#29426}
-