1. 01 Dec, 2015 1 commit
  2. 30 Nov, 2015 1 commit
  3. 12 Nov, 2015 1 commit
  4. 12 Oct, 2015 2 commits
  5. 28 Sep, 2015 1 commit
    • jkummerow's avatar
      objects-inl.h: Remove ACCESSORS_TO_SMI macro · 7117acd2
      jkummerow authored
      Replacing it with SMI_ACCESSORS.
      This change makes accesses to Smi fields in objects more regular (the
      accessors now always consume/return an int rather than a Smi*), which
      avoids a bunch of manual Smi::FromInt() and Smi::value() conversions,
      and is a step on the way towards being able to generate objects-inl.h.
      
      Review URL: https://codereview.chromium.org/1371893002
      
      Cr-Commit-Position: refs/heads/master@{#30975}
      7117acd2
  6. 27 Aug, 2015 1 commit
  7. 18 Aug, 2015 4 commits
  8. 14 Aug, 2015 1 commit
    • vogelheim's avatar
      Rework startup-data-util. · c69e2eae
      vogelheim authored
      - Make the API look like v8::V8::InitializeICU.
        (That is: A static method call, not an object to be created on the stack.)
      - Fix path separator on Windows, by calling base::OS::isPathSeparator.
      - Move into API, so that it can be called by hello-world & friends.
      - Actually call it from hello-world and friends.
      
      R=jochen@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1292053002
      
      Cr-Commit-Position: refs/heads/master@{#30174}
      c69e2eae
  9. 11 Aug, 2015 1 commit
  10. 04 Aug, 2015 2 commits
    • binji's avatar
      [d8 Workers] Throw when calling Worker constructor without new · 890c4d9d
      binji authored
      BUG=4399
      R=jarin@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1260813008
      
      Cr-Commit-Position: refs/heads/master@{#30016}
      890c4d9d
    • vogelheim's avatar
      Avoid data race when writing Shell::options.script_executed. · e045b78d
      vogelheim authored
      The race occurred when Workers were used. Since Workers call
      Shell::ExecuteString from a different thread, TSAN (correctly) flags
      this as a racy write. Solution would be to either synchronize the writes,
      or to 'lift' the write higher up in the call stack and only write the flag
      from the main thread. This implements this latter solution.
      
      These methods call Shell::ExecuteString, but do *not* set script_executed:
      - ExecuteInThread: Can only occur is JS has already been executed.
      - Shell::Load: Callback for JS; so JS has already been executed when
                     we get there.
      - Shell::RunShell: Interactive shell. We no longer need script_executed once
                         we're here.
      
      BUG=v8:4330
      LOG=N
      
      Review URL: https://codereview.chromium.org/1258303004
      
      Cr-Commit-Position: refs/heads/master@{#30003}
      e045b78d
  11. 03 Aug, 2015 1 commit
  12. 30 Jul, 2015 2 commits
    • binji's avatar
      [d8] Fix tsan bugs · 053b8434
      binji authored
      script_executed and last_run are read/written by multiple threads. Also
      externalized_shared_contents_ is modified by multiple threads.
      
      BUG=4306
      R=jarin@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1252623003
      
      Cr-Commit-Position: refs/heads/master@{#29912}
      053b8434
    • binji's avatar
      [d8 Workers] Fix bug creating Worker during main thread termination · a87db3de
      binji authored
      When the main thread terminates, it forcibly terminates all Worker threads.
      When this happens, the threads objects were only half-created; they had a
      JavaScript Worker object, but not a C++ worker object.
      
      This CL fixes that bug, as well as some other fixes:
      * Signatures on Worker methods
      * Use SetAlignedPointerFromInternalField instead of using an External.
      * Remove state_ from Worker. Simplify to atomic bool running_.
      
      BUG=chromium:511880
      R=jarin@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1255563002
      
      Cr-Commit-Position: refs/heads/master@{#29911}
      a87db3de
  13. 23 Jul, 2015 3 commits
  14. 20 Jul, 2015 2 commits
  15. 17 Jul, 2015 3 commits
  16. 16 Jul, 2015 1 commit
    • binji's avatar
      d8: Leak context_mutex_ so it will never be destroyed while locked · 162f116a
      binji authored
      Calling quit() from d8 will call exit(), which will run static destructors. If
      context_mutex_ is statically allocated, pthread_mutex_destroy will be called.
      
      When running d8 in "isolates" mode, another thread may be running. If it calls
      CreateEvaluationContext, it will lock the context_mutex_. If the mutex is
      destroyed while it is locked, it will return an error.
      
      This CL changes the Mutex to a LazyMutex, which will leak instead of being
      destroyed.
      
      BUG=v8:4279
      R=jarin@chromium.org
      R=machenbach@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1240553003
      
      Cr-Commit-Position: refs/heads/master@{#29709}
      162f116a
  17. 15 Jul, 2015 1 commit
  18. 14 Jul, 2015 4 commits
  19. 13 Jul, 2015 1 commit
  20. 09 Jul, 2015 1 commit
  21. 08 Jul, 2015 1 commit
  22. 07 Jul, 2015 3 commits
  23. 06 Jul, 2015 1 commit
    • binji's avatar
      Fix bug when transferring SharedArrayBuffer to multiple Workers. · dd7962bf
      binji authored
      Previously, the serialization code would call Externalize for every transferred
      ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If
      the buffer is already externalized, we should call GetContents instead.
      
      Also fix use-after-free bug when transferring ArrayBuffers. The transferred
      ArrayBuffer must be internalized in the new isolate, or be managed by the
      Shell. The current code gives it to the isolate externalized and frees it
      immediately afterward when the SerializationData object is destroyed.
      
      BUG=chromium:497295
      R=jarin@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1215233004
      
      Cr-Commit-Position: refs/heads/master@{#29499}
      dd7962bf
  24. 01 Jul, 2015 1 commit