- 10 Sep, 2015 14 commits
-
-
bmeurer authored
Replace the ADD, SUB, etc. builtins with proper runtime implementations, and expose them as runtime calls that can be used by the code stubs and the interpreter (for now). Also remove all the support runtime functions for ADD, SUB and friends, namely %NumberAdd, %NumberSub, and so on. R=mstarzinger@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg Review URL: https://codereview.chromium.org/1333843002 Cr-Commit-Position: refs/heads/master@{#30680}
-
ishell authored
This fixes the Runtime_DeclareGlobals performance regression caused by a huge number of global var declarations mentioned in chromium:517778. BUG=chromium:517778 LOG=N Review URL: https://codereview.chromium.org/1335633002 Cr-Commit-Position: refs/heads/master@{#30679}
-
fedor authored
When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678}
-
mvstanton authored
Narrowed the scope of the fix, to make a best effort to avoid DEOPT in case the hole is loaded, but not to permute the choice of a consolidated load in case that effort fails. BUG=chromium:530005 LOG=N Review URL: https://codereview.chromium.org/1330233004 Cr-Commit-Position: refs/heads/master@{#30677}
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1330153003 Cr-Commit-Position: refs/heads/master@{#30676}
-
mstarzinger authored
R=conradw@chromium.org Review URL: https://codereview.chromium.org/1317033009 Cr-Commit-Position: refs/heads/master@{#30675}
-
mstarzinger authored
The two tests in question got a lot slower and started to timeout now that the C++ fallback implementation of the %Arguments intrinsics is composable with respect to inlining. R=bmeurer@chromium.org,machenbach@chromium.org Review URL: https://codereview.chromium.org/1330203003 Cr-Commit-Position: refs/heads/master@{#30674}
-
mstarzinger authored
This removes the aforementioned flag which has been on by default for a while now. Note that this does not control optimization decisions, only the last-resort bailout in the graph builder. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1335543002 Cr-Commit-Position: refs/heads/master@{#30673}
-
chunyang.dai authored
port ba7b6413 (r30649) original commit message: This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and c BUG= Review URL: https://codereview.chromium.org/1330993004 Cr-Commit-Position: refs/heads/master@{#30672}
-
bmeurer authored
There are now two runtime entries %NewClosure and %NewClosure_Tenured, with the same signature (one parameter, the SharedFunctionInfo, and the context of the caller). Also remove the HFunctionLiteral special case instruction from Crankshaft, as HCallWithDescriptor with FastNewClosureStub or HCallRuntime with either %NewClosure or %NewClosure_Tenured can easily do that for you. Also remove the redundant context parameter from the JSCreateClosure operator, because every JS operator already takes a context input. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg Review URL: https://codereview.chromium.org/1329293003 Cr-Commit-Position: refs/heads/master@{#30671}
-
Djordje.Pesic authored
Fix illegal use of at register when ldc1 and sdc1 are called. Added dchecks to prevent such a usage. TEST=mjsunit/asm/float64array-negative-offset(r6), mjsunit/asm/float64array-outofbounds(r6) Review URL: https://codereview.chromium.org/1323763002 Cr-Commit-Position: refs/heads/master@{#30670}
-
chunyang.dai authored
port b37907ff (r30648). original commit message: The number of actual arguments should always be available, there's no point in trying to optimize away a simple assignment of an immediate to a register before some calls. The main motivation is to have a consistent state at the beginning of every function. Currently the arguments register (i.e. rax or eax) either contains the number of arguments or some random garbage depending on whether the callsite decided that the callee might need the information or not. This causes trouble with runtime implementations of functions that do not set internal_formal_parameter_count to the DontAdaptArguments sentinel (we don't have any of those yet), but also makes it impossible to sanity check the arguments in the callee, because the callee doesn't know whether the caller decided to pass the number of arguments or random garbage. BUG= Review URL: https://codereview.chromium.org/1335453002 Cr-Commit-Position: refs/heads/master@{#30669}
-
chunyang.dai authored
port ccbb4ff0 (r30629) original commit message: The new Call and CallFunction builtins supersede the current CallFunctionStub (and CallIC magic) and will be the single bottleneck for all calling, including the currently special Function.prototype.call and Function.prototype.apply builtins, which had handwritten (and not fully compliant) versions of CallFunctionStub, and also the CallIC(s), which where also slightly different. This also reduces the overhead for API function calls, which is still unnecessary high, but let's do that step-by-step. This also fixes a bunch of cases where the implicit ToObject for sloppy receivers was done in the wrong context (in the caller context instead of the callee context), which basically meant that we allowed cross context access to %ObjectPrototype%. BUG= Review URL: https://codereview.chromium.org/1332703002 Cr-Commit-Position: refs/heads/master@{#30668}
-
chunyang.dai authored
port db2ba190 (r30634). original commit message: The semantics of the %_CallFunction intrinsic seem to be very unclear, which resulted in a lot of bugs. Especially the combination with %IsSloppyModeFunction is always a bug, because the receiver would be wrapped in the wrong context. So the %IsSloppyModeFunction helper is gone now, and many of the buggy uses of %_CallFunction are also eliminated. If you ever need to call something with a different receiver, then %_Call is your friend now. It does what you want and implements the call sequence fully (and correct). Review URL: https://codereview.chromium.org/1336443002 Cr-Commit-Position: refs/heads/master@{#30667}
-
- 09 Sep, 2015 19 commits
-
-
mbrandy authored
R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1303333009 Cr-Commit-Position: refs/heads/master@{#30666}
-
mtrofin authored
A LiveRange is identified by 2 integers: the vreg() of its TopLevel, which is the virtual register (operand) ID; and a relative_id(), which has no meaning in the program, but is valuable in debugging or tracing scenarios. This change ensures that relative_id is unique even in cases of splinter ranges and their children. Review URL: https://codereview.chromium.org/1318493005 Cr-Commit-Position: refs/heads/master@{#30665}
-
mstarzinger authored
This desugars the loading of the super constructor function using the %GetPrototype runtime function in the parser. The produced code remains the same while fewer parts need to be glued together. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1321343004 Cr-Commit-Position: refs/heads/master@{#30664}
-
mstarzinger authored
R=binji@chromium.org Review URL: https://codereview.chromium.org/1327743004 Cr-Commit-Position: refs/heads/master@{#30663}
-
mbrandy authored
Port b37907ff Original commit message: The number of actual arguments should always be available, there's no point in trying to optimize away a simple assignment of an immediate to a register before some calls. The main motivation is to have a consistent state at the beginning of every function. Currently the arguments register (i.e. rax or eax) either contains the number of arguments or some random garbage depending on whether the callsite decided that the callee might need the information or not. This causes trouble with runtime implementations of functions that do not set internal_formal_parameter_count to the DontAdaptArguments sentinel (we don't have any of those yet), but also makes it impossible to sanity check the arguments in the callee, because the callee doesn't know whether the caller decided to pass the number of arguments or random garbage. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1314353007 Cr-Commit-Position: refs/heads/master@{#30662}
-
mbrandy authored
PPC: On a call to Array(), we patched a call ic. This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. Port ba7b6413 R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1322103005 Cr-Commit-Position: refs/heads/master@{#30661}
-
rmcilroy authored
Adds support for property store operations via Store/KeyedStore ICs. Adds the following bytecodes: - StoreIC - KeyedStoreIC The --vector_store flag is now required for --ignition. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1319833004 Cr-Commit-Position: refs/heads/master@{#30660}
-
mvstanton authored
Update the consolidated load case to carefully chose the load mode based on the consolidated elements kind. BUG=v8:4380 LOG=N Review URL: https://codereview.chromium.org/1329793003 Cr-Commit-Position: refs/heads/master@{#30659}
-
mbrandy authored
Fix additional cases where the AIX compiler reports that a variable may be used uninitialized. R=danno@chromium.org, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1323313003 Cr-Commit-Position: refs/heads/master@{#30658}
-
mbrandy authored
Port 40fbed06 Original commit message: The last changes for vector store functionality, they are in 3 areas: 1) The new vector [keyed] store code stubs - implementation. 2) IC and handler compiler adjustments 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1330883002 Cr-Commit-Position: refs/heads/master@{#30657}
-
mbrandy authored
Port ccbb4ff0 Original commit message: The new Call and CallFunction builtins supersede the current CallFunctionStub (and CallIC magic) and will be the single bottleneck for all calling, including the currently special Function.prototype.call and Function.prototype.apply builtins, which had handwritten (and not fully compliant) versions of CallFunctionStub, and also the CallIC(s), which where also slightly different. This also reduces the overhead for API function calls, which is still unnecessary high, but let's do that step-by-step. This also fixes a bunch of cases where the implicit ToObject for sloppy receivers was done in the wrong context (in the caller context instead of the callee context), which basically meant that we allowed cross context access to %ObjectPrototype%. MIPS and MIPS64 ports contributed by akos.palfi@imgtec.com. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1327093002 Cr-Commit-Position: refs/heads/master@{#30656}
-
mbrandy authored
Port db2ba190 Original commit message: The semantics of the %_CallFunction intrinsic seem to be very unclear, which resulted in a lot of bugs. Especially the combination with %IsSloppyModeFunction is always a bug, because the receiver would be wrapped in the wrong context. So the %IsSloppyModeFunction helper is gone now, and many of the buggy uses of %_CallFunction are also eliminated. If you ever need to call something with a different receiver, then %_Call is your friend now. It does what you want and implements the call sequence fully (and correct). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1310303008 Cr-Commit-Position: refs/heads/master@{#30655}
-
mstarzinger authored
This makes the C++ fallback implementations for the two intrinsics, %Arguments and %ArgumentsLength composable with respect to inlining. Using deoptimization information gives us accurate data here. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-4374 BUG=v8:4374 LOG=n Review URL: https://codereview.chromium.org/1328363002 Cr-Commit-Position: refs/heads/master@{#30654}
-
balazs.kilvady authored
Port ba7b6413 Original commit message: This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. BUG= Review URL: https://codereview.chromium.org/1324093005 Cr-Commit-Position: refs/heads/master@{#30653}
-
bmeurer authored
This has been dead code for quite a while now. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1314353006 Cr-Commit-Position: refs/heads/master@{#30652}
-
mstarzinger authored
R=bmeurer@chromium.org BUG=chromium:527364 LOG=n Review URL: https://codereview.chromium.org/1322203005 Cr-Commit-Position: refs/heads/master@{#30651}
-
jochen authored
BUG=none R=danno@chromium.org LOG=y Review URL: https://codereview.chromium.org/1308953011 Cr-Commit-Position: refs/heads/master@{#30650}
-
mvstanton authored
On a call to Array(), we patched a call ic. This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. BUG= Review URL: https://codereview.chromium.org/1332563003 Cr-Commit-Position: refs/heads/master@{#30649}
-
bmeurer authored
The number of actual arguments should always be available, there's no point in trying to optimize away a simple assignment of an immediate to a register before some calls. The main motivation is to have a consistent state at the beginning of every function. Currently the arguments register (i.e. rax or eax) either contains the number of arguments or some random garbage depending on whether the callsite decided that the callee might need the information or not. This causes trouble with runtime implementations of functions that do not set internal_formal_parameter_count to the DontAdaptArguments sentinel (we don't have any of those yet), but also makes it impossible to sanity check the arguments in the callee, because the callee doesn't know whether the caller decided to pass the number of arguments or random garbage. BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1330033002 Cr-Commit-Position: refs/heads/master@{#30648}
-
- 08 Sep, 2015 7 commits
-
-
caitpotter88 authored
BUG=v8:2160 LOG=N R=adamk, rossberg, wingo Review URL: https://codereview.chromium.org/1317113007 Cr-Commit-Position: refs/heads/master@{#30647}
-
paul.lind authored
Fix some dodgy temp-register usage and remove some unnecessary push/pop's. BUG= Review URL: https://codereview.chromium.org/1324553004 Cr-Commit-Position: refs/heads/master@{#30646}
-
dusan.m.milosavljevic authored
The instruction selection for following sequences is improved: 113: Word64Sar(107, 91) : Internal/Any 114: TruncateInt64ToInt32(113) : Signed32/UntaggedSigned32 115: ChangeInt32ToFloat64(114) : Signed32/UntaggedFloat64 TEST=unittests/InstructionSelectorTest.ChangesFromToSmi BUG= Review URL: https://codereview.chromium.org/1318153006 Cr-Commit-Position: refs/heads/master@{#30645}
-
balazs.kilvady authored
For simulator optimization we modified Instruction::InstructionType() function so a simpler but less complete InstructionType() function used by default. This fix enables the full InstructionType checking to properly decode a dd-constant label as unsupported opcode, rather than aborting. BUG=chromium:528875 LOG=NO Review URL: https://codereview.chromium.org/1314673010 Cr-Commit-Position: refs/heads/master@{#30644}
-
paul.lind authored
Porting mistake in ccbb4ff0 '[builtins] Unify the various versions of [[Call]] with a Call builtin.', which only showed as debug assertion in later commit db2ba190 '[runtime] Replace many buggy uses of %_CallFunction with %_Call.' Use temporary register rather than push/pop of 'object' register. BUG= TEST=cctest/test-api/SetFunctionEntryHook, cctest/test-serialize/PerIsolateSnapshotBlobs, ... Review URL: https://codereview.chromium.org/1309163006 Cr-Commit-Position: refs/heads/master@{#30643}
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1314543014 Cr-Commit-Position: refs/heads/master@{#30642}
-
ulan authored
This moves incremental marking steps from gc-idle-time-handler and heap to the new incremental marking task. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1265423002 Cr-Commit-Position: refs/heads/master@{#30641}
-