- 31 Mar, 2017 1 commit
-
-
hpayer authored
Revert of [heap] Take page lock when scavenging old to new references in Scavenger. (patchset #2 id:20001 of https://codereview.chromium.org/2781363002/ ) Reason for revert: This results in a deadlock when the scavenger decides to perform sweeping and re-grabs the same mutex. Original issue's description: > [heap] Take page lock when scavenging old to new references in Scavenger. > > BUG=v8:5807 > > Review-Url: https://codereview.chromium.org/2781363002 > Cr-Commit-Position: refs/heads/master@{#44268} > Committed: https://chromium.googlesource.com/v8/v8/+/4024e6a1bb0b803a5cd16fcd11f39cc305b943c6 TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5807 Review-Url: https://codereview.chromium.org/2786313003 Cr-Commit-Position: refs/heads/master@{#44302}
-
- 30 Mar, 2017 1 commit
-
-
hpayer authored
BUG=v8:5807 Review-Url: https://codereview.chromium.org/2781363002 Cr-Commit-Position: refs/heads/master@{#44268}
-
- 29 Mar, 2017 1 commit
-
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2783873002 Cr-Commit-Position: refs/heads/master@{#44236}
-
- 24 Mar, 2017 2 commits
-
-
mlippautz authored
Require the use of MarkingState when going through ObjectMarking and friends. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2770253002 Cr-Commit-Position: refs/heads/master@{#44123}
-
hpayer authored
This reverts commit 00d3098d. BUG=chromium:694255,v8:6138 Review-Url: https://codereview.chromium.org/2773093002 Cr-Commit-Position: refs/heads/master@{#44100}
-
- 23 Mar, 2017 1 commit
-
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: Ie9d39306c3baf2462ea5eee4f5a5ff436912744e Reviewed-on: https://chromium-review.googlesource.com/458423Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#44077}
-
- 22 Mar, 2017 2 commits
-
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: Ic4cc354160b84267a4d930734120b68c2b7ba092 Reviewed-on: https://chromium-review.googlesource.com/458351Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#44030}
-
Michael Lippautz authored
Use MarkingState to abstract over the different sets of markbits. BUG=chromium:651354 Change-Id: I1635eb0d441be2aeed19f0ed91999f0f0f1bbffc Reviewed-on: https://chromium-review.googlesource.com/458398Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#44024}
-
- 21 Mar, 2017 2 commits
-
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: I15b2ee763882af369bf4b6274ce04e52dfb657e7 Reviewed-on: https://chromium-review.googlesource.com/457321 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43980}
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: Idcd7780f53ad07b3d782a66455f9c60addc2418d Reviewed-on: https://chromium-review.googlesource.com/457317 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#43971}
-
- 20 Mar, 2017 1 commit
-
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2764473002 Cr-Commit-Position: refs/heads/master@{#43943}
-
- 17 Mar, 2017 1 commit
-
-
neis authored
This is a first step towards moving Turbofan code generation off the main thread. Summary of the changes: - AssemblerBase no longer has a pointer to the isolate. Instead, its constructor receives the few things that it needs from the isolate (on most architectures this is just the serializer_enabled flag). - RelocInfo no longer has a pointer to the isolate. Instead, the functions that need it take it as an argument. (There are currently still a few that implicitly access the isolate through a HeapObject.) - The MacroAssembler now explicitly holds a pointer to the isolate (before, it used to get it from the Assembler). - The jit_cookie also moved from AssemblerBase to the MacroAssemblers, since it's not used at all in the Assemblers. - A few architectures implemented parts of the Assembler with the help of a Codepatcher that is based on MacroAssembler. Since the Assembler no longer has the isolate, but the MacroAssembler still needs it, this doesn't work anymore. Instead, these Assemblers now use a new PatchingAssembler. BUG=v8:6048 Review-Url: https://codereview.chromium.org/2732273003 Cr-Commit-Position: refs/heads/master@{#43890}
-
- 16 Mar, 2017 1 commit
-
-
Michael Lippautz authored
Adjusting the count requires us to call into Semaphore::WaitFor which even on a z840 introduces a pause of at least 50us. We often call in here from the unmapper that tries to add pages. E.g. for reducing the new space size of 8M we call this for 16x2 pages, resulting in a pause of 1.6ms for just checking the status of the sweeper tasks. Avoiding reducing the count reduces the epilogue times. Example: FB infinite scroll: Before: heap.epilogue len: 102 min: 0.01 max: 4.83 avg: 0.140196078431 [0,5[: 102 After: heap.epilogue len: 106 min: 0.01 max: 0.24 avg: 0.0260377358491 [0,5[: 106 BUG= Change-Id: I296c20ae3ac4b65218e4e038a9dbce504160a764 Reviewed-on: https://chromium-review.googlesource.com/455839 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43863}
-
- 15 Mar, 2017 1 commit
-
-
Michael Lippautz authored
This fixes a TSAN data race when writing the forwarding pointer in MigrateObject and reading the object as a LayoutDescriptor when trying to figure out the layout of another object in parallel. BUG=chromium:701732 Change-Id: I1e291fa1afb42771244e1346680164de71c3a838 Reviewed-on: https://chromium-review.googlesource.com/455817Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43826}
-
- 08 Mar, 2017 3 commits
-
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2492263002 Cr-Commit-Position: refs/heads/master@{#43679}
-
Michael Lippautz authored
Reuse the last LAB's unused area for further newspace allocation. This is relevant when we expect GCs that use evacuation to compact down new space to just live bytes for single tasks. BUG=chromium:651354 Change-Id: Ic418521d98f418a93d3748b824e3ddb6ff7a40c3 Reviewed-on: https://chromium-review.googlesource.com/451398 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43670}
-
Michael Lippautz authored
Markbits should be verified in VerifyMarking and friends. The function may also be used then e.g. iterating just black objects while incremental marking is active for the fast promotion mode. BUG=chromium:694255 Change-Id: Ia719a983fec27b2bae03f8c6c3332003a10e8823 Reviewed-on: https://chromium-review.googlesource.com/451363Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43669}
-
- 03 Mar, 2017 1 commit
-
-
Michael Lippautz authored
Second part of relanding d2c093bc. BUG=chromium:651354 Change-Id: I4d48e870ac3a630ee1c286a86e630b8cf52cadf9 Reviewed-on: https://chromium-review.googlesource.com/449712Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43580}
-
- 02 Mar, 2017 2 commits
-
-
Michael Lippautz authored
Enbedders should switch to EmbedderHeapTracer API. BUG=v8:5828 Change-Id: I82f2bc583d246617865a17f5904e02cd35f92fec Reviewed-on: https://chromium-review.googlesource.com/448539Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43551}
-
Michael Lippautz authored
First part of relanding d2c093bc. BUG=chromium:651354 Change-Id: I34ebea331d482d5039626ccff48b11ad175793ee Reviewed-on: https://chromium-review.googlesource.com/448518 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#43541}
-
- 01 Mar, 2017 1 commit
-
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2720133005 Cr-Commit-Position: refs/heads/master@{#43519}
-
- 25 Feb, 2017 1 commit
-
-
Aleksey Kozyatinskiy authored
This reverts commit d2c093bc. Reason for revert: looks like it brokes try bot [1]. [1] https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug Original change's description: > [heap] Support for minor MC marking during incremental marking > > BUG=chromium:651354 > > Change-Id: Ia8511723b17936b78b33ea685704237c100648e1 > Reviewed-on: https://chromium-review.googlesource.com/439285 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43422} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,hablich@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Change-Id: Ib5bada3ecf9d687568668b9a4ef4682bb665b8e1 Reviewed-on: https://chromium-review.googlesource.com/446977Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43424}
-
- 24 Feb, 2017 1 commit
-
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: Ia8511723b17936b78b33ea685704237c100648e1 Reviewed-on: https://chromium-review.googlesource.com/439285 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43422}
-
- 23 Feb, 2017 1 commit
-
-
Marja Hölttä authored
BUG=v8:5294 Change-Id: If45f25aae8de526027b7851cb4efe0ccf4a7c4b1 Reviewed-on: https://chromium-review.googlesource.com/444226 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43388}
-
- 22 Feb, 2017 1 commit
-
-
Michael Lippautz authored
Have clear prologue and epilogue steps. For a minor MC we can then templatize the prologue without changing the actual evacuation routine. BUG=chromium:651354 Change-Id: Ia238748e90bc6b616cd813d31198de182fe11498 Reviewed-on: https://chromium-review.googlesource.com/445898Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43378}
-
- 17 Feb, 2017 1 commit
-
-
Michael Lippautz authored
A fast promotion mode that works solely on GC heuristics without requiring compiler or other profiler support by implementing zero-copy evacuation for new space. - Once a threshold of survived bytes in the Scavenger is reached the mode is activated. - In fast promotion mode all pages are moved to old space instead of performing a Scavenge. - The inevitable upcoming full MC determines whether the decision whether the mode should stay on or be turned off based on the young generation survival rate. BUG=chromium:693413 Change-Id: Ifdf296092a9bac609f9dcdfb47a24046f3093745 Reviewed-on: https://chromium-review.googlesource.com/442560 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43276}
-
- 15 Feb, 2017 1 commit
-
-
Michael Lippautz authored
BUG= Change-Id: I7215f298d7da4f5104449cc9198588801642bba1 Reviewed-on: https://chromium-review.googlesource.com/443126Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43223}
-
- 09 Feb, 2017 2 commits
-
-
jkummerow authored
TBR=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2688573003 Cr-Commit-Position: refs/heads/master@{#43075}
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: I8d74133ca9b21ce9e0612efc1e5ace41d1002dae Reviewed-on: https://chromium-review.googlesource.com/440304Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43064}
-
- 03 Feb, 2017 1 commit
-
-
mlippautz authored
BUG= Review-Url: https://codereview.chromium.org/2640783007 Cr-Commit-Position: refs/heads/master@{#42906}
-
- 01 Feb, 2017 1 commit
-
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2672503002 Cr-Commit-Position: refs/heads/master@{#42866}
-
- 20 Jan, 2017 3 commits
-
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2637403011 Cr-Commit-Position: refs/heads/master@{#42555}
-
bmeurer authored
Revert of [heap] Provide ObjectMarking with marking transitions (patchset #5 id:80001 of https://codereview.chromium.org/2644523002/ ) Reason for revert: Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/8349/steps/Mjsunit/logs/compiled-module-seria.. Original issue's description: > [heap] Provide ObjectMarking with marking transitions > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2644523002 > Cr-Commit-Position: refs/heads/master@{#42531} > Committed: https://chromium.googlesource.com/v8/v8/+/cbb8929e97ee475dab4f704a71637e76342e903a TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2647873002 Cr-Commit-Position: refs/heads/master@{#42533}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2644523002 Cr-Commit-Position: refs/heads/master@{#42531}
-
- 19 Jan, 2017 2 commits
-
-
krasin authored
Clang just got more strict about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in V8. BUG=chromium:681136 Review-Url: https://codereview.chromium.org/2646553002 Cr-Commit-Position: refs/heads/master@{#42523}
-
jkummerow authored
using newly introduced ThinStrings, which store a pointer to the actual, internalized string they represent. BUG=v8:4520 (Previously landed as #42168 / af51befe) (Previously landed as #42193 / 4c699e34) (Previously landed as #42235 / ec45e6ed) Review-Url: https://codereview.chromium.org/2549773002 Cr-Commit-Position: refs/heads/master@{#42503}
-
- 16 Jan, 2017 1 commit
-
-
hpayer authored
BUG=v8:5829 patch from issue 2634493004 at patchset 20001 (http://crrev.com/2634493004#ps20001) Review-Url: https://codereview.chromium.org/2634033003 Cr-Commit-Position: refs/heads/master@{#42383}
-
- 12 Jan, 2017 1 commit
-
-
jkummerow authored
Revert of Internalize strings in-place (patchset #20 id:380001 of https://codereview.chromium.org/2549773002/ ) Reason for revert: Blocks roll, ASan detects leaking ExternalStrings. Original issue's description: > Internalize strings in-place (reland^2) > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > BUG=v8:4520 > > (Previously landed as #42168 / af51befe) > (Previously landed as #42193 / 4c699e34) > > Review-Url: https://codereview.chromium.org/2549773002 > Cr-Commit-Position: refs/heads/master@{#42235} > Committed: https://chromium.googlesource.com/v8/v8/+/ec45e6ed2e11698c713e664b1510bc31bcdbbdba TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4520 Review-Url: https://codereview.chromium.org/2626893005 Cr-Commit-Position: refs/heads/master@{#42271}
-
- 11 Jan, 2017 2 commits
-
-
jkummerow authored
using newly introduced ThinStrings, which store a pointer to the actual, internalized string they represent. BUG=v8:4520 (Previously landed as #42168 / af51befe) (Previously landed as #42193 / 4c699e34) Review-Url: https://codereview.chromium.org/2549773002 Cr-Commit-Position: refs/heads/master@{#42235}
-
jkummerow authored
Revert of Internalize strings in-place (patchset #17 id:320001 of https://codereview.chromium.org/2549773002/ ) Reason for revert: blocks roll, see: https://codereview.chromium.org/2628733002/ Debug mode runs into an Abort("External string expected, but not found"). Original issue's description: > Internalize strings in-place (reland) > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > BUG=v8:4520 > > (Previously landed as #42168 / af51befe. > > Review-Url: https://codereview.chromium.org/2549773002 > Cr-Commit-Position: refs/heads/master@{#42193} > Committed: https://chromium.googlesource.com/v8/v8/+/4c699e349a4986b28574b3a51e8780e3a3d067b1 TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4520 Review-Url: https://codereview.chromium.org/2625073002 Cr-Commit-Position: refs/heads/master@{#42212}
-