- 08 Mar, 2022 13 commits
-
-
Nikolaos Papaspyrou authored
Before a young GC, the scavenger finalizes a pending full GC sweeping, in case there are no more running sweeping jobs, to avoid unnecessarily pausing sweeping and then resuming it. This CL moves this sweeping finalization from ScavengerCollector::CollectGarbage to Heap::CompleteSweepingYoung, so that it is also performed for the minor mark-compactor and that sweeping is correctly attributed to the previous full GC cycle (instead of the beginning young cycle). Furthermore, it also finalizes CppGC sweeping if there are no more running sweeping jobs. Bug: chromium:1154636 Change-Id: Ic9ba4803f49db32c0a539f080329f012859bc8bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3508011Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#79407}
-
Dominik Inführ authored
We can cache this in a static field during V8 initialization such that we don't need to cache this method's result for each use-case that might benefit. Bug: v8:12691 Change-Id: I4391a5e306646465ce96fb7e354be996d9fe8b44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506375Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79406}
-
Clemens Backes authored
The 5.4 and 5.10 kernels received a patch for PKRU handling, which landed in 5.4.182 and 5.10.103. See "x86/fpu: Correct pkru/xstate inconsistency" by Brian Geffon <bgeffon@google.com>: https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.4.182 https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.10.103 R=jkummerow@chromium.org Bug: v8:11974 Change-Id: Ie2d4840f9fbd902a0988c94c50ab450485d9117c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506991Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79405}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I5827612419b938758b25d1f504e4576016583d4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497364Reviewed-by: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79404}
-
Tobias Tebbi authored
Change-Id: I734aba6528bd23adca1998be52197f609c6c174e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497351 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#79403}
-
Clemens Backes authored
If we hit an OOM when allocating the code space for a Wasm module, include the code size we tried to allocate in the error message. This should make crash reports easier to diagnose. R=ecmziegler@chromium.org Bug: chromium:1302310 Change-Id: I0a85caff65efcad122664765c07f78b35095097e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506993Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79402}
-
Lu Yahan authored
and delete extra asm_comment Change-Id: Ia22f4bc622387e7c9a1c830b9f213d9554f0029e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507121Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79401}
-
George Wort authored
Always use the top tier register allocator when statically compiling code as we want the best performance and aren't as concerned about compile time. This also avoids a current bug when the mid-tier register allocator is used with statically compiled code. Bug: chromium:1299793 Change-Id: I74175d75847d092d1d5373661d536a299a7da1b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484316Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79400}
-
Victor Gomes authored
Define dummy BranchIfCompare, a conditional control node that accepts more than one input node. Bug: v8:7700 Change-Id: If29b6e9531e8a75a4e94fb2057d8e8d36cf0d9ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506376 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79399}
-
Dominik Inführ authored
This rename better reflects that heap_base is both used in cppgc but also V8's GC. Bug: v8:12691 Change-Id: Ia18ecba462d1b55cee6722452ceb28b25490a066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506374Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79398}
-
Frank Tang authored
Clean up two flags which control features shipped in m99 harmony_intl_locale_info harmony_intl_enumeration Bug: v8:10743, v8:11638 Change-Id: I856afaceb0972052d1bcc70b162e8f9ee9071dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3508169Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79397}
-
Frank Tang authored
Bug: v8:11544 Change-Id: I781119561db5ec05b12b9bca31c98403355e35ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3378882Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79396}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cd24f73..eaff38e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1f05f8e..548c235 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I004a6e8b76baee2d38a93b8843ea9625d6c6a9ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3508461 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79395}
-
- 07 Mar, 2022 19 commits
-
-
Michael Lippautz authored
Resurrecting finalizers cause all sorts of problems, from performance penalties when used to hard-to-debug memory leaks. There's no more usage left in Blink as well as V8 internally, so deprecate resurrecting finalizers. Bug: v8:12672 Change-Id: I998373d6468bbd3bd581a41dec8904de80561f43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507991Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79394}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/e87b0048c4..f7fb969c Bug: v8:7834 Change-Id: I9581eed719044edc433d022f58cce0506c083594 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504183Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79393}
-
Frank Tang authored
Fix typo which cause morePrecision output for lessPrecision Bug: v8:10776 Change-Id: I164abbdfa30ae1c4064a75abdd04fdbb1118dc0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3501835Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79392}
-
Frank Tang authored
Fix typo which should check y match -∞ but checked -0 Bug: v8:10776 Change-Id: I6bddbf91dbee2411d47a5e3b8ccbc456a0602bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504646Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79391}
-
Junliang Yan authored
Change-Id: I4a1e9ebc1a8c2efd1cdc46079519bd62fd90dc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507200Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79390}
-
Leszek Swirski authored
Change-Id: I29b48de9e0f6d6db5fba50d4a081656d869d9892 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506309 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#79389}
-
Samuel Groß authored
Instead of returning a boolean success/failure value, the Free* methods of the VirtualAddressSpace API now terminate the process on failure, as this implies a bug in the caller. This is simpler than CHECKing for success in all callers and also provides more details about the possible cause of the failure. Bug: v8:12656 Change-Id: I5b469ae2c564068cff74e60b7e98f6a4776a239d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506992Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79388}
-
Junliang Yan authored
Change-Id: I03d1dfeb62c9c28debb902095ed070b529f3d978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507451Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79387}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Idc36a42307b05beefb2ff16e52c9a6c9b7a166f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500401Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79386}
-
Leszek Swirski authored
Change TestPlatform's old_platform_ field to an atomic, so that its write in the constructor and subsequent reads (that can be cross thread) are race-free. Hopefully this fixes the TSAN flakes we've been seeing. Bug: v8:9054 Change-Id: Ib2b6edd21508ffa18debd6326dd7a100266125f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506505 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79385}
-
Samuel Groß authored
This simplifies various bits of logic around EmbedderDataSlots as the raw part will now always contain a valid index into an external pointer table entry. This CL also unifies the initialization of EmbedderDataSlots by providing a EmbedderDataSlots::Initialize method and adds more documentation about the layout of EmbedderDataSlots in the different configurations. Bug: v8:10391 Change-Id: Ie952598898a7a6c9d40b28d3a7370bfc1291bcf0 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472495Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79384}
-
Leszek Swirski authored
Allow bytecodes processed by maglev to access the on-stack closure register. Bug: v8:7700 Change-Id: I757d0c1734ef478e5b9671ed87a4691101b4e29d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506444 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79383}
-
jameslahm authored
when has_simple_parameters_ is false in DeclareArguments - According to https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-functiondeclarationinstantiation step 28, arguments var declaration in function should be binding to arguments parameterBindings when has_simple_parameters_ is false. - According to https://tc39.es/ecma262/multipage/ordinary-and-exotic-objects-behaviours.html#sec-funct> step 18, we should set arguments_ is nullptr if "arguments" is an element of lexicalNames only when has_simple_parameters is true. Bug: v8:12671 Change-Id: I542f80e2c8653ae05b65feb0036e4ade2e653a53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3499251Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79382}
-
Marja Hölttä authored
This decreases the snapshot size (we don't need to write the ID for the string) and speeds up deserialization. Bug: v8:11525 Change-Id: I8f48d2344a7fd895c746e6a3d26f6dbbdd11a062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494539Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79381}
-
jameslahm authored
Currently ClobberDoubleRegisters is implemented in C++ and is not guaranteed to clobber all registers. Rewritten in assembly to clobber all double registers Bug: v8:11798 Change-Id: I11c09bd247c929d251e6e509ea5cc76b9981ea98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3490715Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79380}
-
Darius M authored
Bug: v8:12484 Change-Id: I0667c7464c0dd71338bc199a24a69248a7a0a525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497303Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#79379}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5ca27a8..cd24f73 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I26062521bebe25e83a9f815a61d911a98dedae6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504700 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79378}
-
Hao Xu authored
xorl + setcc is more efficient than setcc + movzxbl and encodes one byte shorter. Change-Id: Ib6679ce9ab0ac0d34701daba5c3d4d8bb57a8fc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492946Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#79377}
-
Lu Yahan authored
issue: https://github.com/riscv-collab/v8/issues/520 Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Reviewed-by: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79376}
-
- 06 Mar, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/086de03..5ca27a8 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d454c2e..34063a8 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I948930606eba44b8bb4f46d98311981210367693 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3502545 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79375}
-
- 05 Mar, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d6d9d1b..086de03 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4756e38..d454c2e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e210b54..9ce8be3 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/aa5ea60..aa6909a Rolling v8/tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 Rolling v8/tools/luci-go: git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70..git_revision:cb424e70e75136736a86359ef070aa96425fe7a3 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3bd91e2d184c361878bf886987cff3cf4a79bff6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3502536 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79374}
-
- 04 Mar, 2022 6 commits
-
-
Frank Tang authored
Add NumberFormat.prototype.formatRange(ToParts)? https://github.com/tc39/proposal-intl-numberformat-v3 https://chromestatus.com/guide/edit/5707621009981440 Design Doc: https://docs.google.com/document/d/19jAogPBb6W4Samt8NWGZKu47iv0_KoQhBvLgQH3xvr8/edit Bug: v8:10776 Change-Id: I9bb163c0c15ccac9d3a2d5e55ad38aa5c06bbaa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3429464Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79373}
-
Shu-yu Guo authored
HeapNumbers that are in the shared heap were incorrectly considered !IsShared(). TBR=jkummerow@chromium.org Bug: v8:12547 Change-Id: Ie4b9575445d841a7045c947ff4439bf53a22869d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504085 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79372}
-
Leszek Swirski authored
Start allowing heavier testing of maglev by allowing graph building to bail out if passed an unsupported bytecode. Bug: v8:7700 Change-Id: I7e3d2c5a8896d4f4e0da5ef444c95a286f9ac117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500417Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79371}
-
Leszek Swirski authored
Because I don't get much out of "Object() != Object()" Change-Id: I5a765b9cb0a272d30edcd834ec7b60d2fd03190b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497352Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79370}
-
Leszek Swirski authored
The newly optimised CopyDataPropertiesWithExcludedProperties acceses the excluded properties directly on the stack, to avoid pushing them twice. This meant that we had to pass a stack pointer into the runtime, which we couldn't do directly because all arguments to runtime functions should be tagged. We tried to work around this by passing the stack pointer in a Foreign, but this violated the V8 sandbox. Fortunately, the stack pointer is aligned, so it looks like a Smi to the GC. So, we can pass it directly on the stack as a runtime argument but doing a bit of bitcasting. Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Bug: v8:11614 Change-Id: I87c4a34a15ae863277142aa29f48b1dd546014e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497745 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#79369}
-
Seth Brenith authored
The heap snapshot generator is meant to apply descriptive names to Code objects, but was using CodeDataContainer instead. Attempting to set the name of the CodeDataContainer instances did nothing because they already had the name "system / CodeDataContainer". Bug: v8:11880 Change-Id: If7bd115bde36386d283d319c1ee28df565a39569 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3498849Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79368}
-