- 08 Feb, 2019 11 commits
-
-
Yang Guo authored
This allows the embedder to use a shared library build even if they use this method. R=ulan@chromium.org Change-Id: I613a6e5eb82b494128fb95dc89a0b73639ac5ca2 Reviewed-on: https://chromium-review.googlesource.com/c/1456042Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59455}
-
Gus Caplan authored
This is a reland of d7def900 Original change's description: > Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation" > > This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Original change's description: > > [builtins] [turbofan] Refactor Float64Pow to use single implementation > > > > Remove platform-specific Float64Pow implementations and utils Pow in > > favor of a base::ieee754::pow implementation. > > > > This unifies the implementation of pow for the compiler, wasm, and > > runtime. > > > > Bug: v8:5848, v8:5086 > > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403018 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59229} > > Bug: v8:5848, v8:5086 > Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e > Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1447854 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59411} Tbr: neis@chromium.org, bmeurer@chromium.org, jkummerow@chromium.org Bug: v8:5848, v8:5086 Change-Id: I42972b29b8830ed47a00b2b1d408d3005a810c0e Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1456302Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59454}
-
Tamer Tas authored
Presubmit script complains when an unformatted Torque file is submitted. This CL automates the formatting process of the Torque files. Presubmit script is run before every 'git cl upload', the workflow will make sure that the upload is canceled, but the files are formatted. Bug: chromium:898436, v8:8805 Change-Id: I821ce36907c62e222451e883c5e3e18a9359f20e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1458222Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59453}
-
Dan Elphick authored
Mark Context version of BooleanValue as V8_DEPRECATED. Bug: v8:7279, v8:8562 Change-Id: I152f5080d92a940dadea9e8f2ed3f25338e6f099 Reviewed-on: https://chromium-review.googlesource.com/c/1458245Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#59452}
-
Clemens Hammacher authored
The new API receives a unique_ptr to avoid leaking the Extension object. All chromium uses were refactored in https://crrev.com/c/1447652. R=adamk@chromium.org Bug: v8:8725 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I46a931a73e941fe7b78f5390fec74663677e13e4 Reviewed-on: https://chromium-review.googlesource.com/c/1454723Reviewed-by:
-
Mythri authored
This cl: https://chromium-review.googlesource.com/c/v8/v8/+/1421077 changed the implementation of SetProperty to infer the language mode. Language mode is only required when there is an error to decide if we have to throw an error or not. However we used to compute language mode eagerly for PropertyCallbackInfo. This causes regressions in some benchmarks. This cl changes it by deferring it further by computing it only when it is actually required. BUG: v8:8580, chromium:925289 Change-Id: Iba70ec5f9bb3deec16414a1ec418b3963f2144f9 Reviewed-on: https://chromium-review.googlesource.com/c/1454608Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#59450}
-
Toon Verwaest authored
As requested in https://chromium-review.googlesource.com/c/v8/v8/+/1448313 Change-Id: I89e84600aa4cd3feef3dbf4f5acdaf377e3446f8 Reviewed-on: https://chromium-review.googlesource.com/c/1460463Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59449}
-
Yang Guo authored
This reverts commit 734a6575. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/29872 Original change's description: > Do not enqueue or run a microtask on detached contexts > > This CL disables EnqueueMicrotask and RunMicrotasks on detached > contexts. That is, if an embedder call DetachGlobal() on a v8::Context, > EnqueueMicrotask on that context will not take effect, and all Microtask > that is enqueued before DetachGlobal will be cancelled. > > On Blink, this implies that a frame will no longer run a microtask after > it's navigated away. OTOH, detached frames in Blink are not affected. > > Bug: v8:8124 > Change-Id: I5b00ceef5ea2afb87cf067a65eb95c29bf91176d > Reviewed-on: https://chromium-review.googlesource.com/c/1416071 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59445} TBR=yukishiino@chromium.org,adamk@chromium.org,yangguo@chromium.org,bmeurer@chromium.org,verwaest@chromium.org,tzik@chromium.org Change-Id: I9f5b703e7101aa3c251fe03ed4b52e9d71ae605a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8124 Reviewed-on: https://chromium-review.googlesource.com/c/1460466Reviewed-by:
-
Tamer Tas authored
chromium/buildtools repo was moved and broke the V8 auto-roller. This CL corrects the old-path. Failed-Roll: https://chromium-review.googlesource.com/c/v8/v8/+/1459743 R=machenbach@chromium.org,sergiyb@chromium.org CC=yangguo@chromium.org Bug: chromium:930050 Change-Id: I969c73c13bfa996b1010971c37d9325c22048c0a Reviewed-on: https://chromium-review.googlesource.com/c/1460464 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59447}
-
Frank Tang authored
Cache up to 8 Calendar Cache up to 8 SimpleDateFormat Improve another ~12% (x1.12) $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json ... NewIntlDateTimeFormat-Intl(Score): 104 ... Compare to baseline in https://chromium-review.googlesource.com/c/v8/v8/+/1457603 Bug: chromium:928098 Change-Id: Ib3d2d3af1a84c4a856b9e0a40dc06a34aa5d9c71 Reviewed-on: https://chromium-review.googlesource.com/c/1459476 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59446}
-
tzik authored
This CL disables EnqueueMicrotask and RunMicrotasks on detached contexts. That is, if an embedder call DetachGlobal() on a v8::Context, EnqueueMicrotask on that context will not take effect, and all Microtask that is enqueued before DetachGlobal will be cancelled. On Blink, this implies that a frame will no longer run a microtask after it's navigated away. OTOH, detached frames in Blink are not affected. Bug: v8:8124 Change-Id: I5b00ceef5ea2afb87cf067a65eb95c29bf91176d Reviewed-on: https://chromium-review.googlesource.com/c/1416071Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 07 Feb, 2019 21 commits
-
-
Frank Tang authored
$ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json ... NewIntlDateTimeFormat-Intl(Score): 92.9 Compare to baseline in https://chromium-review.googlesource.com/c/v8/v8/+/1455727 improve another x3.5 Bug: chromium:928098 Change-Id: Iab6b9e2d58231832c54bc626d01b25a3813537fa Reviewed-on: https://chromium-review.googlesource.com/c/1457603Reviewed-by:
-
Igor Sheludko authored
... and use RelocInfo iteration instead of skip-and-unaligned-write sequences. This is a step towards avoiding unaligned stores via UnalignedSlot. Various cleanup CLs will follow. Bug: v8:8794 Change-Id: I62faedfa1c1ababe4b185fa8d7f2c6c1baa5cf79 Reviewed-on: https://chromium-review.googlesource.com/c/1456579 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59443}
-
Clemens Hammacher authored
This makes the existing error message tests also test the error produced by asynchronous compilation and instantiation. It also slightly tweaks the error message to contain the name of the API function invoked instead of "WebAssembly Instantiation". R=titzer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Bug: chromium:926311 Change-Id: If4ab963cee8267d43b289169d21b31637c471d6d Reviewed-on: https://chromium-review.googlesource.com/c/1456085 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59442}
-
Ujjwal Sharma authored
Port String.prototype.endsWith from a CPP builtin to a Torque builtin. Spec: https://tc39.github.io/ecma262/#sec-string.prototype.endswith Bug: v8:8400 Change-Id: I4ac8cb92acb68389db844deaecc9ae1c6e7d6bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1454677 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59441}
-
Jaroslav Sevcik authored
This is a reland of 78ed0e3f The breakage was unrelated to constant field tracking (see the linked bugs). Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} Bug: v8:8361, v8:8799, v8:8801 Change-Id: I318768b925f3efd285cb27aa93e6de35fdcced42 Reviewed-on: https://chromium-review.googlesource.com/c/1458238Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59440}
-
Andreas Haas authored
R=titzer@chromium.org Bug: v8:7581 Change-Id: I857a40a0f955b3506d7958d2128a1b4560cff0bc Reviewed-on: https://chromium-review.googlesource.com/c/1458236 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The Size() includes the page header. Bug: chromium:852420 Change-Id: I1f2da2309ff38f2222c82b5758937bdaf5036f12 Reviewed-on: https://chromium-review.googlesource.com/c/1458242Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59438}
-
Tamer Tas authored
The test name alone isn't informative alone. This CL prints the variant name during the progress reporting. tested by running test262 with all variants R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I3d7d1fc6eacef3712d87404c7276fd5523bb445a Reviewed-on: https://chromium-review.googlesource.com/c/1458156 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Junliang Yan authored
the DCHECK in set_constant_pool_offset fails due to the InstructionSize() needs builtin_index() Change-Id: Ic3f2a72d4f481ba9d5413c1bcfdd95b8bb107782 Reviewed-on: https://chromium-review.googlesource.com/c/1456309Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Drive-by: Refactor FlushInstructionCache to its own header. This removes dependencies of objects.cc and code.cc Bug: v8:8562 Change-Id: If23f3b9d4f2068e08c61c0f4b070ecfe1b9a6cc0 Reviewed-on: https://chromium-review.googlesource.com/c/1456081Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59435}
-
Michael Starzinger authored
This unifies how continuations after a control transfer are handled within the interpreter loop. To avoid bumping the {pc} we can either reset the opcode length to zero or just "continue" the loop. This just unifies the approach for the entire {Execute} method. R=clemensh@chromium.org Change-Id: Ifc33c3a87cff69d417f61fa0bc234260c7fa502a Reviewed-on: https://chromium-review.googlesource.com/c/1458216 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Ulan Degenbaev authored
The new scheduling reduces the main thread marking performed in tasks and on allocation. It is based on two counters: - bytes_marked, - scheduled_bytes_to_mark. The bytes_marked accounts marking done both the main thread and the concurrent threads. The scheduled_bytes_to_mark increases based on allocated bytes and also based on time passed since the start of marking. The main thread steps are allowed to mark the minimal amount if bytes_marked is greater than scheduled_bytes_to_mark. This also changes tasks posted for marking. Before only normal tasks were posted. Now delayed tasks are posted if the marker is ahead of schedule. Bug: 926189 Change-Id: I5bc9c33a5ecfc9f8d09f78d08ae277d16a2779ca Reviewed-on: https://chromium-review.googlesource.com/c/1443056 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Maciej Goszczycki authored
Up until now the first page of ReadOnlySpace was not read-only. Changing this means that the space needs to be made writable before PagedSpace's TearDown tries to free it. Bug: v8:7464 Change-Id: I162b45b662a6e5ab61a35be280ef087375fdcc9b Reviewed-on: https://chromium-review.googlesource.com/c/1454494Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 v8:8737 Change-Id: I186cb33eb2e84a47fcb0897978bde9c6dffb9df3 Reviewed-on: https://chromium-review.googlesource.com/c/1456044 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Some tests assume that kMaxRegularHeapObjectSize is close to the page size. They break if the constant is decreased to 16KB to stress young large objects. Bug: chromium:852420 Change-Id: I2542878810823f7a73019b1e451a080fcfc1f78f Reviewed-on: https://chromium-review.googlesource.com/c/1456043Reviewed-by:
-
Michael Starzinger authored
This adds a test case to check consistency of how an "unreachable" trap is handled by a surrounding "try" block in case those two operations are in different functions (i.e. not local to one function body). It also fixes a DCHECK for an as-of-yet untested interpreter state transition. R=clemensh@chromium.org TEST=cctest/test-run-wasm-exceptions BUG=v8:8729 Change-Id: I432c48d0bc664f7ab092aaafef6dfa29c5f262fd Reviewed-on: https://chromium-review.googlesource.com/c/1454605 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jakob Gruber authored
We've recently run into several platform- and compiler-specific errors and warnings about alignment. This tentatively implements AlignToDataAlignment for all platforms, which is used when setting up the v8_Default_embedded_blob_ v8_Default_embedded_blob_size_ variables. Bug: v8:6666,chromium:929205 Change-Id: I0cee09eda71551f8b7d14f4076da496057023146 Reviewed-on: https://chromium-review.googlesource.com/c/1458018 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
deepak1556 authored
When BUILDING_V8_SHARED in release builds __declspec(dllexport) causes generation of implicit constructors in the forwarding class while its deleted in TurboAssemblerBase, which leads to compilation errors like: In file included from gen/v8/v8_base_jumbo_6.cc:41: In file included from .\../../v8/src/interface-descriptors.cc:7: In file included from ../../v8\src/macro-assembler.h:40: ../../v8\src/x64/macro-assembler-x64.h(92,9): error: call to deleted constructor of 'v8::internal::TurboAssemblerBase' : TurboAssemblerBase(std::forward<Args>(args)...) {} ^ ~~~~~~~~~~~~~~~~~~~~~~~~ ../../v8\src/x64/macro-assembler-x64.h(536,25): note: in instantiation of function template specialization 'v8::internal::TurboAssembler::TurboAssembler<v8::internal::TurboAssembler>' requested here class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler { ^ ../../v8\src/turbo-assembler.h(127,34): note: 'TurboAssemblerBase' has been explicitly marked deleted here DISALLOW_IMPLICIT_CONSTRUCTORS(TurboAssemblerBase); ^ 1 error generated. The original changes were made in https://chromium-review.googlesource.com/c/v8/v8/+/1414913 R=mstarzinger@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: NONE Change-Id: I87a5a678b8bae13b3adc6f1c6ac0b9313ed18d85 Reviewed-on: https://chromium-review.googlesource.com/c/1454676 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/85b07e9..e148b4c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4fbc755..11e283f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/67d70d2..61d0c29 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/215c4a1..1dc7541 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I578f4f74f4231faa0b959eb176d5f6c31f578437 Reviewed-on: https://chromium-review.googlesource.com/c/1457607Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59426}
-
Frank Tang authored
Lazy initialize some data once. $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json INFO >>> Running suite: JSTests/Intl INFO >>> Stdout (#1): NewIntlCollator-Intl(Score): 2047 NewIntlDateTimeFormat-Intl(Score): 26.5 NewIntlNumberFormat-Intl(Score): 449 NewIntlPluralRules-Intl(Score): 670 NewIntlListFormat-Intl(Score): 1762 NewIntlRelativeTimeFormat-Intl(Score): 918 Compare to performance baseline scores in https://chromium-review.googlesource.com/c/v8/v8/+/1455717 Bug: chromium:928098 Change-Id: I7f213f50eb261474fb38d9592725a101939020d8 Reviewed-on: https://chromium-review.googlesource.com/c/1455727 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Just add tests so we can observe the number first. Got the following results $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json INFO >>> Running suite: JSTests/Intl INFO >>> Stdout (#1): NewIntlCollator-Intl(Score): 161 NewIntlDateTimeFormat-Intl(Score): 9.73 NewIntlNumberFormat-Intl(Score): 18.6 NewIntlPluralRules-Intl(Score): 18.5 NewIntlListFormat-Intl(Score): 19.4 NewIntlRelativeTimeFormat-Intl(Score): 18.7 Bug: chromium:928098 Change-Id: I59f28393af8f868de639dcb81a7b2f69ce2f0eba Reviewed-on: https://chromium-review.googlesource.com/c/1455717 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 06 Feb, 2019 8 commits
-
-
Sigurd Schneider authored
This unifies the RelocInfo::Visit method across architectures. Bug: v8:8562 Change-Id: I36fdfb2f456aebb4d69977bb84727c9b49b22f69 Reviewed-on: https://chromium-review.googlesource.com/c/1456106 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
For the initial implementation we simply keep the capacity of the young large object space in sync with the capacity of the new space. The only subtlety is that we allow at least one large object independent from its size. So it may exceed the capacity of the space. This also fixes setting of the large page flags for incremental marking. Bug: chromium:852420 Change-Id: I12a9d4a7350464ca291710917ecad782ae73b8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1456092 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 78ed0e3f. Reason for revert: Weird breakage on https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24063 Two tests should not run on GC stress, but this one is really curious: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8922258236346866528/+/steps/Mjsunit/0/logs/templates/0 Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} TBR=jarin@chromium.org,ishell@chromium.org Change-Id: I0017230c840f4ab712852ba338f0119503688ec9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8361 Reviewed-on: https://chromium-review.googlesource.com/c/1456108Reviewed-by:
-
Toon Verwaest authored
Otherwise preparsed variables will cause unnecessary dynamic variable allocation, which is especially bad when we're preparsing top-level functions with references to other global variables. Change-Id: I2fa17dae8c1cc5264a26ddc8b8868de1d791b0ac Reviewed-on: https://chromium-review.googlesource.com/c/1456040 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59420}
-
Sigurd Schneider authored
This reverts commit d7def900. Reason for revert: Breaks UBSan: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4542 Besides undefined behavior, things were looking good! Original change's description: > Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation" > > This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Original change's description: > > [builtins] [turbofan] Refactor Float64Pow to use single implementation > > > > Remove platform-specific Float64Pow implementations and utils Pow in > > favor of a base::ieee754::pow implementation. > > > > This unifies the implementation of pow for the compiler, wasm, and > > runtime. > > > > Bug: v8:5848, v8:5086 > > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403018 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59229} > > Bug: v8:5848, v8:5086 > Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e > Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1447854 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59411} TBR=jkummerow@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,clemensh@chromium.org,bmeurer@chromium.org,me@gus.host Change-Id: I65c4bbd3ab7aaa1c396d182467c5a1fe6a639df5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5848, v8:5086 Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1456107Reviewed-by:
-
Junliang Yan authored
the DCHECK in set_constant_pool_offset fails due to the InstructionSize() needs builtin_index() Change-Id: Ia86b57ebc4901672dee3012ba931e0222933ec1d Reviewed-on: https://chromium-review.googlesource.com/c/1454265Reviewed-by:
-
Clemens Hammacher authored
We often use raw assertPromiseResult with {success == assertUnreachable} for that. Having a separate helper increases readability and allows us to generate consistent (and better) error messages. R=titzer@chromium.org Bug: chromium:926311 Change-Id: I507941eacaafe6c576098d7829a76b27384a4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1456039Reviewed-by: -
Sigurd Schneider authored
Bug: v8:8562 Change-Id: I6f7dcaf888d0012fba2798613523c45d584753d4 Reviewed-on: https://chromium-review.googlesource.com/c/1456102Reviewed-by:
-
