- 06 Apr, 2021 1 commit
-
-
Michael Lippautz authored
Full GCs on non-main-frame context disposals show up on real-world web workloads and often cause missed frames. Remove and let the regular scheduler take over these workloads. Bug: chromium:1191325 Change-Id: Ib58419e4623c096321860db05c36ddf9c8e9f4e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773347 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73799}
-
- 26 Feb, 2020 1 commit
-
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Iaf1399a0ccc94f8f96cfdab4364eb918d58659d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073758Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#66455}
-
- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 23 May, 2019 1 commit
-
-
Yang Guo authored
NOPRESUBMIT=true TBR=mstarzinger@chromium.org Bug: v8:9247 Change-Id: I4cd6b79a1c2cba944f6f23caed59d4f1a4ee358b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624217 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61790}
-
- 15 May, 2019 1 commit
-
-
Clemens Hammacher authored
The 'z' length modifier for {size_t} in format strings was introduced with C99, hence it is available in all environments we support. R=jgruber@chromium.org, mlippautz@chromium.org Bug: v8:9183 Change-Id: I1bc2abec3f9c7b38186128202fef4719853de7d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613243Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61536}
-
- 21 Feb, 2019 1 commit
-
-
Ulan Degenbaev authored
This merges the "do-nothing" case with the "done" case as the former is no longer useful. This also fixes a bug where the idle time handler would not make progress by always returning "do-nothing". Change-Id: Ibdd3189e4fd35acc5405aa82a13ea8ee2fd74cc6 Reviewed-on: https://chromium-review.googlesource.com/c/1478695 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59758}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=ulan@chromium.org Bug: v8:6837 Change-Id: I8d900f3c703dea6ee3bcc225a1d2754e91666b9d Reviewed-on: https://chromium-review.googlesource.com/671047 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48136}
-
- 02 Aug, 2017 1 commit
-
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 30 Jun, 2017 1 commit
-
-
Ulan Degenbaev authored
BUG=chromium:738031 Change-Id: I98d1015caadd7214a7076f7b39a4514bfd908061 Reviewed-on: https://chromium-review.googlesource.com/555971Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46345}
-
- 18 Nov, 2016 1 commit
-
-
mlippautz authored
Adds the marking logic to mark the young generation. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2498583002 Cr-Commit-Position: refs/heads/master@{#41104}
-
- 12 Apr, 2016 1 commit
-
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
- 11 Apr, 2016 2 commits
-
-
https://codereview.chromium.org/1877453002/machenbach authored
Reason for revert: Breaks gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421 Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > Original CL: https://codereview.chromium.org/1869433004 > Reverted in: https://codereview.chromium.org/1867383002 > > R= jochen@chromium.org > TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc > Cr-Commit-Position: refs/heads/master@{#35394} TBR=jochen@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877823003 Cr-Commit-Position: refs/heads/master@{#35396}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1877453002 Cr-Commit-Position: refs/heads/master@{#35394}
-
- 08 Apr, 2016 2 commits
-
-
jfb authored
Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ ) Reason for revert: One small issue easily fixed here: https://codereview.chromium.org/1867333003/ But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful: Stderr: f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect format specifier", 0) It's easier to revert for now, I'll dig more into the docs: https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx And then resubmit, making sure I run these bots. Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d > Cr-Commit-Position: refs/heads/master@{#35365} TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1867383002 Cr-Commit-Position: refs/heads/master@{#35366}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1869433004 Cr-Commit-Position: refs/heads/master@{#35365}
-
- 29 Mar, 2016 1 commit
-
-
ulan authored
This avoids redundant casts, loss of precision, and potential overflows. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1841043002 Cr-Commit-Position: refs/heads/master@{#35113}
-
- 11 Mar, 2016 1 commit
-
-
joransiu authored
GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Introduce a new V8 SIZET PREFIX to use %zd instead. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1782293002 Cr-Commit-Position: refs/heads/master@{#34724}
-
- 02 Oct, 2015 1 commit
-
-
ulan authored
This restores size_of_objects and removed unused fields. BUG=chromium:538539 LOG=NO Review URL: https://codereview.chromium.org/1380953003 Cr-Commit-Position: refs/heads/master@{#31072}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 25 Sep, 2015 2 commits
-
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1352453004 Cr-Commit-Position: refs/heads/master@{#30944}
-
mstarzinger authored
This prevents the internal gc-idle-time-handler.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1368983002 Cr-Commit-Position: refs/heads/master@{#30939}
-
- 08 Sep, 2015 1 commit
-
-
ulan authored
This moves incremental marking steps from gc-idle-time-handler and heap to the new incremental marking task. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1265423002 Cr-Commit-Position: refs/heads/master@{#30641}
-
- 25 Aug, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1313083002 Cr-Commit-Position: refs/heads/master@{#30356}
-
- 17 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1291833003 Cr-Commit-Position: refs/heads/master@{#30195}
-
- 06 Aug, 2015 1 commit
-
-
hpayer authored
When allocation rate is low and we are close to the new space limit, we should perform a scavenge during idle time. BUG=chromium:517395 LOG=n Review URL: https://codereview.chromium.org/1272573006 Cr-Commit-Position: refs/heads/master@{#30044}
-
- 30 Jul, 2015 1 commit
-
-
ulan authored
The idle time handler should never return DONE or DO_SCAVENGE for background tabs. Upon receiving DONE chrome will stop sending idle notifications. BUG=chromium:515174 LOG=NO Review URL: https://codereview.chromium.org/1269583002 Cr-Commit-Position: refs/heads/master@{#29926}
-
- 07 Jul, 2015 1 commit
-
-
ulan authored
This reverts commit 26991892. This reverts commit 435b3c87. The failing test is fixing in chromium. BUG=chromium:490559 LOG=NO TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1208993009 Cr-Commit-Position: refs/heads/master@{#29512}
-
- 05 Jul, 2015 1 commit
-
-
machenbach authored
Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (patchset #17 id:320001 of https://codereview.chromium.org/1218863002/) Reason for revert: [Sheriff] Looks like it blocks the roll (bisected). Speculative revert. https://codereview.chromium.org/1210293003/ Original issue's description: > Replace reduce-memory mode in idle notification with delayed clean-up GC. > > BUG=490559 > LOG=NO > > Committed: https://crrev.com/0ecd9e1bd2c6b519d4e7285f46cb7e844bc2235c > Cr-Commit-Position: refs/heads/master@{#29451} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490559 Review URL: https://codereview.chromium.org/1226703002 Cr-Commit-Position: refs/heads/master@{#29470}
-
- 02 Jul, 2015 1 commit
-
-
ulan authored
BUG=490559 LOG=NO Review URL: https://codereview.chromium.org/1218863002 Cr-Commit-Position: refs/heads/master@{#29451}
-
- 11 Jun, 2015 1 commit
-
-
hpayer authored
Make sure we do not start incremental marking in idle notification when incremental marking is turned off via flags. BUG=chromium:498315 LOG=n Review URL: https://codereview.chromium.org/1177953002 Cr-Commit-Position: refs/heads/master@{#28925}
-
- 09 Jun, 2015 1 commit
-
-
ulan authored
Make old generation allocation throughput stats independent from the new space allocation throughput. BUG= Review URL: https://codereview.chromium.org/1167563005 Cr-Commit-Position: refs/heads/master@{#28880}
-
- 26 May, 2015 1 commit
-
-
ulan authored
BUG=chromium:492021 LOG=n Review URL: https://codereview.chromium.org/1154873003 Cr-Commit-Position: refs/heads/master@{#28623}
-
- 22 May, 2015 1 commit
-
-
hpayer authored
BUG=chromium:481811 LOG=n Review URL: https://codereview.chromium.org/1148633005 Cr-Commit-Position: refs/heads/master@{#28585}
-
- 20 May, 2015 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1145103002 Cr-Commit-Position: refs/heads/master@{#28508}
-
- 19 May, 2015 1 commit
-
-
ulan authored
This also adjusts transitioning between modes so that crbug.com/460090 remains fixed. BUG=chromium:489323, chromium:460090 LOG=NO Review URL: https://codereview.chromium.org/1141393002 Cr-Commit-Position: refs/heads/master@{#28490}
-
- 15 May, 2015 2 commits
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1138643003 Cr-Commit-Position: refs/heads/master@{#28428}
-
hpayer authored
When context disposal rate is high and we cannot perform a full GC, we do nothing until the context disposal rate becomes lower. BUG=chromium:473351 LOG=n Review URL: https://codereview.chromium.org/1118303004 Cr-Commit-Position: refs/heads/master@{#28416}
-
- 07 May, 2015 1 commit
-
-
ulan authored
While the mutator is active, the idle time handler optimizes for latency by doing only incremental steps and scavenges. When the mutator becomes inactive, the idle time handler forces few incremental GCs to reclaim memory and then stops until mutator is active again. BUG=460090 LOG=N Review URL: https://codereview.chromium.org/1105293004 Cr-Commit-Position: refs/heads/master@{#28300}
-
- 10 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Make full GC reduce memory footprint an explicit event in the idle notification handler. (patchset #2 id:20001 of https://codereview.chromium.org/1072363002/) Reason for revert: [Sheriff] breaks nosnap with timeouts: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2513 http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6220 Original issue's description: > Make full GC reduce memory footprint an explicit event in the idle notification handler. > > BUG= > > Committed: https://crrev.com/845705aa99b6bfa8d264cfda1c3b5f1229802ab5 > Cr-Commit-Position: refs/heads/master@{#27753} TBR=ulan@chromium.org,rmcilroy@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1081443002 Cr-Commit-Position: refs/heads/master@{#27755}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1072363002 Cr-Commit-Position: refs/heads/master@{#27753}
-