1. 06 Apr, 2021 1 commit
  2. 26 Feb, 2020 1 commit
  3. 24 May, 2019 1 commit
  4. 23 May, 2019 1 commit
  5. 15 May, 2019 1 commit
  6. 21 Feb, 2019 1 commit
  7. 25 Sep, 2017 1 commit
  8. 02 Aug, 2017 1 commit
  9. 30 Jun, 2017 1 commit
  10. 18 Nov, 2016 1 commit
  11. 12 Apr, 2016 1 commit
  12. 11 Apr, 2016 2 commits
  13. 08 Apr, 2016 2 commits
    • jfb's avatar
      Revert of Fix printf formats (patchset #8 id:140001 of... · 4c4fdc2d
      jfb authored
      Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ )
      
      Reason for revert:
      One small issue easily fixed here: https://codereview.chromium.org/1867333003/
      
      But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful:
      Stderr:
      f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
      format specifier", 0)
      
      It's easier to revert for now, I'll dig more into the docs:
      https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
      https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx
      
      And then resubmit, making sure I run these bots.
      
      Original issue's description:
      > Fix printf formats
      >
      > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      >
      >  - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
      >  - Uses it appropriately.
      >  - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
      >  - Fixes a bunch of incorrect formats.
      >
      > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      >
      > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
      > Cr-Commit-Position: refs/heads/master@{#35365}
      
      TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/1867383002
      
      Cr-Commit-Position: refs/heads/master@{#35366}
      4c4fdc2d
    • jfb's avatar
      Fix printf formats · 6ebf9fbb
      jfb authored
      The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      
       - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
       - Uses it appropriately.
       - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
       - Fixes a bunch of incorrect formats.
      
      R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      
      Review URL: https://codereview.chromium.org/1869433004
      
      Cr-Commit-Position: refs/heads/master@{#35365}
      6ebf9fbb
  14. 29 Mar, 2016 1 commit
  15. 11 Mar, 2016 1 commit
    • joransiu's avatar
      S390: Printf format specifier for size_t · 59267a08
      joransiu authored
      GCC on S390 31-bit treats size_t as 'long unsigned int', which
      is incompatible with %d format specifier that expects an 'int'.
      Introduce a new V8 SIZET PREFIX to use %zd instead.
      
      R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,yangguo@chromium.org
      
      BUG=
      
      Review URL: https://codereview.chromium.org/1782293002
      
      Cr-Commit-Position: refs/heads/master@{#34724}
      59267a08
  16. 02 Oct, 2015 1 commit
  17. 30 Sep, 2015 1 commit
  18. 25 Sep, 2015 2 commits
  19. 08 Sep, 2015 1 commit
  20. 25 Aug, 2015 1 commit
  21. 17 Aug, 2015 1 commit
  22. 06 Aug, 2015 1 commit
  23. 30 Jul, 2015 1 commit
  24. 07 Jul, 2015 1 commit
  25. 05 Jul, 2015 1 commit
  26. 02 Jul, 2015 1 commit
  27. 11 Jun, 2015 1 commit
  28. 09 Jun, 2015 1 commit
  29. 26 May, 2015 1 commit
  30. 22 May, 2015 1 commit
  31. 20 May, 2015 1 commit
  32. 19 May, 2015 1 commit
  33. 15 May, 2015 2 commits
  34. 07 May, 2015 1 commit
  35. 10 Apr, 2015 2 commits