- 01 Dec, 2017 30 commits
-
-
Clemens Hammacher authored
This CL adds support for f32 locals and parameters, and implements the basic f32 binary operations. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ia2d792dd1a6f7e97eab52a4ac49543b128fe3041 Reviewed-on: https://chromium-review.googlesource.com/796854Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49802}
-
Camillo Bruni authored
Bug: v8:7109 Change-Id: I16759ac5c9e09a9df4117d84ae6de26cc2410faf Reviewed-on: https://chromium-review.googlesource.com/803483Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49801}
-
Mircea Trofin authored
Flush the icache after JIT-ing using the WasmCodeManager. Also, re-enable tests that were previously failing on Linux ARM. Bug: v8:7138 Change-Id: I8e18b80dba58df173a2360f8ac365ee5daaf3239 Reviewed-on: https://chromium-review.googlesource.com/802961 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49800}
-
Mathias Bynens authored
Hexadecimal escape sequences of the form `\xNN` are more readable in the context of byte values, and are preferred per Google’s C++ style guide. https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters BUG=v8:7109 Change-Id: I6821ccb804388d99e5601e92fc392afdf496691e Reviewed-on: https://chromium-review.googlesource.com/803057Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49799}
-
Mathias Bynens authored
BUG=v8:7109 Change-Id: I976eeb012e5de944468f01b0676902fc82cd9604 Reviewed-on: https://chromium-review.googlesource.com/802828Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49798}
-
Clemens Hammacher authored
Some uses use uint64_t instead of int64_t to avoid compiler warnings about illegal narrowing of values with the MSB set. R=tebbi@chromium.org,mlippautz@chromium.org Bug: v8:7109 Change-Id: I6e861f48828bd931c451ef336672a260c13ae042 Reviewed-on: https://chromium-review.googlesource.com/803275 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#49797}
-
Ben L. Titzer authored
This is a reland of 163c1c82 Original change's description: > [wasm] Gracefully handle malformed custom sections in WebAssembly.Module.customSections(). > > R=clemensh@chromium.org > BUG=chromium:789952 > > Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 > Reviewed-on: https://chromium-review.googlesource.com/800941 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49767} Bug: chromium:789952 Change-Id: Ie17629b3fcbf2d5f78c83be2aa2a6b904a61f3ab Reviewed-on: https://chromium-review.googlesource.com/803575 Commit-Queue: Ben L. Titzer <titzer@google.com> Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49796}
-
Marja Hölttä authored
BUG=chromium:789764 Change-Id: I6a466660159721683c4979af32019d740094151b Reviewed-on: https://chromium-review.googlesource.com/803217Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#49795}
-
Peter Marshall authored
Bug: v8:7109 Change-Id: I367b3de52f03958d97b5da49987310d4af1b55f5 Reviewed-on: https://chromium-review.googlesource.com/803344Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49794}
-
Mythri authored
Adds new API function to request code cache. Earlier code cache was produced along with compile requests. This new API allows us to request code cache after executing. Also adds support in the code serializer to serialize after executing the script. Bug: chromium:783124,chromium:789694 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Id4e6a967e176e3e979dc4ccb9a37a353c70c3890 Reviewed-on: https://chromium-review.googlesource.com/797036Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#49793}
-
Marja Hölttä authored
BUG=v8:5402,v8:7109 Change-Id: Ifee03125d8894181acffc7ed9c6bda44e3939d2d Reviewed-on: https://chromium-review.googlesource.com/803336 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49792}
-
Camillo Bruni authored
Change-Id: I3730443db3b6f67dd57e07f8d2f03a3b34a6b0a7 Reviewed-on: https://chromium-review.googlesource.com/796215 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49791}
-
Clemens Hammacher authored
V8_INT64_C will be cleaned up in a follow-up CL. R=tebbi@chromium.org,mlippautz@chromium.org Bug: v8:7109 Change-Id: I6af97e7266039eb443896b404b77b8e2b5de5adb Reviewed-on: https://chromium-review.googlesource.com/803294Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49790}
-
Marja Hölttä authored
These should've been moved earlier but were left behind. BUG=v8:5402,v8:7109 Change-Id: I9736da35f1ef89628c987c33eed40a07aa266bea Reviewed-on: https://chromium-review.googlesource.com/803375 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49789}
-
Sathya Gunasekaran authored
Reported by @ziyunfei here: https://twitter.com/ziyunfei/status/936524009528811520 Bug: v8:5367 Change-Id: I2b1bb43dff86f35dec824e275740fce4f0c97b2e Reviewed-on: https://chromium-review.googlesource.com/802877Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49788}
-
Marja Hölttä authored
BUG=v8:5402,v8:7109 Change-Id: Ief9bea58e4dcade4cf4dfbb1d52166b7a5ef3ac0 Reviewed-on: https://chromium-review.googlesource.com/803255 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49787}
-
Ali Ijaz Sheikh authored
This is a reland of 86da38fd Original change's description: > [heap] minor cleanup in allocation observer code > > Change-Id: If0bec38d41a415e9fbfff57ac891de0461bac13b > Reviewed-on: https://chromium-review.googlesource.com/668836 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48046} Change-Id: If5fd9f7d123a62672d5a4450ddeac5a6e29158b8 Reviewed-on: https://chromium-review.googlesource.com/675423 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49786}
-
Martyn Capewell authored
The Arm atomic operations used an input register as a temporary, corrupting it for future uses. Fix this by adding another temporary, the impact of which is partly reduced by removing the "unique" requirement on the address base register. Bug: Change-Id: I99a7bc3c14100d64cb7478e2053cf83ab6dcea50 Reviewed-on: https://chromium-review.googlesource.com/795953 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#49785}
-
Yang Guo authored
R=ulan@chromium.org Bug: v8:7141 Change-Id: I21b82f5c3f6a2cd5f6e525d267d6c6819b1370fb Reviewed-on: https://chromium-review.googlesource.com/796370 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49784}
-
Michael Lippautz authored
Bug: chromium:788113 Change-Id: I205c57869caa24957d63a139f6ba0c6e8cf45749 Reviewed-on: https://chromium-review.googlesource.com/800151 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49783}
-
Andreas Haas authored
R=clemensh@chromium.org Bug: v8:7109 Change-Id: I8836663f4c66fd0f8c50f2cb66ab4cb8e2712f6c Reviewed-on: https://chromium-review.googlesource.com/803274Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49782}
-
Georg Neis authored
These now pass even when forcing optimization. TBR=jkummerow@chromium.org Bug: v8:6791 Change-Id: I4d7c7d37b48e6e970d33474fa7fd637e34b0bda0 Reviewed-on: https://chromium-review.googlesource.com/803374Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49781}
-
Clemens Hammacher authored
LiftoffRegister is an abstraction over Register and DoubleRegister. Many functions in Liftoff do not need to distinguish GP and FP registers. LiftoffRegister allows to implement most functions generically. Accessors allow to convert them back to Register or DoubleRegister. Both register types are represented in a unified index space, which allows to extend this concept to more register types and implement aliasing in a straight-forward manner. Many functions currently only implement the GP case. FP will be added later. R=titzer@chromium.org Bug: v8:6600 Change-Id: I043b787bc09dd1a06506ad515eb325b8ea19746d Reviewed-on: https://chromium-review.googlesource.com/793390Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49780}
-
Shiyu Zhang authored
In the special case of KeyedLoadIC, where the key is always undefined, LowerCheckEqualsInternalizedString fails and triggers deoptimization loops. It's because {exp}, which is undefined_string, does not match {val}, which is undefined_value. This patch drops the convertion from undefined_value to undefined_string for undefined key in KeyedLoadIC. It makes undefined key be able to pass LowerCheckEqualsInternalizedString and avoids the deoptimization loops. Bug: Change-Id: Ie15358e705490fb2e4907f4d37a3ef7921f74844 Reviewed-on: https://chromium-review.googlesource.com/789613 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49779}
-
Camillo Bruni authored
This CL introduces a Context::kInvalidContext sentinel value to make clear that no context is active. We silently accept smi 0 (= nullptr) as a non-set context which usually was the default value making it hard to ensure whether this happened on purpose or not. Change-Id: I5c35616f26b0b64c1cd976563a6eeb0ce474927d Reviewed-on: https://chromium-review.googlesource.com/790291Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49778}
-
Georg Neis authored
Bug: v8:6791 Change-Id: I1c57fc697dc143fec8bfd67db16c7bc4f840462d Reviewed-on: https://chromium-review.googlesource.com/800620 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49777}
-
Georg Neis authored
It reflects the semantics of ToBoolean, so it must be adapted for bigints. Bug: v8:6791 Change-Id: I18931df21528463dacf5ad50fa8264b1c968c6b5 Reviewed-on: https://chromium-review.googlesource.com/799831Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49776}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64dd7ca..a7ac13d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/505de88..282996b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9968f9b..280aff0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I906b25bd37386e64137a37a0706ca2b0103a0143 Reviewed-on: https://chromium-review.googlesource.com/803034Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49775}
-
jing.bao authored
Bug: Change-Id: I0868da7ee73f1c7637d9c79b6c78f27557cd14a4 Reviewed-on: https://chromium-review.googlesource.com/792653Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#49774}
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I976876a4956b5c65f6f3788389f42d394d08dc99 Reviewed-on: https://chromium-review.googlesource.com/788513 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49773}
-
- 30 Nov, 2017 10 commits
-
-
Alexey Kozyatinskiy authored
R=pfeldman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9005cd355f05143daeb125d851d18ff2c0924256 Reviewed-on: https://chromium-review.googlesource.com/801338Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49772}
-
Michal Majewski authored
TBR=jgruber@chromium.org Bug: v8:7120 Change-Id: I50b852a4526103d56b3a2c60c4a88b5ecaecf9bb Reviewed-on: https://chromium-review.googlesource.com/801270 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49771}
-
Michael Achenbach authored
This reverts commit e42e7fc8. Reason for revert: Speculative revert for: https://crbug.com/v8/7149 Original change's description: > [objects] No longer create short external strings. > > This fixes String::MakeExternal() to bail out if the subject string > doesn't fit a regular ExternalString, instead of creating a short > external string. The observation here is that for short external strings > the overhead of having to have the StringResource plus going to the > runtime/C++ for each and every character access from JavaScript land > is probably bigger than the anticipated benefits. > > If this turns out to be wrong and there's a real benefit, we should make > use of ThinStrings instead of having a separate way to represent > external strings. > > Bug: v8:6621, v8:7109, v8:7145 > Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d > Reviewed-on: https://chromium-review.googlesource.com/799750 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49735} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: I3f5cfa9ab5c99ddce1d61ede9ed9515cb3936cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6621, v8:7109, v8:7145, v8:7149 Reviewed-on: https://chromium-review.googlesource.com/801675Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49770}
-
Ulan Degenbaev authored
This save ~40KB of code size in release mode. Bug: Change-Id: Ibdf7e64bb2592f53a4edf07665016dd5a65714a0 Reviewed-on: https://chromium-review.googlesource.com/801515Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49769}
-
Clemens Hammacher authored
This reverts commit 163c1c82. Reason for revert: Throws std::bad_alloc on linux: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/21927; needs investigation. Original change's description: > [wasm] Gracefully handle malformed custom sections in WebAssembly.Module.customSections(). > > R=clemensh@chromium.org > BUG=chromium:789952 > > Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 > Reviewed-on: https://chromium-review.googlesource.com/800941 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49767} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I63fbd8f55025f53c453e91d0f7a181c21ae53a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:789952 Reviewed-on: https://chromium-review.googlesource.com/801554Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49768}
-
Ben L. Titzer authored
R=clemensh@chromium.org BUG=chromium:789952 Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 Reviewed-on: https://chromium-review.googlesource.com/800941Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49767}
-
Ulan Degenbaev authored
This fixes false positive data race reported by TSAN. Bug: chromium:790004 Change-Id: I6335af1735fe9ea77a26cc9919ec4f089b004cdf Reviewed-on: https://chromium-review.googlesource.com/800936Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49766}
-
Michael Lippautz authored
This reverts commit b4d2f3eb. Bug: chromium:651354, chromium:788113 Change-Id: I04b7541e7eb69f737d45e90bbfec591cf8f8190f Reviewed-on: https://chromium-review.googlesource.com/800552Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49765}
-
Camillo Bruni authored
Bug: chromium:757467 Change-Id: I52f8100e0c8b4ac07e1f875e44cb468fa8ce572b Reviewed-on: https://chromium-review.googlesource.com/793611Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49764}
-
Ali Ijaz Sheikh authored
(Previously landed as #48513 / e770879e) (Previously landed as #48606 / d0e3fb4f) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: Change-Id: I302fb52fb47b6c9d59dd2b28eb9923c37881c15b Reviewed-on: https://chromium-review.googlesource.com/794857Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#49763}
-