• Shiyu Zhang's avatar
    [ic] Do not convert undefined key to undefined_string. · ffcb51b2
    Shiyu Zhang authored
    In the special case of KeyedLoadIC, where the key is always undefined,
    LowerCheckEqualsInternalizedString fails and triggers deoptimization
    loops. It's because {exp}, which is undefined_string, does not match
    {val}, which is undefined_value.
    
    This patch drops the convertion from undefined_value to undefined_string
    for undefined key in KeyedLoadIC. It makes undefined key be able to pass
    LowerCheckEqualsInternalizedString and avoids the deoptimization loops.
    
    Bug: 
    Change-Id: Ie15358e705490fb2e4907f4d37a3ef7921f74844
    Reviewed-on: https://chromium-review.googlesource.com/789613
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49779}
    ffcb51b2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...