- 04 Dec, 2018 22 commits
-
-
Junliang Yan authored
Port 6c8b4102 Original Commit Message: This is a reland of d5f4a33e Landing with test disabled for now. Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} R=petermarshall@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie82eaa08ba6ceeb0c0a5bb4de251540becf1f05e Reviewed-on: https://chromium-review.googlesource.com/c/1361422Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58025}
-
Clemens Hammacher authored
This is a reland of c2aaf0a6 Original change's description: > [wasm][liftoff] Optimize one-armed ifs > > Do not implement one-armed ifs by emulating an empty else branch. In > Liftoff, we can generate better code and save compile time by handling > this specially. If the merge point at the end of the if is not reached > by the if-branch, we do not need to generate any merge code. > > R=titzer@chromium.org > > Bug: v8:6600, v8:8423 > Change-Id: Ie8ea69dd7491f225605a8e1b986d275d869aa90b > Reviewed-on: https://chromium-review.googlesource.com/c/1356508 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57968} Bug: v8:6600, v8:8423 Change-Id: I6d5eea9f860486768779a33bf6bd7b87cbfc2af0 Reviewed-on: https://chromium-review.googlesource.com/c/1361040Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58024}
-
Clemens Hammacher authored
Improve readability by avoiding a helper method. Just read from the stack directly. R=titzer@chromium.org Change-Id: I38c944fac45c721f328a2b7bec3a3f4602f05c05 Reviewed-on: https://chromium-review.googlesource.com/c/1360572 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mike Stanton authored
Building on https://chromium-review.googlesource.com/c/v8/v8/+/1349243, which asserted on calls to GetChars() that weren't in a DisallowHeapAllocation scope, this CL takes a reference to the scope in order to provide static protection in all builds. Bug: v8:8238 Change-Id: I481a1dbbd3ae57eb35c5f828c5e242691635be27 Reviewed-on: https://chromium-review.googlesource.com/c/1354038Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#58022}
-
Leszek Swirski authored
This reverts commit e774cffe. Reason for revert: Breaks OptimizeForSize tests https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8928056438104852432/+/steps/OptimizeForSize/0/logs/TestCodeAssemblerCode../0 Original change's description: > [code-comments] Put code comments into the code object > > Code comments in the snapshot can now be enabled with gn > arg 'v8_enable_snapshot_code_comments' > > Bug: v8:7989 > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 > Reviewed-on: https://chromium-review.googlesource.com/c/1329173 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58020} TBR=mvstanton@chromium.org,mstarzinger@chromium.org,sigurds@chromium.org,jgruber@chromium.org Change-Id: Ie336a99218db4def848bd5c8c58dfb66f0e372b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7989 Reviewed-on: https://chromium-review.googlesource.com/c/1361165Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58021}
-
Sigurd Schneider authored
Code comments in the snapshot can now be enabled with gn arg 'v8_enable_snapshot_code_comments' Bug: v8:7989 Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 Reviewed-on: https://chromium-review.googlesource.com/c/1329173 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#58020}
-
Peter Marshall authored
The flakiness of this test was fixed by https://chromium-review.googlesource.com/c/v8/v8/+/1280436 which removed calls to StartTickSample() and FinishTickSample() from tests as this causes a race. Bug: v8:6133, v8:5193 Change-Id: Ia6bcfa75cce64547b00a185343ada803d082a12e Reviewed-on: https://chromium-review.googlesource.com/c/1361163Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58019}
-
Peter Marshall authored
It's possible that we encounter incorrect SP or FP values while unwinding the stack. One reason is that third-party code like virus protection may change the stack. If we encounter values for SP or FP that don't make sense, we should bail out of unwinding and return false. Bug: v8:8116, chromium:909957 Change-Id: I630fef3f619382c7035be50b86072be349ed185c Reviewed-on: https://chromium-review.googlesource.com/c/1358514Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 270437fd. Reason for revert: Performance regressions look ok, and we need the change going forward. Original change's description: > [csa] disable CSA re-scheduling > > Disable CSA re-scheduling for the branch point, to address performance > regressions. > > Bug: chromium:907011 > Change-Id: I608ae23c20d8e1dd9a233dcb2d3f4ab4d8a5241e > Reviewed-on: https://chromium-review.googlesource.com/c/1351009 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57930} TBR=mstarzinger@chromium.org,jarin@chromium.org,tebbi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:907011 Change-Id: I322f6f3bdd6e833a2a546025995ecdc823961804 Reviewed-on: https://chromium-review.googlesource.com/c/1358513Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58017}
-
Yang Guo authored
R=delphick@chromium.org Bug: v8:7281 Change-Id: I4af641218d4646d3cdf3a2776e9bc24141164638 Reviewed-on: https://chromium-review.googlesource.com/c/1357054Reviewed-by:
-
Yang Guo authored
R=delphick@chromium.org Change-Id: Iad128dc76a8d399bbf18053fc1f32e34fa36c198 Reviewed-on: https://chromium-review.googlesource.com/c/1357056Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org Bug: v8:8532 Change-Id: Icbbb7a9de260c8bf29fb13f3f182652b1cb0259a Reviewed-on: https://chromium-review.googlesource.com/c/1358511Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58014}
-
Sven Sauleau authored
Replaces some DCHECK with their verbose equivalent because it's more convenient while debugging. Change-Id: I83c199c389341a68dfccd949e7353ef68ff3b9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1352289Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#58013}
-
Clemens Hammacher authored
This reverts commit c2aaf0a6. Reason for revert: Benchmarks fail, and ClusterFuzz is not happy (issue 911406, issue 911271) Original change's description: > [wasm][liftoff] Optimize one-armed ifs > > Do not implement one-armed ifs by emulating an empty else branch. In > Liftoff, we can generate better code and save compile time by handling > this specially. If the merge point at the end of the if is not reached > by the if-branch, we do not need to generate any merge code. > > R=titzer@chromium.org > > Bug: v8:6600, v8:8423 > Change-Id: Ie8ea69dd7491f225605a8e1b986d275d869aa90b > Reviewed-on: https://chromium-review.googlesource.com/c/1356508 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57968} TBR=titzer@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6600, v8:8423 Change-Id: I5cb3b069f40e34f34da4013e666f6ff293752567 Reviewed-on: https://chromium-review.googlesource.com/c/1360633Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58012}
-
Clemens Hammacher authored
R=ahaas@chromium.org Change-Id: Id8b1dbaf363e7c0b8b0011f5ceb1e77badd622e6 Reviewed-on: https://chromium-review.googlesource.com/c/1360571Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58011}
-
Camillo Bruni authored
Drive-by-fixes: - Rename RestoreData to RestoreDataForScope - Move Scope's private variable declaration to after functions Change-Id: I349b2fc05cd94d6d7a0745b28b4e66b898b5e147 Reviewed-on: https://chromium-review.googlesource.com/c/1358517Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58010}
-
Sigurd Schneider authored
This CL improves typed optimization more: ChangePlainPrimitiveToNumber is only omitted if it is not required. Change-Id: I5d81537a046c5a5a0c730fcd1e17bbdfda887687 Bug: v8:910562 Reviewed-on: https://chromium-review.googlesource.com/c/1357058Reviewed-by:
-
Jaroslav Sevcik authored
It is possible this CL results in various regressions, the idea is to get some data on where constant tracking helps and where it regresses. Bug: v8:8361 Change-Id: I2f291788a8bea03e6eaac9f51564c1da02734d1a Reviewed-on: https://chromium-review.googlesource.com/c/1347474 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58008}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Change-Id: Ia49bf1d4a096e72c6584297ef5db0eaf85938178 Reviewed-on: https://chromium-review.googlesource.com/c/1360573Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/42a08f0..f686dfc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6f862e5..4feee58 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/61ea307..d87b096 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I35746d4d32d6456ce7bf9320b64efbc2e3f3933a Reviewed-on: https://chromium-review.googlesource.com/c/1360074Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58006}
-
Jakob Gruber authored
This is the first (and major) step towards converting CallApiCallback and CallApiGetter stubs into builtins. The CallApiCallbackStub was parameterized with the number of arguments passed on the stack. This CL converts the compile-time parameter into an explicit runtime parameter, and removes all uses of the stub parameter. Drive-by: The implementation is now mostly consistent across platforms. Drive-by: Refactor the calling convention to free up two registers (kCallData and kHolder are now passed on the stack). Bug: v8:7777 Change-Id: I212dccc2930de89c264a13755918c9fae7842f1f Reviewed-on: https://chromium-review.googlesource.com/c/1354887 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
For this to work, I had to move PropertyCell out of objects.h too, since otherwise there would be an inl include cycle which makes the code not compile. BUG=v8:5402,v8:8238 Change-Id: I3233f86b68c1e2fd32d135fcf0bbba8101af8cb2 Reviewed-on: https://chromium-review.googlesource.com/c/1356510Reviewed-by:
-
- 03 Dec, 2018 15 commits
-
-
Jakob Kummerow authored
and also its pure-static subclass PrototypeUsers, whose porting is a no-op. Bug: v8:3770 Change-Id: I075806f784a0631058692149e71c45e455e90f73 Reviewed-on: https://chromium-review.googlesource.com/c/1355631 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
to the new design. Bug: v8:3770 Change-Id: I8483d47ac77e756395656628a80257e6462de22c Reviewed-on: https://chromium-review.googlesource.com/c/1355630Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Junliang Yan authored
This is to address the first issue reported on v8:8453 Page::kPageSize is 524288 MemoryAllocator::GetCommitPageSize() returns 65536 on ppc ObjectEndOffsetInCodePage() returns 458752 ObjectStartOffsetInCodePage() returns (65536 + 65536) => 131072 Therefore, memory = 327680, which is less than kMaxRegularHeapObjectSize(507136), which causes the DCHECK to fail. Bug: v8:8453 Change-Id: I6048192ded4234a6987371ec4d4b2a8553756c25 Reviewed-on: https://chromium-review.googlesource.com/c/1355422 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58001}
-
Nico Weber authored
Bug: chromium:911183 Change-Id: I99552d09e68a6b99e35daf39e15ddf1ef5781baa Reviewed-on: https://chromium-review.googlesource.com/c/1358701Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58000}
-
Vasili Skurydzin authored
architecture. Bug: v8:8402 Change-Id: I13928b6946b8fa68ccd8d329c8a0856313a10571 Reviewed-on: https://chromium-review.googlesource.com/c/1357159Reviewed-by:
-
Joran Siu authored
CPU features printout needs to use PrintF macro, in order for the output to be in correct native encoding. R=michael_dawson@ca.ibm.com, jyan@ca.ibm.com Change-Id: If1762e452cdfe8c0ca954676acb20c1e60df8d2f Reviewed-on: https://chromium-review.googlesource.com/c/1357160 Commit-Queue: Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57998}
-
Igor Sheludko authored
broken by: [cleanup] Fix kPointerSize usages in src/objects/bigint.* Bug: v8:8477, v8:8238 Change-Id: If1961ae42e1969d4ee807ea052a9c4cf4f072d0f Reviewed-on: https://chromium-review.googlesource.com/c/1357046 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
George Wort authored
Move lhs into dst when lhs == rhs. Bug: v8:6600, chromium:910223 Change-Id: I5bcb01b57705c52f363a43b2036f0ade0fd451e7 Reviewed-on: https://chromium-review.googlesource.com/c/1357041 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since all other values are not used any more if we return, we don't need to spill anything (as might happen during {PopToRegister}). Instead, just load the top stack value into the return register(s). R=titzer@chromium.org Bug: v8:6600, v8:8423 Change-Id: Ibfd02d20191459c7b136ab9a48f0cf1a53b3385d Reviewed-on: https://chromium-review.googlesource.com/c/1358391 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Toon Verwaest authored
Rename ParseIdentifierOrStrictReservedWord to simply ParseIdentifier and replace the old ParseIdentifier with ParseNonRestrictedIdentifier for the disallow_restricted_identifier case. It reuses the new ParseIdentifier. Clients that relied on the is_strict_reserved output parameter can simply check the token themselves. Change-Id: I49b096d7ffbfff391483e9c18c9504e5d353e97b Reviewed-on: https://chromium-review.googlesource.com/c/1357057Reviewed-by:
-
Toon Verwaest authored
- Rename methods, - Introduce flags for tokens to lookup IsKeyword and IsPropertyName - Remove "contextual keyword" leftover code. - Inline ParsePropertyName into ParsePropertyNameOrPrivatePropertyName since public is more likely than private. Change-Id: Ib7633ef3c46889ecafc7a6c929029845bb8ef15c Reviewed-on: https://chromium-review.googlesource.com/c/1357052 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Remove IdentifierOrEnum and AwaitOrYield and reduce Callable to exclude enum. Change-Id: Id80c0c5e7a8d4869ab8d841f3b973ea7c0c844cc Reviewed-on: https://chromium-review.googlesource.com/c/1357044 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
If they are part of a keyed store they are pushed later using impl()->PushPropertyName. Change-Id: I9c104d15722dd59556c04fe3d4b0018c37d0f553 Reviewed-on: https://chromium-review.googlesource.com/c/1357055Reviewed-by:
-
Stephan Herhut authored
The register allocator spends significant amounts of time on updating the state of active and inactive live range sets. In many cases, no update is needed. By precomputing when the next update is due during state management, we can avoid unnecessary checks. This cuts the time spent for managing queues in half. Change-Id: I44074266bed2f09171872a829f115e61608b76c8 Reviewed-on: https://chromium-review.googlesource.com/c/1352308Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#57990}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8373abc..42a08f0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia1bc23643a569120a6fb22e912f1b06c8e15679b Reviewed-on: https://chromium-review.googlesource.com/c/1356913Reviewed-by:
-
- 02 Dec, 2018 3 commits
-
-
Frank Tang authored
Also split out some order check tests. Bug: v8:5751 Change-Id: I1765d1809b456c43e21d9a379f720a0ea12e794e Reviewed-on: https://chromium-review.googlesource.com/c/1352283Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fe88ff7..8373abc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib2f4e3846ba51a5ed9d07005ad9d3f8fb0604c74 Reviewed-on: https://chromium-review.googlesource.com/c/1356910Reviewed-by:
-
Mathias Bynens authored
The `readonly: true` key-value pair is redundant since it gets ignored anyhow. This patch removes it. Also, `configurable: false` is implied when using `Object.defineProperty` (just like `enumerable: false` and `writable: false`). Therefore, specifying only `configurable` but not `enumerable` and `writable` gave the impression that configurability was somehow the deciding factor for this test. Instead, the only important data property for this test is `writable: false`. This patch lists all four data property attributes explicitly, making it clear that only `writable` has a “special” value. Bug: v8:8175, v8:8238 Change-Id: Icfc6262f246712a64cdfcffff7b648f5681a711e Reviewed-on: https://chromium-review.googlesource.com/c/1357048Reviewed-by:
Caitlin Potter <caitp@igalia.com> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#57986}
-
