• Mathias Bynens's avatar
    [cctest] Clarify OverrideReadOnlyPropertyOnPrototype setup · e000fa36
    Mathias Bynens authored
    The `readonly: true` key-value pair is redundant since it gets
    ignored anyhow. This patch removes it.
    
    Also, `configurable: false` is implied when
    using `Object.defineProperty` (just like `enumerable: false`
    and `writable: false`). Therefore, specifying only `configurable`
    but not `enumerable` and `writable` gave the impression that
    configurability was somehow the deciding factor for this test.
    Instead, the only important data property for this test is
    `writable: false`. This patch lists all four data property
    attributes explicitly, making it clear that only `writable` has
    a “special” value.
    
    Bug: v8:8175, v8:8238
    Change-Id: Icfc6262f246712a64cdfcffff7b648f5681a711e
    Reviewed-on: https://chromium-review.googlesource.com/c/1357048Reviewed-by: 's avatarCaitlin Potter <caitp@igalia.com>
    Commit-Queue: Mathias Bynens <mathias@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57986}
    e000fa36
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...