Skip to content

V
V8
Switch branch/tag
  1. 01 Apr, 2022 1 commit
  3. 14 Mar, 2022 1 commit
  5. 02 Nov, 2021 1 commit
  7. 01 Oct, 2021 1 commit
  9. 19 Aug, 2021 1 commit
  11. 28 Jun, 2021 1 commit
  13. 18 Jun, 2021 1 commit
  15. 10 Jun, 2021 1 commit
  17. 30 Apr, 2021 1 commit
  19. 22 Apr, 2021 1 commit
  21. 22 Mar, 2021 1 commit
  23. 12 Mar, 2021 1 commit
    • Andreas Haas's avatar
      [wasm][liftoff][arm64] Avoid x28 even without pointer compression · 8d0f5a04
      Andreas Haas authored 
      Due to a recent change Liftoff used different register configurations
in the pointer-compression and no-pointer-compression setups. This
caused a mismatch between the registers used by Liftoff and the
registers spilled by the WasmDebugBreak builtin.

With this CL the same register configuration is used both with and
without pointer compression. Even without x28 there are 24 registers
that can be used. Moreover, 24 registers can be spilled without
padding, which would be needed with 25 registers to preserve stack
alignment.

Drive-by change: Use Reglist in frame-constants on all platforms.

R=jkummerow@chromium.org

Bug: v8:7581
Change-Id: Iae2892718e905a7995a3fdd7be7fd4d75bebb3dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752884
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73366}
      8d0f5a04
  25. 11 Mar, 2021 1 commit
  27. 24 Feb, 2021 1 commit
  29. 15 Feb, 2021 1 commit
  31. 09 Feb, 2021 1 commit
  33. 05 Feb, 2021 1 commit
  35. 29 Jan, 2021 1 commit
  37. 19 Jan, 2021 1 commit
    • Seth Brenith's avatar
      [arm][arm64] Use normal fp semantics in JSEntry · a016c9fe
      Seth Brenith authored 
      On arm64, Windows Performance Recorder gets confused by the fact that fp
in Builtins_JSEntry doesn't point to the saved {fp, lr} pair for the
caller frame. The expected usage of fp is documented in [1]:

  The frame pointer (x29) is required for compatibility with fast stack
  walking used by ETW and other services. It must point to the previous
  {x29, x30} pair on the stack.

In slightly more detail, the Windows function RtlWalkFrameChain is
responsible for generating stack traces during profiling with Windows
Performance Recorder, and that function relies on the rule quoted above.
Notably, it does not make any effort to read the unwinding data that one
could obtain with RtlLookupFunctionEntry. Stack walks using that data,
such as those performed by WinDbg and the cctest StackUnwindingWin64,
work fine.

It would be convenient if we could use fp in a more standard way during
JSEntry so that Windows profiling tools work correctly. (We can also
reduce JSEntry by two instructions in doing so.)

Both arm and arm64 currently put a -1 value on the stack at the location
that fp points to. This could prevent accidental access during the
epilog of JSEntry, where fp might be zero. However, we believe that this
protection is no longer necessary, and any bug that causes a read from
fp during the end of JSEntry would cause various CQ failures.

[1] https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-160

Change-Id: Iece5666129b9188fc4c12007809b50f046f4044f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2607636
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72165}
      a016c9fe
  39. 12 Jan, 2021 1 commit
  41. 14 Dec, 2020 1 commit
  43. 10 Dec, 2020 1 commit
  45. 09 Dec, 2020 1 commit
  47. 07 Dec, 2020 3 commits
  49. 03 Dec, 2020 2 commits
  51. 02 Dec, 2020 2 commits
  53. 30 Nov, 2020 1 commit
  55. 25 Nov, 2020 2 commits
  57. 17 Nov, 2020 1 commit
  59. 10 Nov, 2020 1 commit
  61. 09 Nov, 2020 1 commit
  63. 03 Nov, 2020 3 commits
  65. 02 Nov, 2020 1 commit