- 28 Sep, 2020 2 commits
-
-
Camillo Bruni authored
Bug: v8:10668 Change-Id: I51f81a66408a4b262f9ac7e6421609c5e485f779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435107 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70174}
-
Camillo Bruni authored
This changes all tools to use ES6 modules and proper imports. Step 1: Add converted .mjs files (*this CL*) Step 2: Update node-ci build to use new .mjs files Step 3: Remove outdated .js files Bug: v8:10667, v8:10933 Change-Id: I3e92e66f896d8a9cacaf6d421f8d2c86fb3bc444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431045 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70163}
-
- 23 Sep, 2020 1 commit
-
-
Camillo Bruni authored
- Create SourcePosition objects for Map and IC log entries - Display source code with markers for SourcePositions - Avoid some try-catches for a better debugging experience Bug: v8:10644 Change-Id: I559b0eaeaa1442986a00d2ef720d19ba85178509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424258Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70091}
-
- 17 Sep, 2020 1 commit
-
-
Zeynep Cankara authored
This CL updates the tool instructions to reflect changes in the tool. Removes the empty <br> tags from the tool's panel templates. Bug: v8:10644, v8:10727 Change-Id: I0b3db6adcd37518f9cdaf2839094ef86eff52dfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2413253Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69963}
-
- 16 Sep, 2020 1 commit
-
-
Zeynep Cankara authored
This CL deletes the image on the timeline overview which only reflects the last uploaded timeline-track data and updates the timelineOverviewIndicator on mousemove and chunk zoom events. Bug: v8:10644 Change-Id: Ib0a43083d2461cc343a0c946cfddaf4fdc514687 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2413257Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69936}
-
- 02 Sep, 2020 3 commits
-
-
Zeynep Cankara authored
This CL unifies the map-processor and ic-processor into a single log processing pipeline. Unified processing pipeline prevents doing 2 pass over the data. Bug: v8:10644 Change-Id: Ic0221a9bb32901f43202390b98fded4830a50f70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2385496 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69676}
-
Zeynep Cankara authored
This CL enables showing map details of the selected map coming from FocusEvent. It also improves UI experience of selecting a map from map transitions, highlighting selected map. Additionally, stores information about unique map/IC events in model for the timeline-track legend. Bug: v8:10644 Change-Id: Ieb8a2ac0bf1af282d55bce18130192d7178538da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387564Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69673}
-
Zeynep Cankara authored
This CL adds drag handlers to the timeline panel to filter events based on the selected portion of the timeline tracks. Bug: v8:10644 Change-Id: Ic8a38493eacb62844b3fed5a027f8b1367f2bb59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346275 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69669}
-
- 28 Aug, 2020 3 commits
-
-
Zeynep Cankara authored
This CL adds a source code panel to display source code positions of Map/IC log events. * Clicking file positions on the Ic Panel emits FocusEvent with SourcePositionLogEvent as entry to highlight code related with the selected icLogEvent. * Clicking map details on the Map Panel emits FocusEvent with SourcePositionLogEvent as entry to highlight code related with the selected mapLogEvent. Bug: v8:10644 Change-Id: Icaf3e9e3f7fae485c50ad685f9ec5dc8ac28b3dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358734 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69610}
-
Zeynep Cankara authored
Changes: * Transition edges on timeline-track with the same color of the map type. * Log file reader loading background adapted to light theme. * Support additional IC log event colors. * Move theme switch button to top of the app. Bug: v8:10644, v8:10673 Change-Id: Ib086b6f4a8bc5f86a4925b251112c640e37278ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2379869Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69600}
-
Zeynep Cankara authored
Bug fixes: * Wrong time range selection of timeline chunks handled by mouse events. * Consecutive file uploads does not create a new Model object causing bugs on timeline-track start and end times. Bug: v8:10644 Change-Id: I3d31ddda1ffca70c18c87dd103f2b788713c2911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2379863Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69598}
-
- 27 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL fixes the bug related with chunk position initialisation. The bug caused by not subtracting the timeline chunk start time from chunk start time. Additionally, it corrects the offset being used while detecting the chunk location. Bug: v8:10644 Change-Id: Icf426a297402f87d2acda0b2aa747b90e91686c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2377740Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69589}
-
- 26 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL unifies both map-processor and ic-processor's map processing pipeline to the same format. Also, adds the functionality to search for map transitions on map panel by clicking on map property of the ic-panel. Bug: v8:10644 Change-Id: I9f95feebb08620fd489486cf459ebe0babbd32d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367865Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69567}
-
- 25 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
Action items: * Replace alls css @import with link tags. * Format all sources in system-analyzer/*. Bug: v8:10644 Change-Id: I6354cf7b0ed2aca8cdab4888cf9d504a1d963b50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367869 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69545}
-
- 24 Aug, 2020 2 commits
-
-
Zeynep Cankara authored
This CL highlights the items with clickable functionality. It is implemented based on the received feedback from the V8 Mobile Team. Bug: v8:10644 Change-Id: I0489327681d485eedde59594d36083efdc216575 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2370626Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69537}
-
Zeynep Cankara authored
This cleanup CL adds a timeline property to ic-panel and directly assigns the logEvents to selectedLogEvents upon data load. Bug: v8:10644 Change-Id: Ic1707ea237abbf57417c0b14e24fc0bf797d9679 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2370627Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69535}
-
- 20 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL adds a table to the right side of the each timeline-tracks to display statistics about the log events. Double clicking on an event type notifies other panels about the selected log events with the selected type. Bug: v8:10644 Change-Id: Iae523d46da4f0b6a007b02a2beac23d9c48aca02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2353457 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69498}
-
- 17 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL changes min/max of panel sizes for a better user experience. Additionally, removes the scroll bars while keeping the scroll functionality to alleviate the cluttered view. Bug: v8:10644 Change-Id: Ib95ed79dd58dbcd6b1932eb366f9d2177407c853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356346Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69415}
-
- 14 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL fixes the chunk locations on timeline-tracks. The App updates the Ic panel upon receiving FocusEvent with an entry of ICLogEvent. Bug: v8:10644 Change-Id: I4d09851c154196cc6cb1544a275ed33c8ae8a8af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354814 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69399}
-
- 13 Aug, 2020 4 commits
-
-
Zeynep Cankara authored
This CL establishes a naming consistency across the app by renaming classes. Class Name Changes: SelectEvent -> FocusEvent Entry -> IcLogEvent V8Map -> MapLogEvent Bug: v8:10644 Change-Id: Id075d9aa36ac6f03af0224feb0e38985b1445013 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349300 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69382}
-
Zeynep Cankara authored
This CL adds the functionality to filter IC Panel via double clicking on the event type on Timeline Panel. Bug: v8:10644 Change-Id: I47cdf87652a8f6fc25a5c1a5b0270d97ed9068b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352773 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69377}
-
Zeynep Cankara authored
This CL adds the functionality to filter log events falling into the time range specified by the user via mouse events on timeline tracks. The log event selections on panels updated based on the selected time range. Bug: v8:10644 Change-Id: Iaf53896fd5c43cefea6d4c40bab5fcb136494b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351670 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69375}
-
Zeynep Cankara authored
This CL integrates a navigation controller to zoom in and out of timeline events and navigate in map panel using key events. Bug: v8:10644 Change-Id: I80496c086b0342b009bbbc3d45282b95cbe82e0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351659 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69367}
-
- 12 Aug, 2020 2 commits
-
-
Zeynep Cankara authored
This CL changes the panel layout by implementing a grid format. The new layout displays Map and IC panel side by side and making it easier to control the position of panels. Bug: v8:10644 Change-Id: Ic9b48459dd67741c1c39ed2c350ee7c552f1cc92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343081 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69361}
-
Zeynep Cankara authored
This CL maximises the space use in between panels and fixes asymmetries in the Web app to make the UI panel views more compact and increase accessibility of the web app for different screen size. Bug: v8:10644 Change-Id: I07bf6317db2cf3fa59204120276f0f885e356e6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351660Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69358}
-
- 11 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL checks the version of the log file by checking the format of Map Objects processed by the IC processor. The version check requirement came from the modified IC event logging pipeline of the V8. Bug: v8:10644 Change-Id: Ic661a34cfaf15edfde5fa24588275ac055a5bb5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343067 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69333}
-
- 07 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL unifies the custom events by creating classes specialised based on the event type. Multiple entry selection causes panels to emit 'showentries' event. Single entry selection causes panels to emit 'showentrydetail' event. The events are received by the controller App class and updates the view of the panels and state of the app. Bug: v8:10644 Change-Id: Ibe26223459ba605c6d6d3f0025bf3a556dfb0578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335188 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69286}
-
- 06 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL sync the timeline-tracks positions upon receiving a horizontal scrolling event. Bug: v8:10644 Change-Id: I69bc1066a3f5da6ddc978ad71fe77820df8066bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336806 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69263}
-
- 05 Aug, 2020 2 commits
-
-
Zeynep Cankara authored
This CL aligns the timeline tracks by tracking the global start and end timestamps of both Map and IC events. Bug: v8:10644, v8:10735 Change-Id: Ib0ad086cdcb8ae3ae734df6480c5567f1f5125c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335183Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69242}
-
Zeynep Cankara authored
This CL initialises the change theme button in correct place and adds the functionality to change theme after the data load. Bug: v8:10644 Change-Id: I7397933ff9d12a2ac270d025df1b3327801d89be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336800Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69238}
-
- 04 Aug, 2020 2 commits
-
-
Zeynep Cankara authored
Add functionality to emit an event upon double clicking on an event type on the timeline track selected entries panel. Bug: v8:10644 Change-Id: I54d4397abfeab471f01c2b24bae4eb1ff705afcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2328787Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69222}
-
Zeynep Cankara authored
This CL aims to clean the code in App Class to handle State, View according to the Model-View-Controller design pattern. Bug: v8:10644, v8:10735 Link: https://docs.google.com/presentation/d/1ssCIWKS5TIp_PHZRUx2BfElEz6JFrYzz_Ce1h1g8ZBg/edit?usp=sharing Change-Id: Ie36d437df0df574f505a4396b26526a82215f237 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324247 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69218}
-
- 29 Jul, 2020 1 commit
-
-
Zeynep Cankara authored
This CL aims to clean dead code across the app and use private class fields for storing private information. Bug: v8:10644, v8:10735 Change-Id: I1129104925f230bed922cc76abdb432d536d2111 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2323352Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69125}
-
- 28 Jul, 2020 2 commits
-
-
Zeynep Cankara authored
This CL creates a timeline track component to make the timeline view extensible as different data sources added. The timeline track component will take data source and display it with respect to time axis of timeline overview. Bug: v8:10644, v8:10735 Change-Id: I1c88dd2dc967be68e6235e517dcf8554a891eee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2302053 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69102}
-
Zeynep Cankara authored
This CL use the introduce color variables to adapt light theme feature to increase accessibility. Bug: v8:10644 Change-Id: I179831aef384527b0457c6ae93fa4d42a1814834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305891 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69093}
-
- 27 Jul, 2020 1 commit
-
-
Zeynep Cankara authored
This CL adds a generic Event Class to unify common methods of IC and Map events. The Entry Class for IC Events and V8Map Class for Map Events inherits from this generic Event Class. Bug: v8:10644, v8:10735 Change-Id: I77d68fb40ee0ffbe297fcd1a13c3e2b746938168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317309 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69066}
-
- 24 Jul, 2020 1 commit
-
-
Zeynep Cankara authored
This CL adds a Timeline Class to handle data interaction between panels. The timeline class enables to filter the data based on selected time range. Bug: v8:10644, v8:10735 Change-Id: I7fbbe1741abc69d2889b0547113e5da10b7f5510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315983 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69056}
-
- 23 Jul, 2020 2 commits
-
-
Zeynep Cankara authored
This CL enables the hide panel functionality upon uploading a new file. File reader emits fileuploadstart event when it receives a new file which hides the panels. Bug: v8:10644 Change-Id: Ic26cce1a92559efd494f2ef1e32b514897a73324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305892 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69015}
-
Zeynep Cankara authored
This CL decouples the timeline panel view handling from map panel view handling. Having separate panel view handling for each panel aims to encapsulate panel behaviours force panels to emit events rather than depending on other panels. Bug: v8:10644, v8:10735 Change-Id: Icd6e8ee8a0e8d1fdbbaaf2754f272300e0499bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305894 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69014}
-
- 22 Jul, 2020 1 commit
-
-
Zeynep Cankara authored
This CL redesigns the IC Panel to emit events upon time range selection. IC entry time range specified from the input fields and entries falling into the selected time range bubbled up to the App controller. The IC panel emits events upon selection of a map or a source file location. Bug: v8:10644 Change-Id: I468dc52b7a6c62dbdee096e80cc6110ceb994f69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305893 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69006}
-