Commit 57b33e29 authored by Zeynep Cankara's avatar Zeynep Cankara Committed by Commit Bot

[tools][system-analyzer] Add dblclick for ic categories

This CL adds the functionality to filter IC Panel
via double clicking on the event type on Timeline
Panel.

Bug: v8:10644


Change-Id: I47cdf87652a8f6fc25a5c1a5b0270d97ed9068b7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352773
Commit-Queue: Zeynep Cankara <zcankara@google.com>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69377}
parent 4828af82
......@@ -50,8 +50,22 @@ class App {
handleShowEntries(e) {
if (e.entries[0] instanceof V8Map) {
this.showMapEntries(e.entries);
} else if (e.entries[0] instanceof Entry) {
this.showIcEntries(e.entries);
} else {
console.error("Undefined selection!");
}
}
showMapEntries(entries) {
this.#state.selectedMapLogEvents = entries;
this.#view.mapPanel.selectedMapLogEvents = this.#state.selectedMapLogEvents;
}
showIcEntries(entries) {
this.#state.selectedIcLogEvents = entries;
//TODO(zcankara) use selectedLogEvents
this.#view.icPanel.filteredEntries = this.#state.selectedIcLogEvents;
}
handleTimeRangeSelect(e) {
this.selectTimeRange(e.start, e.end);
}
......@@ -78,10 +92,6 @@ class App {
this.#view.mapPanel.selectedMapLogEvents = this.#state.mapTimeline.selection;
this.#view.icPanel.filteredEntries = this.#state.icTimeline.selection;
}
showMapEntries(entries) {
this.#state.selectedMapLogEvents = entries;
this.#view.mapPanel.selectedMapLogEvents = this.#state.selectedMapLogEvents;
}
selectMapLogEvent(entry) {
this.#state.map = entry;
this.#view.mapTrack.selectedEntry = entry;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment