- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 18 Feb, 2019 1 commit
-
-
Maciej Goszczycki authored
Change-Id: I25a2299e5e261cc125c7ff0e1acdeddbd7f664ff Reviewed-on: https://chromium-review.googlesource.com/c/1475753Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#59659}
-
- 11 Jan, 2019 1 commit
-
-
Jakob Kummerow authored
Dynamically process the arguments instead of hardcoding them, which is brittle when they change. Change-Id: I08f603dc6df6e3ed34518326b67da15f6a6d6102 Reviewed-on: https://chromium-review.googlesource.com/c/1405312 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58733}
-
- 18 Dec, 2018 1 commit
-
-
Jakob Kummerow authored
gm.py has been careful to only use the "pty" module's functionality on Linux, but as it turns out, the module is *so* strongly specific to Linux that even importing it fails on Windows. Making the import of "pty" conditional makes gm.py work on Windows. Change-Id: I0c1fb8a9a0299fde50e252337551d9395039f14d Reviewed-on: https://chromium-review.googlesource.com/c/1382738Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58335}
-
- 07 Nov, 2018 1 commit
-
-
Igor Sheludko authored
which will allow gm to work for more directories than just [<arch>].[<mode>]: gm.py ia32.release-nosnap.check gm.py x64.optdebug-ptr-compr cctest unittests Basically the new usage is: gm.py [<arch>].[<mode>[-<suffix>]].[<target>] [testname...] Once default gn configuration is created based on <arch> and <mode> the script user may change it and then use gm as usual. Bug: v8:8238 Change-Id: I9659b87073e815e0e4754f0a2f1056f3403c149c Reviewed-on: https://chromium-review.googlesource.com/c/1323734Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57328}
-
- 24 Oct, 2018 1 commit
-
-
Jakob Kummerow authored
This patch adds two improvements to gm.py: (1) Fix "mksnapshot failure" detection to match the error message that is generated when embedded builtins are enabled. (2) Run "gn gen" whenever build.ninja is missing. This can happen when out/<config>/args.gn exists already when gm.py is run for the first time. Bug: v8:6666, v8:8335 Change-Id: I71836b832754fa21b6443d57a6c3c49718a9a8d1 Reviewed-on: https://chromium-review.googlesource.com/c/1294174Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#56918}
-
- 15 Oct, 2018 1 commit
-
-
Bangfu Tao authored
This patch adds support for "gm.py android_arm.release.check" and similar invocations. Change-Id: I6e2204cb00f574d759b9e142ecabd2582153f707 Reviewed-on: https://chromium-review.googlesource.com/c/1278629 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#56659}
-
- 29 Jun, 2018 1 commit
-
-
jgruber authored
This change somehow got lost when relanding an earlier CL in https://crrev.com/c/1118139 Bug: v8:7891 Change-Id: I31244be136322cccfb465c24356f1d0fd5e0c6d6 Reviewed-on: https://chromium-review.googlesource.com/1119786Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54104}
-
- 28 Jun, 2018 2 commits
-
-
Jakob Gruber authored
This reverts commit 7a0d6a50. Reason for revert: Breaks no-slow-assert builds. Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org,jgruber@chromium.org Change-Id: I6b048e819846c4bd9a064f82e2f3c7609369cd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7891, v8:6688 Reviewed-on: https://chromium-review.googlesource.com/1118138Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54077}
-
jgruber authored
Slow asserts double the time spent in mksnapshot. While we want them enabled on our bot builds, local builds should be fast and don't necessarily need them. This also adds v8_enable_fast_mksnapshot as default in gm.py. Bug: v8:7891,v8:6688 Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 Reviewed-on: https://chromium-review.googlesource.com/1116552Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54074}
-
- 21 May, 2018 1 commit
-
-
Peter Marshall authored
It seems that the output on snapshot failure has changed, so failed snapshots were no longer being automatically re-run in gdb. Change-Id: I321a6055b5683db31d215b9c30827f4badca3df7 Reviewed-on: https://chromium-review.googlesource.com/1066058Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53269}
-
- 19 Jan, 2018 1 commit
-
-
Michael Lippautz authored
Avoids detecting local cores and guessing remote jobs. No-try: true Change-Id: I4a825b8dd922802c5f539419313888fd3b21b870 Reviewed-on: https://chromium-review.googlesource.com/876009 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#50733}
-
- 29 Nov, 2017 1 commit
-
-
Michael Starzinger authored
R=jkummerow@chromium.org Change-Id: Idc29d9cfe1900554c6ecac5f170e9dea001430ca Reviewed-on: https://chromium-review.googlesource.com/793191Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49700}
-
- 05 Sep, 2017 2 commits
-
-
Jakob Kummerow authored
Only the error cases of overwriting readonly properties need the language_mode to decide whether to throw or be silent. Reading it from the feedback vector's metadata (just like the C++ code in ic.cc does) removes the need to duplicate each stub for each language_mode ("StoreIC" + "StoreICStrict" etc.). Change-Id: Ic0c67f9d40ca36c65e41b4f162b2ab70d155e549 Reviewed-on: https://chromium-review.googlesource.com/647373Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47836}
-
Jakob Kummerow authored
And add the helpfully suggested flag to the GDB re-run of mksnapshot. NOTRY=true Change-Id: I52011aa580c8d3e557f869b8306b9b978c73b946 Reviewed-on: https://chromium-review.googlesource.com/647693Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47829}
-
- 18 Jul, 2017 1 commit
-
-
Jakob Kummerow authored
Bug: v8:6550 Change-Id: I888f91db1fd842d1fef8a5fb749da229dfb6ab97 Reviewed-on: https://chromium-review.googlesource.com/575756Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#46746}
-
- 30 Jun, 2017 1 commit
-
-
Michael Lippautz authored
- Properly detect whether the args.gn config actually wants goma. - Read out cpu count dynamically. NOTRY=true Bug: Change-Id: I7a687e873ef0b009ab6eaada384378d23e1dbb1e Reviewed-on: https://chromium-review.googlesource.com/558085 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#46362}
-
- 14 Jun, 2017 1 commit
-
-
Jakob Kummerow authored
Bug: v8:6474 Change-Id: I24d067ac77c2cb557d0b3f6e2c8c512761c160f1 Reviewed-on: https://chromium-review.googlesource.com/531384 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45944}
-
- 09 Jun, 2017 1 commit
-
-
Wiktor Garbacz authored
Change-Id: I2d8f4defd465b2f9838ed002add088da5b6739ef Reviewed-on: https://chromium-review.googlesource.com/528197Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#45815}
-
- 07 Jun, 2017 1 commit
-
-
bmeurer authored
R=jarin@chromium.org, jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2923983002 Cr-Commit-Position: refs/heads/master@{#45753}
-
- 02 Jun, 2017 1 commit
-
-
Jakob Kummerow authored
NOTRY=true Change-Id: I62ae81ef5e7439a19efbffdffd196f44c5c31349 Reviewed-on: https://chromium-review.googlesource.com/521041 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45687}
-
- 27 Apr, 2017 1 commit
-
-
Andreas Haas authored
R=jkummerow@chromium.org Change-Id: I6fc3817410df4f070675051397a30cc1b0ca7dfe Reviewed-on: https://chromium-review.googlesource.com/488030Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#44929}
-
- 21 Apr, 2017 2 commits
-
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2827263004 Cr-Commit-Position: refs/heads/master@{#44783}
-
Michael Lippautz authored
Bug: Change-Id: I532e8894df288c81a71b08ca85742f2847f57191 Reviewed-on: https://chromium-review.googlesource.com/484339 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#44781}
-
- 20 Apr, 2017 1 commit
-
-
jkummerow authored
Now you can do: "gm.py x64.release mkgrokdump" NOTRY=true Review-Url: https://codereview.chromium.org/2827383003 Cr-Commit-Position: refs/heads/master@{#44756}
-
- 12 Apr, 2017 1 commit
-
-
Franziska Hinkelmann authored
gdb_index is not in declare_args() and has no effect. NOTRY=true Change-Id: I88a9558937aa8fea30ab246899bea4a123947f82 Reviewed-on: https://chromium-review.googlesource.com/475772 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#44620}
-
- 22 Mar, 2017 1 commit
-
-
honggyu.kp authored
It would be better to generate ctags file for specified architecture so this CL adds a script gen-tags.py to generate architecture specific ctags. Usage: $ tools/dev/gen-tags.py [<arch>...] The example usage for 'x64' is as follows: $ tools/dev/gen-tags.py x64 If no <arch> is given, it generates tags file for all arches: $ tools/dev/gen-tags.py R=yangguo@chromium.org,jochen@chromium.org,jkummerow@chromium.org,clemensh@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2762903002 Cr-Commit-Position: refs/heads/master@{#44032}
-
- 17 Mar, 2017 1 commit
-
-
jkummerow authored
NOTRY=true Review-Url: https://codereview.chromium.org/2754253002 Cr-Commit-Position: refs/heads/master@{#43904}
-
- 07 Mar, 2017 1 commit
-
-
jkummerow authored
This requires serialized data to track the number of API-provided external references separately. And it flushes out a case of serialized data corruption (stored "length" field too large) that we didn't handle without crashing. BUG=v8:6055 Review-Url: https://codereview.chromium.org/2736923002 Cr-Commit-Position: refs/heads/master@{#43649}
-
- 22 Feb, 2017 1 commit
-
-
jkummerow authored
Convenience wrapper around building with gn/ninja and running tests. Follows Makefile syntax, but is more flexible; see --help. Pro tip: alias gm="tools/dev/gm.py" NOTRY=true Review-Url: https://codereview.chromium.org/2713663002 Cr-Commit-Position: refs/heads/master@{#43377}
-
- 02 Nov, 2016 1 commit
-
-
dschuff authored
'a' and 'w' are mutually exclusive and just 'a' is what we actually want. Linux doesn't care (it just takes the first one) but Windows throws a ValueError. R=machenbach@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2467363002 Cr-Commit-Position: refs/heads/master@{#40711}
-
- 22 Sep, 2016 1 commit
-
-
machenbach authored
BUG=chromium:648583 NOTRY=true Review-Url: https://codereview.chromium.org/2365573002 Cr-Commit-Position: refs/heads/master@{#39626}
-
- 02 Sep, 2016 1 commit
-
-
machenbach authored
This prepares using mb as a library and not as a sub process. It is used like that in the new list command that shows available configurations. Also added more robust checks of user inputs, better hints and better docu. BUG=chromium:625791 NOTRY=true Review-Url: https://codereview.chromium.org/2300333002 Cr-Commit-Position: refs/heads/master@{#39136}
-
- 21 Jul, 2016 1 commit
-
-
machenbach authored
Helper script to generate gn arguments based on common developer defaults or builder configurations. BUG=chromium:625791 NOTRY=true Review-Url: https://codereview.chromium.org/2138693002 Cr-Commit-Position: refs/heads/master@{#37947}
-