- 15 Mar, 2021 4 commits
-
-
Michael Lippautz authored
Cleanups around tracing bottlenecks and tests. Bug: chromium:1056170 Change-Id: I1f9ddd6d8727971db3bed5294f4ff3fdd20a9e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757696 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73394}
-
Hong Zheng authored
Add a V8 API to update load start time for RAIL PERFORMANCE_LOAD mode Bug: v8:10947 Change-Id: If86a815f8974b47a6f4ba82c3661c21b73f39553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423403 Auto-Submit: Hong Zheng <hong.zheng@intel.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73393}
-
Kim-Anh Tran authored
This changes the behavior of SetBreakpointForScript to find more accurate break positions. Previously, setting a breakpoint would only consider the shared function info that contained the requested position for setting a breakpoint. More intuitively, a breakpoint should not necessarily be set in a function that contains the position, but in the closest breakable location that comes after the position we requested. To achieve this we: 1. find the shared function info of the inner most function that contains the requested_position. This function's end position is used to find other shared function infos in step 2. 2. search for all shared function infos that intersect with the range [requested_position, inner_most_function.break_position[. 3. From the shared function infos extracted in 2, find the one that has the closest breakable location to requested_position. Also-By: bmeurer@chromium.org Fixed: chromium:1137141 Change-Id: I4f4c6c3aac1ebea50cbcad9543b539ab1ded2b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742198 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73392}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/421f3e0..5f2e66e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/58bac68..6e87bdd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/bb890d6..159efca Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e645571..91db20b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I496ee15bb259471bc77e856d91dbb29ab70ae657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758919Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73391}
-
- 14 Mar, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/linux64: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f79e66b832ab46ffbc3b3065613cd8a8e4ce563 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758912Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73390}
-
- 13 Mar, 2021 3 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7633fcf..421f3e0 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7242196..69cc9b8 Rolling v8/buildtools/linux64: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 Rolling v8/third_party/aemu-linux-x64: xkJqHNeFPOJ9cNmeaij9qrxQTAP8oRjXHcuTdg2nny8C..fU_J9KtzLrfiXhqpf_1eV01gy30M641raluN5uaKPNAC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7a3a736..58bac68 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e8b56fb..bb890d6 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I529b8768c8f7efd2d5960a8d10fa16fe914848df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758100Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73389}
-
Junliang Yan authored
Change-Id: I61af83e5f6399d82cd6cabdb2a4399f98f71cdb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756712Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73388}
-
Ng Zhi An authored
Bug: v8:11384 Change-Id: I5da5cc11c69844833ab703bd2fb439e4f51db501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750727Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73387}
-
- 12 Mar, 2021 29 commits
-
-
Ng Zhi An authored
If AVX is supported, don't need dst == src, this can save a move. Move the Andnps macro around, and update callsites in Liftoff. Bug: v8:11190 Change-Id: I7307b70943fdd91550d608cb91e9890f23d1b3ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750726Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73386}
-
Ng Zhi An authored
We no longer need unique register for src, since I64x2Abs macro-assembler handles the case when dst == src (by using the scratch). This is equivalent to calling the VisitRRSimd helper. Bug: v8:11190 Change-Id: Ibabb6da970e983ca2c9326057a6dc43cc7b7c435 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750725Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73385}
-
Milad Fa authored
Change-Id: I614d1ccf83e1275d06211917906e7094bfad5bc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757691Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73384}
-
Bill Budge authored
This reverts commit fb03b88e. Reason for revert: Very speculative revert to make Win64 ASAN bot green: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20ASAN/17685 Original change's description: > [web snapshots] Web Snapshots Version 0.01 > > The minimal implementation which does something useful. Initial > machinery for serializing / deserializing objects and functions (only > the very simple cases are supported). > > For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing > > Bug: v8:11525 > > Change-Id: I73c4de11285c7912bf9870868d203d4b3d2b4e5f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73371} Bug: v8:11525 Change-Id: I8e1ea8666f2d4d6eac3575a364e0532167dd3316 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757891 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#73383}
-
Milad Fa authored
Also fixed the disassembler to include 10th bit of instruction. Change-Id: Idc6659a8a9d6a291b68537bae533a32970a4441d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757567 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73382}
-
Clemens Backes authored
Just saw this on an unrelated change. This is a left-over from https://crrev.com/c/2007490. R=jkummerow@chromium.org Bug: v8:11384 Change-Id: Iaa6134458e05b58a15ff465b01a86d18bfabd746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756528Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73381}
-
Clemens Backes authored
A little cleanup after https://crrev.com/c/2752867. R=jkummerow@chromium.org Bug: v8:11238 Change-Id: I6e8b29c852ce6f8267f4b2fb4afe404659503a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756527Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73380}
-
Milad Fa authored
Port 8d0f5a04 Original Commit Message: Due to a recent change Liftoff used different register configurations in the pointer-compression and no-pointer-compression setups. This caused a mismatch between the registers used by Liftoff and the registers spilled by the WasmDebugBreak builtin. With this CL the same register configuration is used both with and without pointer compression. Even without x28 there are 24 registers that can be used. Moreover, 24 registers can be spilled without padding, which would be needed with 25 registers to preserve stack alignment. Drive-by change: Use Reglist in frame-constants on all platforms. R=ahaas@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ibad93faeaba88f929db16d239858da6e45ca673b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756550 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73379}
-
Michael Achenbach authored
This reverts commit 3094d598. Reason for revert: Breaks on Mac arm64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/3109 Original change's description: > [wx] Keep the execute bit while making code writable > > Otherwise SMC perturbs the icache too much it seems. > > Change-Id: Iceea779a7e3deee90efe29df568732d6ac5bcffa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753768 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73355} Change-Id: I4e85f6308ca22e366cdad4b621d233c3b1e3ed90 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756539 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73378}
-
Michael Lippautz authored
Actually apply the folding on allocation. Bug: chromium:1056170 Change-Id: Ief25fac49c5caff40579fd44249bba0ae82f9689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756536 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73377}
-
Milad Fa authored
This reverts commit 4fb19d56. Reason for revert: intermittent test failure on s390 native: d8 --test test/wasm-spec-tests/tests/proposals/reference-types/select.js --random-seed=1408892184 --nohard-abort --testing-d8-test-runner --stress-background-compile --finalize-streaming-on-background --stress-wasm-code-gc --experimental-wasm-reftypes --wasm-staging Original change's description: > s390x: [liftoff] implement Indirect/CallIndirect > > Change-Id: I953d1f9e1789cb6f754b1206edcac752e4f22801 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749575 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73327} Change-Id: I64fbf9a8ff9294500cac70142831f02806653e51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756548Reviewed-by: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73376}
-
Ulan Degenbaev authored
Bug: v8:9380 Change-Id: I47d23dda133c3838c7f0e8e5ccfdbe3b9520684f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720306Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73375}
-
Junliang Yan authored
Change-Id: I3f96414aa58fb7e5810036c669539b8593509ccf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756547Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73374}
-
Clemens Backes authored
We still get e.g. ClusterFuzz reports with enums printed as non-printable single-character strings (see linked bug). This CL fixes this, and also includes the integral enum value for enum that come with their own output operator. This makes error messages strictly better, at the cost of some more code per enum which is being used in a CHECK/DCHECK. Note that binary size of release builds is not affected, since we do not print the values there. R=nicohartmann@chromium.org Bug: v8:11384, chromium:1187484 Change-Id: I066b32f68440096babed9b629c7ffe3f2285cba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756226Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73373}
-
Santiago Aboy Solanes authored
Don't call UpdateDescriptors twice on {map} in the cases where {map} is not the initial map. Change-Id: I2005b8dda1b15c87e0bf1d933a16a2aedfa7ac6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743888Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73372}
-
Marja Hölttä authored
The minimal implementation which does something useful. Initial machinery for serializing / deserializing objects and functions (only the very simple cases are supported). For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing Bug: v8:11525 Change-Id: I73c4de11285c7912bf9870868d203d4b3d2b4e5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73371}
-
Yahan Lu authored
[codegen][frames] Generalize argument padding slot code" [wasm-simd][riscv64] Add i64x2 ne and alltrue Bug: v8:11347, v8:11348, v8:9198 Change-Id: I1338752fb9db332cd94500107bfd460f9167bb2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2690182 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#73370}
-
Mythri A authored
This flag enables feedback allocation heuristics to be based on the function size. The threshold for feedback allocation is set to 12 * bytecode size to roughly mimic the allocation after 12 invocations. We tried 4 * bytecode size earlier and there were few memory regressions on real world pages. Speedometer improved by ~1% [1, 2]. This time trying with a higher factor this time to see if we still have speedometer improvements without any memory regressions. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1177124 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1177241 Change-Id: I39c7d4aaf90b948b07419e4598e2193b8355c067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752150 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73369}
-
Junliang Yan authored
Use Read/WriteLittleEndianValue call to make sure we deal with wasm values in the correct endian order on big endian machine. Change-Id: I7ede8226319ecfd0605cefa1823e5bbaeb0ebb6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752879 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73368}
-
Mythri A authored
Currently Turboprop interrupt budget is 14*K. From finch experiments and from the local benchmark results it seems like we can push it back a bit. Increasing the interrupt budget for Turboprop also pushes the TurboFan compilations given the scale factor of 10. So this cl increases the Turboprop budget from 14*K to 20*K and TurboFan budget from 140*k to 200*K when turboprop is enabled. The default isn't impacted. Bug: v8:9684 Change-Id: I8603a215049dbc9da92f7da4b9e858624d263ae4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2643386 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73367}
-
Andreas Haas authored
Due to a recent change Liftoff used different register configurations in the pointer-compression and no-pointer-compression setups. This caused a mismatch between the registers used by Liftoff and the registers spilled by the WasmDebugBreak builtin. With this CL the same register configuration is used both with and without pointer compression. Even without x28 there are 24 registers that can be used. Moreover, 24 registers can be spilled without padding, which would be needed with 25 registers to preserve stack alignment. Drive-by change: Use Reglist in frame-constants on all platforms. R=jkummerow@chromium.org Bug: v8:7581 Change-Id: Iae2892718e905a7995a3fdd7be7fd4d75bebb3dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752884 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73366}
-
Jakob Kummerow authored
The recent arm64 improvements unintentionally required Python3. No-Try: true Change-Id: Ide94ea99cb69c530b3896e6577bd0b536e5374c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2754407Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73365}
-
Nico Hartmann authored
This CL moves FunctionTemplateInfo to the list of never serialized objects, allowing direct heap reads. To make this threadsafe, the CL: - adds necessary atomic (relaxed/acquire-release) operations to the accessors of FunctionTemplateInfo. - changes FunctionTemplateInfoRef::LookupHolderOfExpectedType to be usable from the background thread (e.g. no handle construction) with the caveat of skipping optimization in some cases where necessary JSObjects are not serialized. Drive-by: Add missing serialization of objects possibly reachable through CallHandlerInfo::data. Bug: v8:7790 Change-Id: I49cf4f328ecfab368dff9076fde8f5783ead3246 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679687Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73364}
-
Marja Hölttä authored
Change-Id: Ibc23b0440823ea17d592d729acf1787976612771 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752146Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73363}
-
Jakob Gruber authored
We can't properly guarantee that the interrupt is served from inside the irregexp engine (it could happen before or after). Without that guarantee, the test is prone to flaking. It's not very useful in general, since it essentially only tests that the CHECK(!regexp_stack_->is_in_use()) in regexp-stack.cc exists. The real fix is to support reentrancy. Bug: v8:11435,v8:11382 Change-Id: I0a8c3313dd9285ac0c84fef867196dede4785ebb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752159 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73362}
-
Ross McIlroy authored
This reverts commit 812eb264. Reason for revert: clusterfuzz crashes Original change's description: > [compiler] Cache StateValue processing in InstructionSelector. > > Processing StateValues into operands is one of the most costly > parts of instruction selection. As it happens, StateValues are > shared by many nodes, and so we are unecessarily reprocessing > the same StateValues multiple times. This CL introduces caching > for the processed StateValues enabling very fast emitting of > operands for subsiquent instructions with the same StateValue. > The hitrate for the cache is higher than 90% on most optimizations. > > BUG=v8:9684 > > Change-Id: I45db86dcbf22ab972b892f11c608b825aeb3ecf3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749634 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73342} Bug: v8:9684 Change-Id: I7d8121f91a0a7ed764add64f12f3954635921cfa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756208 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73361}
-
Toon Verwaest authored
This improves performance a little for especially small parsed objects, e.g., parsing json-parse-financial data in kraken 100.000 times goes from 3.25 s to 3.1 or below. Change-Id: Ic9b668b44fc766da9d8ad03f51924f7dd8b5cc7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752881Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73360}
-
Z Nguyen-Huu authored
This is a reland of 19b62d0b Fixing the misalignment issue founded in usban build by doing four-byte comparison: compressing the "expected" values such as script.name() and passing them to CheckProp as type Tagged_t Original change's description: > [v8windbg] Add more items in the Locals pane > > Add more items in the Locals pane representing the JS function name, > source file name, and character offset within the source file, so > that the user doesn’t need to dig through the shared_function_info to > find them. > > Change-Id: I5d42b3c9542885a72e81613503d1d5abf51870b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712310 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#73282} Change-Id: Idd77f61905651fbcfae5f5b590094639bc205834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744959Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73359}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cb067b2..7633fcf Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/368c7dd..7242196 Rolling v8/third_party/aemu-linux-x64: ee1oRcPCyneRYNLsuBvxMYnBajvkvvdJY5BYvoaX0vUC..xkJqHNeFPOJ9cNmeaij9qrxQTAP8oRjXHcuTdg2nny8C Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c2c576e..e8b56fb Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/348acca..0949050 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e65f1a7..e645571 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I18a2f9da689173e7ea3a79cc32634606543d2cf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752899Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73358}
-
- 11 Mar, 2021 3 commits
-
-
Milad Fa authored
Port 3f9ff062 Original Commit Message: This is a reland of 80f5dfda. A condition in pipeline.cc was inverted, which lead to a CSA verifier error. Original change's description: > [no-wasm] Exclude src/wasm from compilation > > This is the biggest chunk, including > - all of src/wasm, > - torque file for wasm objects, > - torque file for wasm builtins, > - wasm builtins, > - wasm runtime functions, > - int64 lowering, > - simd scala lowering, > - WasmGraphBuilder (TF graph construction for wasm), > - wasm frame types, > - wasm interrupts, > - the JSWasmCall opcode, > - wasm backing store allocation. > > Those components are all recursively entangled, so I found no way to > split this change up further. > > Some includes that were recursively included by wasm headers needed to > be added explicitly now. > > backing-store-unittest.cc is renamed to wasm-backing-store-unittest.cc > because it only tests wasm backing stores. This file is excluded from > no-wasm builds then. > > R=jkummerow@chromium.org, jgruber@chromium.org, mlippautz@chromium.org, petermarshall@chromium.org > > Bug: v8:11238 > Change-Id: I7558f2d12d2dd6c65128c4de7b79173668c80b2b > Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742955 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73344} R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I006f32407aea051c960f32942f9353f415547116 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753143Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73357}
-
Shu-yu Guo authored
Removes --harmony-string-replaceall (shipped since 8.5) --harmony-logical-assignment (shipped since 8.5) --harmony-atomics-waitasync (shipped since 8.7) Bug: v8:9801,v8:10372,v8:10239 Change-Id: Ifb8db93948a067e75da5e581603acb916b91342a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2747201 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73356}
-
Toon Verwaest authored
Otherwise SMC perturbs the icache too much it seems. Change-Id: Iceea779a7e3deee90efe29df568732d6ac5bcffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753768 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73355}
-