• Andreas Haas's avatar
    [wasm][liftoff][arm64] Avoid x28 even without pointer compression · 8d0f5a04
    Andreas Haas authored
    Due to a recent change Liftoff used different register configurations
    in the pointer-compression and no-pointer-compression setups. This
    caused a mismatch between the registers used by Liftoff and the
    registers spilled by the WasmDebugBreak builtin.
    
    With this CL the same register configuration is used both with and
    without pointer compression. Even without x28 there are 24 registers
    that can be used. Moreover, 24 registers can be spilled without
    padding, which would be needed with 25 registers to preserve stack
    alignment.
    
    Drive-by change: Use Reglist in frame-constants on all platforms.
    
    R=jkummerow@chromium.org
    
    Bug: v8:7581
    Change-Id: Iae2892718e905a7995a3fdd7be7fd4d75bebb3dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752884
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73366}
    8d0f5a04
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...